Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-23 Thread Silvia Pfeiffer
On Sat, Mar 23, 2013 at 7:34 AM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 6:43 PM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 6:39 PM, Silvia Pfeiffer >> wrote: >> >>> On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa wrote: >>> On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak w

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-22 Thread Tim Horton
On Mar 22, 2013, at 1:34 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 6:43 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 6:39 PM, Silvia Pfeiffer > wrote: > On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak wrote: > On Mar 21

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-22 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 6:43 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 6:39 PM, Silvia Pfeiffer wrote: > >> On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa wrote: >> >>> On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak wrote: >>> On Mar 21, 2013, at 5:38 PM, Glenn Adams wrote: >>>

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 6:39 PM, Silvia Pfeiffer wrote: > On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak wrote: >> >>> On Mar 21, 2013, at 5:38 PM, Glenn Adams wrote: >>> >>> On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa wrote: >>

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Silvia Pfeiffer
On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak wrote: > >> On Mar 21, 2013, at 5:38 PM, Glenn Adams wrote: >> >> On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa wrote: >> >>> On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams wrote: >>> >>>

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak wrote: > On Mar 21, 2013, at 5:38 PM, Glenn Adams wrote: > > On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams wrote: >> >>> >>> On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa wrote: >>> >>

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Maciej Stachowiak
On Mar 21, 2013, at 5:38 PM, Glenn Adams wrote: > > On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams wrote: > > On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: > That's my platform

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams wrote: > >> >> On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa wrote: >> >>> On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: >>> That's my platform, so I have to manage with it. >>>

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams wrote: > > On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: >> >>> That's my platform, so I have to manage with it. >>> >> >> I do have a Retina MBP too but I don't use it to work on the r

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: > >> That's my platform, so I have to manage with it. >> > > I do have a Retina MBP too but I don't use it to work on the rendering > engine precisely because of this issue. It's expected

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 5:04 PM, Silvia Pfeiffer wrote: > On Fri, Mar 22, 2013 at 10:55 AM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: >> >>> On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa wrote: >>> >> >> >>> In general, I don't recommend people running and re

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Silvia Pfeiffer
On Fri, Mar 22, 2013 at 10:55 AM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: > >> On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa wrote: >> > > >> In general, I don't recommend people running and relying on layout tests >>> on Retina MBP especially if you work on th

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams wrote: > On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 4:36 PM, Glenn Adams wrote: >> >>> >>> On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa wrote: >>> On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams wrote:

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 4:36 PM, Glenn Adams wrote: > >> >> On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa wrote: >> >>> On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams wrote: >>> On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa wrote:

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 4:36 PM, Glenn Adams wrote: > > On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams wrote: >> >>> On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa wrote: >>> Lately, I've encountering changesets that only add lines t

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams wrote: > >> On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa wrote: >> >>> Lately, I've encountering changesets that only add lines to >>> TestExpectations and then never baseline tests for any pla

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams wrote: > On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa wrote: > >> Lately, I've encountering changesets that only add lines to >> TestExpectations and then never baseline tests for any platform. >> > > This (never rebaseline tests for any platform in

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa wrote: > Lately, I've encountering changesets that only add lines to > TestExpectations and then never baseline tests for any platform. > This (never rebaseline tests for any platform in that changeset) may not be possible depending on circumstances

[webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Ryosuke Niwa
Lately, I've encountering changesets that only add lines to TestExpectations and then never baseline tests for any platform. This makes it impossible to figure out what the expected results is for other platforms the patch author doesn't contribute to / care about. Furthermore, I don't know how r