Re: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-11 Thread Timothy Hatcher 
> On Jul 9, 2016, at 3:22 PM, Sam Weinig  wrote:
> 
> It should probably get a parallel page to 
> https://webkit.org/code-style-guidelines/ 
>  and be updated with the same type 
> of right / wrong examples.

Yes, I agree it should be a separate document. We can work on putting that 
together.

> Our of curiosity, other than for features that simply aren’t available in C++ 
> / Objective-C (or vice-versa), are there places where the inspector JS 
> guideline deviates from what we do in the rest of WebKit?


We pretty much follow the C++ WebKit style for things that overlap in the 
syntax.

— Timothy Hatcher



smime.p7s
Description: S/MIME cryptographic signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-10 Thread Anthony Ricaud 
It would be nice for contributors if those rules were enforced by a linter, 
like ESLint.

> On 10 Jul 2016, at 00:22, Sam Weinig  wrote:
> 
> 
> 
> It should probably get a parallel page to 
> https://webkit.org/code-style-guidelines/ and be updated with the same type 
> of right / wrong examples.  
> 
> Our of curiosity, other than for features that simply aren’t available in C++ 
> / Objective-C (or vice-versa), are there places where the inspector JS 
> guideline deviates from what we do in the rest of WebKit?  
> 
> - Sam
> 
>> On Jul 7, 2016, at 11:29 AM, Geoffrey Garen  wrote:
>> 
>> 
>> 
>> To make this policy easy for new folks, I agree with Ryosuke that we should 
>> extract a JS and CSS style guide that is separate from Inspector-specific 
>> concerns.
>> 
>> Geoff
>> 
>>> On Jul 6, 2016, at 10:17 PM, Filip Pizlo  wrote:
>>> 
>>> I like the idea of adopting inspector style for JS builtins!
>>> 
>>> It might also be good to adopt it for JS tests that we write ourselves, 
>>> with an escape hatch if you need to violate style to test some feature. For 
>>> example, it should be a goal to follow inspector style for the JetStream 
>>> harness code, and probably for all of ES6SampleBench. New JS tests in 
>>> JavaScriptCore/tests/stress that we write ourselves probably should follow 
>>> inspector style, because it's code that we have to read and understand and 
>>> I can't think of a reason not to be consistent. Thoughts?
>>> 
>>> -Filip
>>> 
 On Jul 6, 2016, at 7:53 PM, Ryosuke Niwa  wrote:
 
> On Wed, Jul 6, 2016 at 7:34 PM, Dean Jackson  wrote:
> I propose we make it official that the Web Inspector Coding Style is what 
> must be used for all JavaScript and CSS that count as source code in the 
> project.
> https://trac.webkit.org/wiki/WebInspectorCodingStyleGuide
> 
> Now that JavaScript is used in more places (JS builtins, some parts of 
> the DOM, media controls) it would be nice to make it all consistent. Note 
> that the page above can't decide if it is just JS or both JS and CSS, but 
> I think it should be both.
 
 It's hard to tell which parts of the above guide would apply to
 non-Inspector JS code because it has a bunch of Inspector specific
 guidelines such as layering guides and references to
 https://trac.webkit.org/browser/trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css
 
 We should probably extract the parts that matter into a separate MD
 file or a section in the wiki page before we proceed with this
 discussion.
 
 - R. Niwa
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-09 Thread Sam Weinig 


It should probably get a parallel page to 
https://webkit.org/code-style-guidelines/ and be updated with the same type of 
right / wrong examples.  

Our of curiosity, other than for features that simply aren’t available in C++ / 
Objective-C (or vice-versa), are there places where the inspector JS guideline 
deviates from what we do in the rest of WebKit?  

- Sam

> On Jul 7, 2016, at 11:29 AM, Geoffrey Garen  wrote:
> 
> 
> 
> To make this policy easy for new folks, I agree with Ryosuke that we should 
> extract a JS and CSS style guide that is separate from Inspector-specific 
> concerns.
> 
> Geoff
> 
>> On Jul 6, 2016, at 10:17 PM, Filip Pizlo  wrote:
>> 
>> I like the idea of adopting inspector style for JS builtins!
>> 
>> It might also be good to adopt it for JS tests that we write ourselves, with 
>> an escape hatch if you need to violate style to test some feature. For 
>> example, it should be a goal to follow inspector style for the JetStream 
>> harness code, and probably for all of ES6SampleBench. New JS tests in 
>> JavaScriptCore/tests/stress that we write ourselves probably should follow 
>> inspector style, because it's code that we have to read and understand and I 
>> can't think of a reason not to be consistent. Thoughts?
>> 
>> -Filip
>> 
>>> On Jul 6, 2016, at 7:53 PM, Ryosuke Niwa  wrote:
>>> 
 On Wed, Jul 6, 2016 at 7:34 PM, Dean Jackson  wrote:
 I propose we make it official that the Web Inspector Coding Style is what 
 must be used for all JavaScript and CSS that count as source code in the 
 project.
 https://trac.webkit.org/wiki/WebInspectorCodingStyleGuide
 
 Now that JavaScript is used in more places (JS builtins, some parts of the 
 DOM, media controls) it would be nice to make it all consistent. Note that 
 the page above can't decide if it is just JS or both JS and CSS, but I 
 think it should be both.
>>> 
>>> It's hard to tell which parts of the above guide would apply to
>>> non-Inspector JS code because it has a bunch of Inspector specific
>>> guidelines such as layering guides and references to
>>> https://trac.webkit.org/browser/trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css
>>> 
>>> We should probably extract the parts that matter into a separate MD
>>> file or a section in the wiki page before we proceed with this
>>> discussion.
>>> 
>>> - R. Niwa
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-07 Thread manoj0011989 
Sent from my HTC

- Reply message -
From: "Filip Pizlo" <fpi...@apple.com>
To: "Ryosuke Niwa" <rn...@webkit.org>
Cc: "WebKit-Dev Development" <webkit-dev@lists.webkit.org>
Subject: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit 
JS/CSS source code
Date: Thu, Jul 7, 2016 10:47 AM

I like the idea of adop ting inspezctor style for JS builtins!

It might also be good to adopt it for JS tests that we write ourselves, with an 
escape hatch if you need to violate style to test some feature. For example, it 
should be a goal to follow inspector style for the JetStream harness code, and 
probably for all of ES6SampleBench. New JS tests in JavaScriptCore/tests/stress 
that we write ourselves probably should follow inspector style, because it's 
code that we have to read and understand and I can't think of a reason not to 
be consistent. Thoughts?

-Filip

> On Jul 6, 2016, at 7:53 PM, Ryosuke Niwa <rn...@webkit.org> wrote:
> 
>> On Wed, Jul 6, 2016 at 7:34 PM, Dean Jackson <d...@apple.com> wrote:
>> I propose we make it official that the Web Inspector Coding Style is what 
>> must be used for all JavaScript and CSS that count as source code in the 
>> project.
>> https://trac.webkit.org/wiki/WebInspectorCodingStyleGuide
>> 
>> Now that JavaScript is used in more places (JS builtins, some parts of the 
>> DOM, media controls) it would be nice to make it all consistent. Note that 
>> the page above can't decide if it is just JS or both JS and CSS, but I think 
>> it should be both.
> 
> It's hard to tell which parts of the above guide would apply to
> non-Inspector JS code because it has a bunch of Inspector specific
> guidelines such as layering guides and references to
> https://trac.webkit.org/browser/trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css
> 
> We should probably extract the parts that matter into a separate MD
> file or a section in the wiki page before we proceed with this
> discussion.
> 
> - R. Niwa
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-06 Thread Filip Pizlo 
I like the idea of adopting inspector style for JS builtins!

It might also be good to adopt it for JS tests that we write ourselves, with an 
escape hatch if you need to violate style to test some feature. For example, it 
should be a goal to follow inspector style for the JetStream harness code, and 
probably for all of ES6SampleBench. New JS tests in JavaScriptCore/tests/stress 
that we write ourselves probably should follow inspector style, because it's 
code that we have to read and understand and I can't think of a reason not to 
be consistent. Thoughts?

-Filip

> On Jul 6, 2016, at 7:53 PM, Ryosuke Niwa  wrote:
> 
>> On Wed, Jul 6, 2016 at 7:34 PM, Dean Jackson  wrote:
>> I propose we make it official that the Web Inspector Coding Style is what 
>> must be used for all JavaScript and CSS that count as source code in the 
>> project.
>> https://trac.webkit.org/wiki/WebInspectorCodingStyleGuide
>> 
>> Now that JavaScript is used in more places (JS builtins, some parts of the 
>> DOM, media controls) it would be nice to make it all consistent. Note that 
>> the page above can't decide if it is just JS or both JS and CSS, but I think 
>> it should be both.
> 
> It's hard to tell which parts of the above guide would apply to
> non-Inspector JS code because it has a bunch of Inspector specific
> guidelines such as layering guides and references to
> https://trac.webkit.org/browser/trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css
> 
> We should probably extract the parts that matter into a separate MD
> file or a section in the wiki page before we proceed with this
> discussion.
> 
> - R. Niwa
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-06 Thread Ryosuke Niwa 
On Wed, Jul 6, 2016 at 7:34 PM, Dean Jackson  wrote:
> I propose we make it official that the Web Inspector Coding Style is what 
> must be used for all JavaScript and CSS that count as source code in the 
> project.
> https://trac.webkit.org/wiki/WebInspectorCodingStyleGuide
>
> Now that JavaScript is used in more places (JS builtins, some parts of the 
> DOM, media controls) it would be nice to make it all consistent. Note that 
> the page above can't decide if it is just JS or both JS and CSS, but I think 
> it should be both.

It's hard to tell which parts of the above guide would apply to
non-Inspector JS code because it has a bunch of Inspector specific
guidelines such as layering guides and references to
https://trac.webkit.org/browser/trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css

We should probably extract the parts that matter into a separate MD
file or a section in the wiki page before we proceed with this
discussion.

- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

2016-07-06 Thread Dean Jackson 
I propose we make it official that the Web Inspector Coding Style is what must 
be used for all JavaScript and CSS that count as source code in the project.
https://trac.webkit.org/wiki/WebInspectorCodingStyleGuide

Now that JavaScript is used in more places (JS builtins, some parts of the DOM, 
media controls) it would be nice to make it all consistent. Note that the page 
above can't decide if it is just JS or both JS and CSS, but I think it should 
be both.

This would not include LayoutTests or PerformanceTests. It's the wild west in 
there - you can do whatever you want.


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev