Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-02-05 Thread Xabier Rodríguez Calvar
O Mar, 04-02-2014 ás 13:11 +0100, Osztrogonác Csaba escribiu: I've checked the full clean build time of GTK port on a quad core i5-2320 (3GHz) machine with icecc buildfarm and -j30 makeflag: - with SVG disabled:WebKit is now built (11m:58s). - with SVG enabled: WebKit is now built (13m:38s).

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-02-05 Thread Osztrogonác Csaba
Hi, Xabier Rodríguez Calvar írta: O Mar, 04-02-2014 ás 13:11 +0100, Osztrogonác Csaba escribiu: I've checked the full clean build time of GTK port on a quad core i5-2320 (3GHz) machine with icecc buildfarm and -j30 makeflag: - with SVG disabled:WebKit is now built (11m:58s). - with SVG

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-02-04 Thread Osztrogonác Csaba
Alberto Garcia írta: On Fri, Jan 31, 2014 at 12:43:16PM +0100, Osztrogonác Csaba wrote: The --no-svg build is broken now, and the change broke it is 11 months old change Not in the GTK+ port at least, I've been able to do builds without SVG perfectly fine, so there's probably something else

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-02-04 Thread Osztrogonác Csaba
Xabier Rodríguez Calvar írta: Sorry for the late answer, but I was in Brussels at FOSDEM. O Ven, 31-01-2014 ás 14:01 +0100, Alberto Garcia escribiu: Not in the GTK+ port at least, I've been able to do builds without SVG perfectly fine, so there's probably something else wrong in your

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-02-04 Thread Steven Coul (scoul)
I agree, the time taken to build is not really a good reason for the change or lack of - as you point out there, are many other ways to optimize the build process/server which will have wider benefits. But does anybody consider size to be an issue? SVG adds a fair chunk to the size of a binary

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-02-04 Thread Dirk Schulze
On Feb 4, 2014, at 5:20 AM, Steven Coul (scoul) sc...@cisco.com wrote: I agree, the time taken to build is not really a good reason for the change or lack of - as you point out there, are many other ways to optimize the build process/server which will have wider benefits. But does

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-02-04 Thread Steven Coul (scoul)
My big worry about that, is that somewhere somebody is thinking about using that argument to add Flash and/or Moonlight to Webkit - and down that path madness lies ;-) There really aren’t any “size-hogs” in WK other than SVG itself - but it’s been a while since I looked I admit. I tend to

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-02-04 Thread Benjamin Poulain
On 2/4/14, 7:08 AM, Steven Coul (scoul) wrote: My big worry about that, is that somewhere somebody is thinking about using that argument to add Flash and/or Moonlight to Webkit - and down that path madness lies ;-) There really aren’t any “size-hogs” in WK other than SVG itself - but it’s

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-02-03 Thread Xabier Rodríguez Calvar
Sorry for the late answer, but I was in Brussels at FOSDEM. O Ven, 31-01-2014 ás 14:01 +0100, Alberto Garcia escribiu: Not in the GTK+ port at least, I've been able to do builds without SVG perfectly fine, so there's probably something else wrong in your environment or the port you're using.

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-01-31 Thread Osztrogonác Csaba
Hi, +1 for removing ENABLE(SVG) guards. The --no-svg build is broken now, and the change broke it is 11 months old change - https://trac.webkit.org/changeset/145450, so --no-svg build isn't maintained at all and nobody can use it on trunk. Let's go forward and remove the guards:

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-01-29 Thread Antti Koivisto
Yes, let's remove the flag. It is too easy to break the no-SVG build and the guards uglify the code. antti On Wed, Jan 29, 2014 at 2:13 AM, Sam Weinig wei...@apple.com wrote: Hi Everyone, While we are discussing removing #ifdefs that everyone has enabled, I'd like to propose removing

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-01-29 Thread Chang Shu
I used to make no-SVG builds to save some time. But it won't make too much sense anymore to justify the effort of maintaining this flag. I support removing it. Chang On Wed, Jan 29, 2014 at 3:53 AM, Antti Koivisto koivi...@iki.fi wrote: Yes, let's remove the flag. It is too easy to break the

[webkit-dev] Proposal: Remove ENABLE(SVG)

2014-01-28 Thread Sam Weinig
Hi Everyone, While we are discussing removing #ifdefs that everyone has enabled, I’d like to propose removing ENABLE(SVG), as every port has SVG enabled. The only argument I have heard for keeping it around is to keep a “minimal build” working, but I don’t think the clutter of the #ifdefs is

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-01-28 Thread Thomas Fletcher
@lists.webkit.org Development webkit-dev@lists.webkit.org Subject: [webkit-dev] Proposal: Remove ENABLE(SVG) Date: Tue, Jan 28, 2014 18:13 Hi Everyone, While we are discussing removing #ifdefs that everyone has enabled, I’d like to propose removing ENABLE(SVG), as every port has SVG enabled. The only

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-01-28 Thread Benjamin Poulain
On 1/28/14, 4:20 PM, Thomas Fletcher wrote: Not a true statement if you consider out of tree ports. None of the ports we have done at Crank have used or needed svg support and as embedded systems, they all benefit from the smaller footprint. Out of tree ports that do not contribute back

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-01-28 Thread Sam Weinig
On Jan 28, 2014, at 4:20 PM, Thomas Fletcher tho...@cranksoftware.com wrote: Not a true statement if you consider out of tree ports. In general, we do not take in consideration ports that don’t contribute back or live in tree. None of the ports we have done at Crank have used or needed svg

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-01-28 Thread Andreas Kling
This sounds good to me. A WebKit without SVG support is scarcely a WebKit at all. On Jan 28, 2014, at 4:13 PM, Sam Weinig wei...@apple.com wrote: Hi Everyone, While we are discussing removing #ifdefs that everyone has enabled, I’d like to propose removing ENABLE(SVG), as every port has

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-01-28 Thread Dirk Schulze
On Jan 28, 2014, at 4:51 PM, Philip Rogers p...@google.com wrote: This will make hacking on WebKit much easier. For better or worse, SVG is tightly coupled with the rest of rendering/. We recently measured SVG usage on the web and found 10% of all pageviews contain SVG. Do you plan to remove

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-01-28 Thread Sam Weinig
On Jan 28, 2014, at 4:51 PM, Philip Rogers p...@google.com wrote: This will make hacking on WebKit much easier. For better or worse, SVG is tightly coupled with the rest of rendering/. We recently measured SVG usage on the web and found 10% of all pageviews contain SVG. Interesting stat!