[webkit-dev] Question regarding rebaseline for Layout Test Result for EFL port

2012-01-23 Thread Gyuyoung Kim
Hello WebKit folks. It looks that the result of layout test for EFL port needs rebaseline because of 101343. The revision modified line spacing of font in SimpleFontDataFreeType.cpp, and it seems that the existing layout test result of EFL port was influenced by it. (

Re: [webkit-dev] Question regarding rebaseline for Layout Test Result for EFL port

2012-01-23 Thread James Robinson
On Mon, Jan 16, 2012 at 12:02 AM, Gyuyoung Kim gyuyo...@gmail.com wrote: Hello WebKit folks. It looks that the result of layout test for EFL port needs rebaseline because of 101343. The revision modified line spacing of font in SimpleFontDataFreeType.cpp, and it seems that the existing

Re: [webkit-dev] Question regarding rebaseline for Layout Test Result for EFL port

2012-01-17 Thread Martin Robinson
On Mon, Jan 16, 2012 at 5:00 PM, Gyuyoung Kim gyuyoung@samsung.com wrote: Hello Antonio, Ok, I'm going to update the test results for EFL port as GTK port's way. As far as I know, you shouldn't need to rebaseline anything unless you take a similar approach to what we did in r99147. This

[webkit-dev] Question regarding rebaseline for Layout Test Result for EFL port

2012-01-17 Thread Gyuyoung Kim
Hello Martin, It seems EFL DRT is also using similar approach. The getFontDirectories() is called when EFL DRT is started. http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/FontManagement.cpp#L36 So, I think about 4,000 test cases are failed after r101343. -- Gyuyoung On Tue, Jan

[webkit-dev] Question regarding rebaseline for Layout Test Result for EFL port

2012-01-16 Thread Gyuyoung Kim
Hello WebKit folks. It looks that the result of layout test for EFL port needs rebaseline because of 101343. The revision modified line spacing of font in SimpleFontDataFreeType.cpp, and it seems that the existing layout test result of EFL port was influenced by it.

Re: [webkit-dev] Question regarding rebaseline for Layout Test Result for EFL port

2012-01-16 Thread Antonio Gomes
I would say GTK's way is pretty acceptable in this case. On Mon, Jan 16, 2012 at 3:21 AM, Gyuyoung Kim gyuyoung@samsung.comwrote: Hello WebKit folks. It looks that the result of layout test for EFL port needs rebaseline because of 101343. The revision modified line spacing of font in

Re: [webkit-dev] Question regarding rebaseline for Layout Test Result for EFL port

2012-01-16 Thread Gyuyoung Kim
Hello Antonio, Ok, I'm going to update the test results for EFL port as GTK port's way. - gyuyoung. --- Original Message --- Sender : Antonio Gomestoniki...@gmail.com Date : 2012-01-17 02:54 (GMT+09:00) Title : Re: [webkit-dev] Question regarding rebaseline for Layout Test Result