On Dec 9, 2009, at 10:11 AM, Chris Marrin wrote:
On Dec 9, 2009, at 9:41 AM, Maciej Stachowiak wrote:
I meant 4 spaces from the switch (i.e. 2 additional spaces from the
case label).
switch (x) {
case foo: {
fooFunc();
}
case bar:
barFunc();
}
Ok, the example above seems to be mi
On Dec 9, 2009, at 11:25 AM, Adam Treat wrote:
> That speaks negatively to the real world value of the rule IMHO.
A lot of the code predates the rule, so I wouldn’t judge the effectiveness of
the rule too harshly.
-- Darin
___
webkit-dev mailing
On Wed, Dec 9, 2009 at 10:11 AM, Chris Marrin wrote:
> 1) Case labels always have the same indentation as their switch (today's
>> rule)
>
> If excessive indentation really is that big of a concern (which I don't
> think it is) I would rather see the current rule (rule 1) used.
>
> From the last
On Wednesday 09 December 2009 02:04:07 pm Darin Adler wrote:
> On Dec 9, 2009, at 10:57 AM, Adam Treat wrote:
> > Ok, well FWIW I disagree that the current rule makes things hard to read
> > and I do not like the idea of changing it. I object on the same grounds
> > as the other recent styling chan
On Dec 9, 2009, at 10:57 AM, Adam Treat wrote:
> Ok, well FWIW I disagree that the current rule makes things hard to read and
> I do not like the idea of changing it. I object on the same grounds as the
> other recent styling change proposals as well as substantively that it makes
> anything ea
On Wednesday 09 December 2009 01:03:23 pm Chris Marrin wrote:
> > What is wrong with keeping the current rule?
>
> As I pointed out in the previous thread, I feel like it makes the code
> harder to read, and got several responses of agreement. Also most of
> the switch statements in the code curren
On Dec 9, 2009, at 9:41 AM, Maciej Stachowiak wrote:
On Dec 9, 2009, at 7:26 AM, Chris Marrin wrote:
I saw another patch get rejected today because of switch statement
indentation. We discussed this last week, and I saw a lot of
support for my proposal of indenting case labels from thei
On Dec 9, 2009, at 8:13 AM, Adam Treat wrote:
On Wednesday 09 December 2009 10:26:24 am Chris Marrin wrote:
I saw another patch get rejected today because of switch statement
indentation. We discussed this last week, and I saw a lot of support
for my proposal of indenting case labels from thei
On Dec 9, 2009, at 7:26 AM, Chris Marrin wrote:
I saw another patch get rejected today because of switch statement
indentation. We discussed this last week, and I saw a lot of support
for my proposal of indenting case labels from their switch. But the
discussion did not end in resolution
On Wednesday 09 December 2009 10:26:24 am Chris Marrin wrote:
> I saw another patch get rejected today because of switch statement
> indentation. We discussed this last week, and I saw a lot of support
> for my proposal of indenting case labels from their switch. But the
> discussion did not end in
I saw another patch get rejected today because of switch statement
indentation. We discussed this last week, and I saw a lot of support
for my proposal of indenting case labels from their switch. But the
discussion did not end in resolution. To summarize, here are the
options mentioned:
11 matches
Mail list logo
