Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-07 Thread Roland Steiner
On Wed, Apr 7, 2010 at 6:19 PM, Maciej Stachowiak wrote: > > I'm not sure I understand that goal. It's pretty normal for an iterator > type to be distinct from the type of thing it iterates over. > vector::iterator is not the same as T, even though it iterates over Ts. > It is also not the same a

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-07 Thread Maciej Stachowiak
On Apr 7, 2010, at 1:59 AM, Roland Steiner wrote: On Wed, Apr 7, 2010 at 4:36 PM, Maciej Stachowiak wrote: It's not clear to me how "PositionIterator" is the same concept as "EditingPosition". The latter implies that it would only ever represent a position where you can edit. The former

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-07 Thread Roland Steiner
On Wed, Apr 7, 2010 at 4:36 PM, Maciej Stachowiak wrote: > > It's not clear to me how "PositionIterator" is the same concept as > "EditingPosition". The latter implies that it would only ever represent a > position where you can edit. The former implies that it produces a sequence > of positions

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-07 Thread Maciej Stachowiak
On Apr 7, 2010, at 12:11 AM, Roland Steiner wrote: Hard to comment on this idea from such a high level view. I don't understand how EditingPosition is meant to be different from VisiblePosition. Is EditingPosition just a VisiblePosition that's also a place where you can edit? I don't und

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-07 Thread Roland Steiner
Thanks for the comments! Please find my replies inline: On Tue, Apr 6, 2010 at 2:51 PM, Maciej Stachowiak wrote: > > On Apr 1, 2010, at 10:43 PM, Roland Steiner wrote: > > .) When a selection that starts in a table and ends outside it is deleted, > the current code drags the adjacent outside con

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-06 Thread Ken Kocienda
See my comments below. Thanks. – Ken On Apr 5, 2010, at 10:30 PM, Roland Steiner wrote: > One additional question on position classes: > > The current implementation allows for (and operates on) positions such as > [img, 0] - [img, 1] or [br,0] - [br, 1]. Is there a fundamental reason to >

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-06 Thread Darin Adler
On Apr 6, 2010, at 9:29 AM, Alexey Proskuryakov wrote: > 05.04.2010, в 22:46, Maciej Stachowiak написал(а): > >>> The current implementation allows for (and operates on) positions such as >>> [img, 0] - [img, 1] or [br,0] - [br, 1]. Is there a fundamental reason to >>> keep such positions withi

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-06 Thread Alexey Proskuryakov
05.04.2010, в 22:46, Maciej Stachowiak написал(а): >> The current implementation allows for (and operates on) positions such as >> [img, 0] - [img, 1] or [br,0] - [br, 1]. Is there a fundamental reason to >> keep such positions within the internal representation rather than normalize >> them t

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-05 Thread Maciej Stachowiak
On Apr 1, 2010, at 10:43 PM, Roland Steiner wrote: Hi all, As I am working on WebKit rich text editing these days, there are 2 issues that I would like to address. From a brief internal discussion both seem feasible and worthwhile, but since they involve changes to current code and behav

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-05 Thread Maciej Stachowiak
On Apr 5, 2010, at 10:30 PM, Roland Steiner wrote: One additional question on position classes: The current implementation allows for (and operates on) positions such as [img, 0] - [img, 1] or [br,0] - [br, 1]. Is there a fundamental reason to keep such positions within the internal repr

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-05 Thread Roland Steiner
One additional question on position classes: The current implementation allows for (and operates on) positions such as [img, 0] - [img, 1] or [br,0] - [br, 1]. Is there a fundamental reason to keep such positions within the internal representation rather than normalize them to [parent-of-img, inde

[webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-01 Thread Roland Steiner
Hi all, As I am working on WebKit rich text editing these days, there are 2 issues that I would like to address. From a brief internal discussion both seem feasible and worthwhile, but since they involve changes to current code and behavior I wanted to ask the WebKit community in general, and the