[webkit-dev] Should we ever change style guidelines? (was Re: Resolution on switch statement indentation)

2009-12-09 Thread Chris Jerdonek
At first glance these "meta-guidelines" seem fine. If they are going to be written down somewhere, a couple minor comments: On Dec 9, 2009, Maciej Stachowiak wrote: > I think something like > the following should be our "meta-guidelines" for when to change the > style guide: It would be good to

Re: [webkit-dev] Should we ever change style guidelines? (was Re: Resolution on switch statement indentation)

2009-12-09 Thread Dirk Pranke
On Wed, Dec 9, 2009 at 1:02 PM, Maciej Stachowiak wrote: > That's my thinking on the matter, perhaps others have other opinions. > Regards, > Maciej +1. Very sound rules of thumb; please preserve them somewhere! FWIW, these are basically the principles we followed at Oracle; the only additional p

Re: [webkit-dev] Should we ever change style guidelines? (was Re: Resolution on switch statement indentation)

2009-12-09 Thread Jeremy Orlow
For what it's worth, I completely agree as well. Can we take this and put it in the style guide? That way it's perfectly clear to people under what circumstances we would consider changing it and we can even cite specific reason numbers in the discussions? On Wed, Dec 9, 2009 at 1:05 PM, Darin A

Re: [webkit-dev] Should we ever change style guidelines? (was Re: Resolution on switch statement indentation)

2009-12-09 Thread Darin Adler
On Dec 9, 2009, at 1:02 PM, Maciej Stachowiak wrote: > That's my thinking on the matter, perhaps others have other opinions. Perhaps no surprise to the rest of you, but I agree with every word Maciej said. -- Darin ___ webkit-dev mailing list webk

[webkit-dev] Should we ever change style guidelines? (was Re: Resolution on switch statement indentation)

2009-12-09 Thread Maciej Stachowiak
Hi Adam, On Dec 9, 2009, at 11:25 AM, Adam Treat wrote: Yep, that does distinguish. That being said, my personal preference would be either to keep the current rule and change the code to meet it or even better just eliminate the rule altogether since the community hasn't been following