Re: [webkit-dev] Some new coding style rules

2010-08-05 Thread Sam Weinig
On Wed, Aug 4, 2010 at 1:29 AM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: namespace WebCore { ... } // namespace WebCore 2. ENABLE(FOO) #endif comments #if ENABLE(FOO) .. #endif // ENABLE(FOO) I like these two forms of comments. -Sam

Re: [webkit-dev] Some new coding style rules

2010-08-05 Thread Tor Arne Vestbø
On 04.08.10 20.04, Adam Roben wrote: On Aug 4, 2010, at 7:15 AM, Jeremy Orlow wrote: 2. ENABLE(FOO) #endif comments #if ENABLE(FOO) .. #endif // ENABLE(FOO) Shall we remove the comment, or require it explicitely in the style rules? I find these comments especially helpful when there are

Re: [webkit-dev] Some new coding style rules

2010-08-05 Thread David Kilzer
On Wed, August 4, 2010 at 11:56:53 PM, Sam Weinig wrote: On Wed, Aug 4, 2010 at 1:29 AM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: namespace WebCore { ... } // namespace WebCore 2. ENABLE(FOO) #endif comments #if ENABLE(FOO) .. #endif // ENABLE(FOO) I like these

[webkit-dev] Some new coding style rules

2010-08-04 Thread Nikolas Zimmermann
Good morning WebKit crowd, I'd like to discuss some style issues, that I'm frequently unsure about: 1. namespace closing brace It was discussed in http://article.gmane.org/gmane.os.opendarwin.webkit.devel/10563 , but with no real result. When writing headers, do we need the // namespace Foo

Re: [webkit-dev] Some new coding style rules

2010-08-04 Thread Jeremy Orlow
On Wed, Aug 4, 2010 at 9:29 AM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: Good morning WebKit crowd, I'd like to discuss some style issues, that I'm frequently unsure about: 1. namespace closing brace It was discussed in

Re: [webkit-dev] Some new coding style rules

2010-08-04 Thread Nikolas Zimmermann
Am 04.08.2010 um 13:15 schrieb Jeremy Orlow: On Wed, Aug 4, 2010 at 9:29 AM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: Good morning WebKit crowd, I'd like to discuss some style issues, that I'm frequently unsure about: 1. namespace closing brace It was discussed in

Re: [webkit-dev] Some new coding style rules

2010-08-04 Thread Darin Adler
On Aug 4, 2010, at 1:29 AM, Nikolas Zimmermann wrote: 1. namespace closing brace It was discussed in http://article.gmane.org/gmane.os.opendarwin.webkit.devel/10563, but with no real result. When writing headers, do we need the // namespace Foo comment after the namespace closing

Re: [webkit-dev] Some new coding style rules

2010-08-04 Thread Maciej Stachowiak
On Aug 4, 2010, at 10:43 AM, Darin Adler wrote: On Aug 4, 2010, at 1:29 AM, Nikolas Zimmermann wrote: 1. namespace closing brace It was discussed in http://article.gmane.org/gmane.os.opendarwin.webkit.devel/10563, but with no real result. When writing headers, do we need the //