Re: [webkit-dev] Streams API
I opened a meta-bug at https://bugs.webkit.org/show_bug.cgi?id=138561 I also plan to close bugs related to the previous "stream API" proposal (https://bugs.webkit.org/show_bug.cgi?id=110194 and https://bugs.webkit.org/show_bug.cgi?id=110558). 2014-11-03 7:57 GMT+01:00 Benjamin Poulain : > It looks like nobody has raised any concern against Streams API. We even got > positive feedback from Anne. :) > > I have two concerns: > 1) You have many patches waiting for review. I think you need to get better > communication channels with reviewers in order to iterate over your patches > faster. It is unfortunate but getting complex patches reviewed in WebKit > requires poking reviewers directly. Since you work on the network stack, I > suggest asking Alexey (ap) and Pratik (psolanki) on IRC, they can help with > reviews or suggest other reviewers. > 2) Streams is a large spec and it touches platform code. Please be careful > with stability, make more tests than reasonable and #ifdef everything. > > I suggest the flag name "ENABLE_STREAMS_API", I find "ENABLE_STREAMS" a bit > too generic. > > If you open a meta bug, please send the bug number to the mailing list for > reference. > > Good luck :) > Benjamin > > > On 10/30/14, 4:02 PM, youenn fablet wrote: >> >> Hi all, >> >> I would like to add support for the streams API ([1], [2]), starting >> with readable streams and their integration with XHR and loaders. >> This work is expected to happen behind a flag. >> >> Regards, >> Youenn >> >> [1] https://github.com/whatwg/streams >> [2] http://www.w3.org/TR/streams-api/ >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Streams API
O Lun, 03-11-2014 ás 10:08 +0100, youenn fablet escribiu: > Hi Benjamin, > > > I have two concerns: > > 1) You have many patches waiting for review. I think you need to get better > > communication channels with reviewers in order to iterate over your patches > > faster. It is unfortunate but getting complex patches reviewed in WebKit > > requires poking reviewers directly. Since you work on the network stack, I > > suggest asking Alexey (ap) and Pratik (psolanki) on IRC, they can help with > > reviews or suggest other reviewers. > > Thanks for the suggestion, I will try to do so for my pending patches. > For the particular streams API work, I am teaming up with some Igalia fellows. > I hope that we can make good progress that way. Yes, I will be working with Youenn on making this happen. I guess the action will begin soon. Best regards. signature.asc Description: This is a digitally signed message part ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Streams API
In any case, ensuring that the streams API works efficiently for HTTP exchanges in WebKit is top priority imho, no matter whether tied to fetch or XHR at the end of the day. 2014-11-02 17:34 GMT+01:00 Anne van Kesteren : > On Sun, Nov 2, 2014 at 2:56 PM, youenn fablet wrote: >> Meaning that only the fetch API would at some point support streams? >> If so, I wonder why we should postpone a small but useful feature to a >> nice but future API. > > I suspect there will be many APIs that support streams. It's been a > sorely missing building block. And fetch() is not a future API. It's > being implemented now in both Blink and Gecko. > > > -- > https://annevankesteren.nl/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Streams API
Hi Benjamin, > I have two concerns: > 1) You have many patches waiting for review. I think you need to get better > communication channels with reviewers in order to iterate over your patches > faster. It is unfortunate but getting complex patches reviewed in WebKit > requires poking reviewers directly. Since you work on the network stack, I > suggest asking Alexey (ap) and Pratik (psolanki) on IRC, they can help with > reviews or suggest other reviewers. Thanks for the suggestion, I will try to do so for my pending patches. For the particular streams API work, I am teaming up with some Igalia fellows. I hope that we can make good progress that way. > 2) Streams is a large spec and it touches platform code. Please be careful > with stability, make more tests than reasonable and #ifdef everything. > > I suggest the flag name "ENABLE_STREAMS_API", I find "ENABLE_STREAMS" a bit > too generic. Ah, I was thinking of using ENABLE_STREAMS. ENABLE_STREAMS_API is fine by me. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Streams API
It looks like nobody has raised any concern against Streams API. We even got positive feedback from Anne. :) I have two concerns: 1) You have many patches waiting for review. I think you need to get better communication channels with reviewers in order to iterate over your patches faster. It is unfortunate but getting complex patches reviewed in WebKit requires poking reviewers directly. Since you work on the network stack, I suggest asking Alexey (ap) and Pratik (psolanki) on IRC, they can help with reviews or suggest other reviewers. 2) Streams is a large spec and it touches platform code. Please be careful with stability, make more tests than reasonable and #ifdef everything. I suggest the flag name "ENABLE_STREAMS_API", I find "ENABLE_STREAMS" a bit too generic. If you open a meta bug, please send the bug number to the mailing list for reference. Good luck :) Benjamin On 10/30/14, 4:02 PM, youenn fablet wrote: Hi all, I would like to add support for the streams API ([1], [2]), starting with readable streams and their integration with XHR and loaders. This work is expected to happen behind a flag. Regards, Youenn [1] https://github.com/whatwg/streams [2] http://www.w3.org/TR/streams-api/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Streams API
On Sun, Nov 2, 2014 at 2:56 PM, youenn fablet wrote: > Meaning that only the fetch API would at some point support streams? > If so, I wonder why we should postpone a small but useful feature to a > nice but future API. I suspect there will be many APIs that support streams. It's been a sorely missing building block. And fetch() is not a future API. It's being implemented now in both Blink and Gecko. -- https://annevankesteren.nl/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Streams API
Meaning that only the fetch API would at some point support streams? If so, I wonder why we should postpone a small but useful feature to a nice but future API. 2014-10-31 8:48 GMT+01:00 Anne van Kesteren : > On Fri, Oct 31, 2014 at 12:02 AM, youenn fablet wrote: >> I would like to add support for the streams API, starting >> with readable streams and their integration with XHR and loaders. >> This work is expected to happen behind a flag. > > There's no planned integration with XMLHttpRequest. > > > -- > https://annevankesteren.nl/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Streams API
On Fri, Oct 31, 2014 at 9:07 AM, Benjamin Poulain wrote: > Any opinion for or against Streams? Do you know if Mozilla intends to > implement it? I'm in favor of having IO streams :-) There's so many features that could be made better by having them. I don't think anyone from Mozilla has looked at https://streams.spec.whatwg.org/ in detail, but I could be mistaken. If I find out I'll let you know. -- https://annevankesteren.nl/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Streams API
On 10/31/14, 12:48 AM, Anne van Kesteren wrote: On Fri, Oct 31, 2014 at 12:02 AM, youenn fablet wrote: I would like to add support for the streams API, starting with readable streams and their integration with XHR and loaders. This work is expected to happen behind a flag. There's no planned integration with XMLHttpRequest. Nice to see you participate here Anne! Any opinion for or against Streams? Do you know if Mozilla intends to implement it? Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Streams API
On Fri, Oct 31, 2014 at 12:02 AM, youenn fablet wrote: > I would like to add support for the streams API, starting > with readable streams and their integration with XHR and loaders. > This work is expected to happen behind a flag. There's no planned integration with XMLHttpRequest. -- https://annevankesteren.nl/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Streams API
Hi all, I would like to add support for the streams API ([1], [2]), starting with readable streams and their integration with XHR and loaders. This work is expected to happen behind a flag. Regards, Youenn [1] https://github.com/whatwg/streams [2] http://www.w3.org/TR/streams-api/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
