Re: [webkit-dev] Why does Frame.h use mutable members instead of OwnPtr?

2010-06-11 Thread Maciej Stachowiak
On Jun 10, 2010, at 4:22 PM, Eric Seidel wrote: Example. Use of a mutable member for AnimationController: https://trac.webkit.org/browser/trunk/WebCore/page/Frame.h#L346 Causes us to pull in AnimationController.h: https://trac.webkit.org/browser/trunk/WebCore/page/Frame.h#L31 Which

Re: [webkit-dev] Why does Frame.h use mutable members instead of OwnPtr?

2010-06-11 Thread Eric Seidel
I'm all for PLT speedups (despite it running too fast on modern hardware to be useful, it's all we got). But I'm very against build-time explosion. :( I bet we don't need to inline all of these. Would be nice to know which ones. Inlines requiring additional headers (especially for Frame.h)

Re: [webkit-dev] Why does Frame.h use mutable members instead of OwnPtr?

2010-06-11 Thread Maciej Stachowiak
On Jun 11, 2010, at 6:17 PM, Eric Seidel wrote: I'm all for PLT speedups (despite it running too fast on modern hardware to be useful, it's all we got). But I'm very against build-time explosion. :( I bet we don't need to inline all of these. Would be nice to know which ones. Inlines

Re: [webkit-dev] Why does Frame.h use mutable members instead of OwnPtr?

2010-06-11 Thread Eric Seidel
Oh, certainly page speed wins. I suspected such was the original desire. I continue to doubt their all needed. The project continues to be paralyzed by a lack of a real public benchmark. :( -eric On Fri, Jun 11, 2010 at 6:23 PM, Maciej Stachowiak m...@apple.com wrote: On Jun 11, 2010, at

Re: [webkit-dev] Why does Frame.h use mutable members instead of OwnPtr?

2010-06-10 Thread Eric Seidel
Example. Use of a mutable member for AnimationController: https://trac.webkit.org/browser/trunk/WebCore/page/Frame.h#L346 Causes us to pull in AnimationController.h: https://trac.webkit.org/browser/trunk/WebCore/page/Frame.h#L31 Which pulls in additional headers of its own. Frame.h is included