Re: [webkit-dev] WebKit-EFL finally merged, pay attention to CMake build system!

2010-05-17 Thread Gustavo Sverzut Barbieri
On Sat, May 15, 2010 at 2:06 PM, Adam Barth aba...@webkit.org wrote: On Sat, May 15, 2010 at 9:14 AM, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: I'm glad to say that WebKit-EFL was finally merged as the last but definitely bit, the build system, was merged into tree today. Many,

Re: [webkit-dev] WebKit-EFL finally merged, pay attention to CMake build system!

2010-05-17 Thread Kenneth Russell
On Sat, May 15, 2010 at 9:14 AM, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: Hi all, I'm glad to say that WebKit-EFL was finally merged as the last but definitely bit, the build system, was merged into tree today. Many, many thanks to all the friends that helped with this painful

Re: [webkit-dev] HitTest'ing scrollbars

2010-05-17 Thread tonikitoo (Antonio Gomes)
Hi, just sharing a few words from hyatt on IRC: May 17 00:07:00 dhyattyeah your analysis is right May 17 00:08:34 dhyattthat RenderLayer comment is about dragging the map in google maps May 17 00:08:41 dhyattso that would be the thing to test to make sure it doesn't break

[webkit-dev] converting by constructor

2010-05-17 Thread Chris Jerdonek
Hi, I have a basic question. What has been WebKit's stance on the use of the explicit keyword (for higher-level objects in particular)? Do we prefer the looser API's that conversion by constructor affords, or do we more often discourage relying on conversion by constructor? For comparison, the

Re: [webkit-dev] webkit-patch, check-webkit-style and git now support --squash and --git-commit

2010-05-17 Thread Ojan Vafai
On Sun, May 16, 2010 at 10:38 AM, Chris Jerdonek cjerdo...@webkit.orgwrote: On Sun, May 16, 2010 at 8:26 AM, Ojan Vafai o...@chromium.org wrote: On Sat, May 15, 2010 at 2:17 PM, Chris Jerdonek cjerdo...@webkit.org wrote: In particular, --git-commit=HEAD.. should be just the uncommitted

Re: [webkit-dev] converting by constructor

2010-05-17 Thread Adam Barth
My understanding is that we almost always use the explicit keyword unless we explicitly want implicit construction. For example, AtomicString has a non-explicit constructor that takes a String on purpose (or at least controlled by NO_IMPLICIT_ATOMICSTRING). Adam On Mon, May 17, 2010 at 12:39

Re: [webkit-dev] converting by constructor

2010-05-17 Thread Darin Adler
I think the Google guideline is pretty close to what a WebKit guideline would be. The explicit keyword should almost always be used when a constructor is creating an object and not just converting type from one to another. Leaving out the explicit keyword should be thought of as equivalent to

[webkit-dev] Pixel test differences between Leopard and Snow Leopard

2010-05-17 Thread James Robinson
Leopard and Snow Leopard have subtle differences in the way they render antialiased text. This does not affect the text metrics but does cause slight pixel differences. The majority of our existing pixel test baselines appear to have been generated on Leopard, but there is a growing minority of

Re: [webkit-dev] Pixel test differences between Leopard and Snow Leopard

2010-05-17 Thread Simon Fraser
On May 17, 2010, at 3:44 PM, James Robinson wrote: Leopard and Snow Leopard have subtle differences in the way they render antialiased text. This does not affect the text metrics but does cause slight pixel differences. The majority of our existing pixel test baselines appear to have

Re: [webkit-dev] converting by constructor

2010-05-17 Thread Chris Jerdonek
On Mon, May 17, 2010 at 3:11 PM, Darin Adler da...@apple.com wrote: I think the best way for us to clarify our guideline for this would be to discuss a few individual cases where we have a non-explicit constructor. We can talk about why they are not explicit and see if we find they are just

Re: [webkit-dev] converting by constructor

2010-05-17 Thread Adam Barth
On Mon, May 17, 2010 at 5:28 PM, Chris Jerdonek cjerdo...@webkit.org wrote: On Mon, May 17, 2010 at 3:11 PM, Darin Adler da...@apple.com wrote: I think the best way for us to clarify our guideline for this would be to discuss a few individual cases where we have a non-explicit constructor. We

Re: [webkit-dev] converting by constructor

2010-05-17 Thread Maciej Stachowiak
On May 17, 2010, at 12:39 PM, Chris Jerdonek wrote: Hi, I have a basic question. What has been WebKit's stance on the use of the explicit keyword (for higher-level objects in particular)? Do we prefer the looser API's that conversion by constructor affords, or do we more often discourage