On Wed, Jul 11, 2012 at 4:53 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Jul 11, 2012 8:43 AM, John Mellor joh...@chromium.org wrote:
On Wed, Jul 11, 2012 at 4:21 PM, Ryosuke Niwa rn...@webkit.org wrote:
What's the point of adding this comment when the URL contains all the
information?
Hello Webkittens!
While implementing the Region interface (
http://dev.w3.org/csswg/css3-regions/#the-region-interface ) I've noticed that
the name Region is already taken by a class in platform/graphics. I'd like to
know what's the best approach in these kind of situations:
1. Rename the
One common thing we do is prefix DOM to DOM-level concepts. For example,
DOMWindow and DOMFileSystem. I'm not sure if we have an established
convention for CSS-level concepts.
Adam
On Thu, Jul 12, 2012 at 9:18 AM, Andrei Bucur abu...@adobe.com wrote:
Hello Webkittens!
While implementing
The spec itself consistently and deliberately calls them CSS Regions, so a
CSS prefix could be appropriate.
Thanks,
Alan
From: Adam Barth aba...@webkit.orgmailto:aba...@webkit.org
To: Andrei Bucur abu...@adobe.commailto:abu...@adobe.com
Cc:
On Jul 12, 2012, at 6:50 AM, John Mellor joh...@chromium.org wrote:
To take an arbitrary example, lets say that while iterating through a
ListHashSet something causes entries to be deleted. Intuitively it seems this
needn't invalidate the iterator, as long as the entry the iterator is
From my knowledge the CSS prefix is reserved for the CSS engine classes in
WebKit. Prefixing the Region class with CSS could prove confusing.
Regards,
Andrei.
From: Alan Stearns stea...@adobe.commailto:stea...@adobe.com
Date: Thursday, July 12, 2012 7:39 PM
To: Adam Barth
I'd vote for CSSRegion or CSSOMRegion for the class you're adding but I'll
also suggest we rename the existing Region class now that the term region
has a specific semantic in CSS. Maybe LayoutRegion or ScreenRegion?
- Ryosuke
On Jul 12, 2012 10:13 AM, Eric Seidel e...@webkit.org wrote:
I would
On Thu, Jul 12, 2012 at 1:25 PM, Ryosuke Niwa rn...@webkit.org wrote:
I'd vote for CSSRegion or CSSOMRegion for the class you're adding but I'll
also suggest we rename the existing Region class now that the term region
has a specific semantic in CSS. Maybe LayoutRegion or ScreenRegion?
On Wed, Jul 11, 2012 at 6:07 PM, Alec Flett alecfl...@chromium.org wrote:
I absolutely do not buy that the cost of keeping comments up to date and
the cost of out-of-date comments outweighs the benefits - that has NEVER
been my experience and if anything the benefits of comments grow as the
I'd prefer we keep Region for the low-level graphics primitive Region (just
like Path), and use something prefixed for the higher-level layout concept.
Simon
On Jul 12, 2012, at 10:26 AM, Dana Jansens wrote:
On Thu, Jul 12, 2012 at 1:25 PM, Ryosuke Niwa rn...@webkit.org wrote:
I'd vote for
I'd prefer we keep Region for the low-level graphics primitive Region (just
like Path), and use something prefixed for the higher-level layout concept.
Simon
On Jul 12, 2012, at 10:26 AM, Dana Jansens wrote:
On Thu, Jul 12, 2012 at 1:25 PM, Ryosuke Niwa rn...@webkit.org wrote:
I'd vote for
On Thu, Jul 12, 2012 at 10:43 AM, Stephen Chenney schen...@chromium.orgwrote:
As several people have shown, it is quite easy to come up with a formula
that shows the cost of maintaining comments is much lower than the cost of
living without.
I object to that conclusion. I've never seen any
We just discovered (via a rollout on bug 91103) that there’s a bug
with __MAC_OS_X_VERSION_MAX_ALLOWED in the version of the 10.5 SDK as
present in Xcode 3.2.6. This may be the last version of the 10.5 SDK ever
released (I haven’t checked all of the early Xcode 4 releases). Chromium
uses this SDK
Mark Rowe wrote:
It'd be complicated to do this more widely since the AvailabilityMacros.h
version of the macros are defined even when building for iOS. We'd need to
review all of the uses to ensure that they were handled correctly. Given
that I think it'd be better to just use this as a
So far in the css/ directory we tried to renamed slowly classes so that :
CSS* prefixed classes are the implementation of CSSOM
whatevername is for internal classes. For example we renamed
CSSStyleApplyProperty class to StyleBuilder because it's internal.
Hope that helps.
On Thu, Jul 12, 2012
On Thu, Jul 12, 2012 at 10:53 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jul 12, 2012 at 10:43 AM, Stephen Chenney schen...@chromium.org
wrote:
As several people have shown, it is quite easy to come up with a formula
that shows the cost of maintaining comments is much lower than the
I for one, very much appreciate your cleanup/organizational efforts!
On Thu, Jul 12, 2012 at 12:37 PM, Alexis Menard
alexis.men...@openbossa.org wrote:
So far in the css/ directory we tried to renamed slowly classes so that :
CSS* prefixed classes are the implementation of CSSOM
whatevername
On Thu, Jul 12, 2012 at 3:44 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, Jul 12, 2012 at 10:53 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jul 12, 2012 at 10:43 AM, Stephen Chenney schen...@chromium.org
wrote:
As several people have shown, it is quite easy to come up with
On Thu, Jul 12, 2012 at 1:47 PM, Stephen Chenney schen...@chromium.orgwrote:
On Thu, Jul 12, 2012 at 3:44 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, Jul 12, 2012 at 10:53 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jul 12, 2012 at 10:43 AM, Stephen Chenney
On Thu, Jul 12, 2012 at 2:03 PM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jul 12, 2012 at 1:47 PM, Stephen Chenney schen...@chromium.orgwrote:
On Thu, Jul 12, 2012 at 3:44 PM, Dirk Pranke dpra...@chromium.orgwrote:
On Thu, Jul 12, 2012 at 10:53 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Jul 12, 2012, at 1:47 PM, Stephen Chenney schen...@chromium.org wrote:
On Thu, Jul 12, 2012 at 3:44 PM, Dirk Pranke dpra...@chromium.org wrote:
On Thu, Jul 12, 2012 at 10:53 AM, Ryosuke Niwa rn...@webkit.org wrote:
On Thu, Jul 12, 2012 at 10:43 AM, Stephen Chenney
https://trac.webkit.org/wiki/Rebaseline
I've recently consolidated the various rebaseline commands and made the
tool work for non-Chromium ports.
I especially like webkit-patch rebaseline path/to/test/i/just/broke.html,
which lets you easily rebaseline the test for all ports once the bots have
On Thu, Jul 12, 2012 at 3:17 PM, Ojan Vafai o...@chromium.org wrote:
https://trac.webkit.org/wiki/Rebaseline
I've recently consolidated the various rebaseline commands and made the
tool work for non-Chromium ports.
I especially like webkit-patch rebaseline
path/to/test/i/just/broke.html,
At the top of the garden-o-matic page there is a line like Latest
revision processed by every bot: 122499 (trunk is at 122524). I think
that does what you want?
On Thu, Jul 12, 2012 at 3:56 PM, Peter Kasting pkast...@google.com wrote:
On Thu, Jul 12, 2012 at 3:17 PM, Ojan Vafai o...@chromium.org
On Thu, Jul 12, 2012 at 4:16 PM, Dirk Pranke dpra...@chromium.org wrote:
At the top of the garden-o-matic page there is a line like Latest
revision processed by every bot: 122499 (trunk is at 122524). I think
that does what you want?
Ah, I hadn't noticed that. That sounds promising!
PK
If someone feels like doing extra hacking to improve this, I'm happy to
walk you through the code. It'd be awesome if you could expand out that
section to show which revision has been run on each bot.
https://bugs.webkit.org/show_bug.cgi?id=91163
On Thu, Jul 12, 2012 at 4:18 PM, Peter Kasting
26 matches
Mail list logo
