Hi there,
I was telling people to use "unsigned" instead of "unsigned int", as I
have been told that was the preferred style before, but apparently
that is not in the style guide.
The question is, should it be?
A few greps in the code:
"unsigned" -> 18406 occurrences.
"unsigned int" -> 1721
"un
On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen
wrote:
> Hi there,
>
> I was telling people to use "unsigned" instead of "unsigned int", as I
> have been told that was the preferred style before, but apparently
> that is not in the style guide.
>
> The question is, should it be?
Yes
On Wed, Sep 12, 2012 at 11:00 PM, Maciej Stachowiak wrote:
>
> On Sep 12, 2012, at 10:36 PM, Ojan Vafai wrote:
>
> On Wed, Sep 12, 2012 at 6:40 PM, Maciej Stachowiak wrote:
>>
>> - Is this approach substantially less time and effort than adding a
>> histogram-style metric? I expect you have adde
On Thu, Sep 13, 2012 at 12:06 PM, Dirk Pranke wrote:
> On Wed, Sep 12, 2012 at 11:00 PM, Maciej Stachowiak wrote:
> >
> > On Sep 12, 2012, at 10:36 PM, Ojan Vafai wrote:
> >
> > On Wed, Sep 12, 2012 at 6:40 PM, Maciej Stachowiak
> wrote:
> >>
> >> - Is this approach substantially less time and
Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682.
- Ryosuke
On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein wrote:
>
>
> On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen <
> kenneth.christian...@gmail.com> wrote:
>
> > Hi there,
> >
> > I was telling people to use "unsign
Hi,
This discussion came out of https://bugs.webkit.org/show_bug.cgi?id=96569.
Should we allow URLs other than webkit.org/b/ to be used in
TestExpectations?
I vote for yes, and in fact, adding new URLs should be easy. What do you
guys think?
Best,
Ryosuke Niwa
Software Engineer
Google Inc.
On Thu, Sep 13, 2012 at 12:32 PM, Ryosuke Niwa wrote:
> Hi,
>
> This discussion came out of https://bugs.webkit.org/show_bug.cgi?id=96569.
>
> Should we allow URLs other than webkit.org/b/ to be used in
> TestExpectations?
>
> I vote for yes, and in fact, adding new URLs should be easy. What do yo
Landed in http://trac.webkit.org/changeset/128499 (Thanks ggaren!)
On Thu, Sep 13, 2012 at 12:29 PM, Ryosuke Niwa wrote:
> Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id=96682.
>
> - Ryosuke
>
> On Thu, Sep 13, 2012 at 8:11 AM, Dan Bernstein wrote:
>
>>
>>
>> On Sep 13, 2012, at 1:
Does the style bot pick up "unsigned int" etc?
--Oliver
On Sep 13, 2012, at 1:19 PM, Ryosuke Niwa wrote:
> Landed in http://trac.webkit.org/changeset/128499 (Thanks ggaren!)
>
> On Thu, Sep 13, 2012 at 12:29 PM, Ryosuke Niwa wrote:
> Uploaded a patch on https://bugs.webkit.org/show_bug.cgi?id
No. I think we can update webkitpy/style/checkers/cpp.py to do that.
Unfortunately, I don't understand that code base.
- Ryosuke
On Thu, Sep 13, 2012 at 1:34 PM, Oliver Hunt wrote:
> Does the style bot pick up "unsigned int" etc?
>
> --Oliver
>
> On Sep 13, 2012, at 1:19 PM, Ryosuke Niwa wrote
Filed https://bugs.webkit.org/show_bug.cgi?id=96693
On Thu, Sep 13, 2012 at 10:47 PM, Ryosuke Niwa wrote:
> No. I think we can update webkitpy/style/checkers/cpp.py to do that.
> Unfortunately, I don't understand that code base.
>
> - Ryosuke
>
>
> On Thu, Sep 13, 2012 at 1:34 PM, Oliver Hunt wr
If someone wanted this and understood python, I suspect that they could
search for "unsigned" in that cpp.py and in about 10 min have a pretty good
idea of how to add such a check. If you don't understand Python, then 30
minutes :)
dave
On Thu, Sep 13, 2012 at 2:12 PM, Kenneth Rohde Christiansen
In connection with the thread on webkitPostMessage, I took a look at
what sorts of metrics we have currently for depreciated features. We
have high quality data for two groups of APIs:
For mutation events, we measure what percent of Documents have
listeners for various kinds of mutation events:
Hi,
Submitted the patch for enabling the MIPS slave in build.webkit.org.
https://bugs.webkit.org/show_bug.cgi?id=96713
Who should I send the buildbot password for the slave?
Thanks,
Gergely
On Thu, Aug 30, 2012 at 9:52 AM, Holger Freyther wrote:
> On 08/30/2012 12:10 AM, Gergely Kis wrote:
>
On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth wrote:
> Another metric we have is for Blob.webkitSlice:
>
> Ratio of Blob.webkitSlice calls to Blob.slice: 14.87%
> Ratio of Blob.webkitSlice calls to Document creation: 0.0053%
>
> It's difficult to know how to interpret this data because we don't
> ac
On Thu, Sep 13, 2012 at 6:16 PM, Adam Barth wrote:
> On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth wrote:
> > Another metric we have is for Blob.webkitSlice:
> >
> > Ratio of Blob.webkitSlice calls to Blob.slice: 14.87%
> > Ratio of Blob.webkitSlice calls to Document creation: 0.0053%
> >
> > It's
I'd like to announce that Yuta Kitamura is now a
WebKit reviewer.
He has contributed to WebKit project for three years mainly in WebSocket
area. He is a trustworthy authority on WebSocket area. If you worked on
WebSocket issues, please involve him.
--
TAMURA Kent
Software Engineer, Google
Congrats Yuta!!
Adam
On Thu, Sep 13, 2012 at 8:56 PM, TAMURA, Kent wrote:
> I'd like to announce that Yuta Kitamura is now a
> WebKit reviewer.
>
> He has contributed to WebKit project for three years mainly in WebSocket
> area. He is a trustworthy authority on WebSocket area. If you worked on
On Sep 13, 2012, at 11:15 PM, Darin Fisher wrote:
>
>
> On Thu, Sep 13, 2012 at 6:16 PM, Adam Barth wrote:
> On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth wrote:
> > Another metric we have is for Blob.webkitSlice:
> >
> > Ratio of Blob.webkitSlice calls to Blob.slice: 14.87%
> > Ratio of Blob.
Wow, congratulation Yuta :-)
Gyuyoung
On Fri, Sep 14, 2012 at 1:01 PM, Adam Barth wrote:
> Congrats Yuta!!
>
> Adam
>
>
> On Thu, Sep 13, 2012 at 8:56 PM, TAMURA, Kent wrote:
> > I'd like to announce that Yuta Kitamura is now a
> > WebKit reviewer.
> >
> > He has contributed to WebKit project
Congrats Yuta.
-Original Message-
From: webkit-dev-boun...@lists.webkit.org
[mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of TAMURA, Kent
Sent: Friday, September 14, 2012 11:57 AM
To: WebKit Development
Subject: [webkit-dev] New WebKit reviewer: Yuta Kitamura
I'd like to announc
On Thu, Sep 13, 2012 at 9:05 PM, Maciej Stachowiak wrote:
> On Sep 13, 2012, at 11:15 PM, Darin Fisher wrote:
> On Thu, Sep 13, 2012 at 6:16 PM, Adam Barth wrote:
>> On Thu, Sep 13, 2012 at 5:13 PM, Adam Barth wrote:
>> > Another metric we have is for Blob.webkitSlice:
>> >
>> > Ratio of Blob.w
On Fri, Sep 14, 2012 at 4:13 AM, Adam Barth wrote:
> In connection with the thread on webkitPostMessage, I took a look at
> what sorts of metrics we have currently for depreciated features. We
> have high quality data for two groups of APIs:
>
> For mutation events, we measure what percent of Do
>
>
> By the way, in preparing the patch, I noticed that webkitSlice was
> used by the web inspector. Note that the data above includes the use
> by the web inspector.
>
>
The usage was in the heap profiler's load snapshot routines, so I can
imagine it not being invoked a lot. That matches the sta
On Thu, Sep 13, 2012 at 10:58 PM, Pavel Feldman wrote:
> On Fri, Sep 14, 2012 at 4:13 AM, Adam Barth wrote:
>> In connection with the thread on webkitPostMessage, I took a look at
>> what sorts of metrics we have currently for depreciated features. We
>> have high quality data for two groups of
25 matches
Mail list logo