Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Benjamin Poulain
Looks llke nobody objects. Please make sure to #ifdef everything and disable the feature on OS X and iOS. What is your plan for testing? On 5/19/15 6:31 PM, Gyuyoung Kim wrote: Hello, I would like to listen what do you think to support 'registerProtocolHandler' in WebKit2. This feature is

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Gyuyoung Kim
Hi Benjamin, Looks llke nobody objects. Please make sure to #ifdef everything and disable the feature on OS X and iOS. Ok, let me add #ifdef guard for WK2 ports which don't use this feature. There are already basic test cases for this feature. But I think this isn't enough to test all use

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Gyuyoung Kim
Hi Anders, yes, Sam didn't like to support this feature. However, as I said, I think this feature has been shipped by Firefox and Chrome browsers. Besides It seems to me that web application will need to use this feature in near future. However I know we can't support new feature without WK2

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Anne van Kesteren
On Fri, May 22, 2015 at 1:25 AM, Anders Carlsson ander...@apple.com wrote: Sam Weinig 2015-05-15 10:12:54 PDT: Support for navigator.registerProtocolHandler/unregisterProtocolHandler is not something we want to support in WebKit2 at this time as we are not confident it is a good Web API.

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Gyuyoung Kim
On the face of it, the registerProtocolHandler API seems more general than necessary, but the actual spec for it has a whitelist of specific schemes, most of which seem reasonable for this kind of purpose: https://html.spec.whatwg.org/#custom-handlers Yes, the custom-handlers specification only

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Maciej Stachowiak
On May 21, 2015, at 7:38 PM, Anne van Kesteren ann...@annevk.nl wrote: On Fri, May 22, 2015 at 1:25 AM, Anders Carlsson ander...@apple.com wrote: Sam Weinig 2015-05-15 10:12:54 PDT: Support for navigator.registerProtocolHandler/unregisterProtocolHandler is not something we want to support

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Anne van Kesteren
On Fri, May 22, 2015 at 12:26 PM, Maciej Stachowiak m...@apple.com wrote: (I am more dubious of the content handler aspect.) Agreed, especially as it requires the service to download the resource again. For that use case we need something smarter where you can pass along an object/stream of

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Anders Carlsson
On May 20, 2015, at 11:32 PM, Benjamin Poulain benja...@webkit.org wrote: Looks llke nobody objects. That’s not true. From the bug: Sam Weinig mailto:s...@webkit.org 2015-05-15 10:12:54 PDT Support for navigator.registerProtocolHandler/unregisterProtocolHandler is not something we want to