Re: [webkit-dev] Proposal: Use #pragma once instead of header guards

2016-03-09 Thread Michael Catanzaro
On Wed, 2016-03-09 at 17:27 -0800, Anders Carlsson wrote: > Hi floks, > > Currently we use  > > #ifndef Header_h > #define Header_h > > …  > > #endif > > I propose that we instead start using > > #pragma once > > which does the same thing. I think it's fine for the GTK port in general, but

Re: [webkit-dev] Proposal: Use #pragma once instead of header guards

2016-03-09 Thread Anders Carlsson
Yeah, I agree. - Anders > On Mar 9, 2016, at 6:46 PM, Michael Catanzaro wrote: > > On Wed, 2016-03-09 at 17:27 -0800, Anders Carlsson wrote: >> Hi floks, >> >> Currently we use >> >> #ifndef Header_h >> #define Header_h >> >> … >> >> #endif >> >> I propose that we

[webkit-dev] Proposal: Use #pragma once instead of header guards

2016-03-09 Thread Anders Carlsson
Hi floks, Currently we use #ifndef Header_h #define Header_h … #endif I propose that we instead start using #pragma once which does the same thing. It can be faster on some compilers, is less error prone and is one line instead of three! All compilers we use support #pragma once.

Re: [webkit-dev] Proposal: Use #pragma once instead of header guards

2016-03-09 Thread Brian Burg
Cool! It sounds like something good for new headers and drive-by cleanups, to start. To clarify, it would always go after the license block? Is the pragma name stable and understandable enough to paste everywhere? -Brian > On Mar 9, 2016, at 17:27, Anders Carlsson

Re: [webkit-dev] Proposal: Use #pragma once instead of header guards

2016-03-09 Thread Anders Carlsson
I think we should put it where we currently have the header guard. I think the pragma is easier to understand than a #ifndef/#define. - Anders > On Mar 9, 2016, at 5:33 PM, Brian Burg wrote: > > Cool! It sounds like something good for new headers and drive-by cleanups, to >

Re: [webkit-dev] Proposal: Use #pragma once instead of header guards

2016-03-09 Thread Brent Fulgham
> On Mar 9, 2016, at 5:27 PM, Anders Carlsson wrote: > > I propose that we instead start using > > #pragma once +1 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev