Re: [webkit-dev] Naming preference: SetForScope vs. TemporaryChange

2016-12-23 Thread Michael Catanzaro
On Fri, 2016-12-23 at 05:42 +, Yusuke SUZUKI wrote: > Personally I like the name "SetForScope" since the name "scope" > states that this value change is tied to C++ scope. Me too. The name is pretty clear. The first time I saw TemporaryChange I had to look at the implementation to see what it

Re: [webkit-dev] Naming preference: SetForScope vs. TemporaryChange

2016-12-23 Thread Maciej Stachowiak
A few more coats of paint for the bike shed: It's a little unusual to have a class name that's a verb phrase instead of a noun phrase. And in this case if you interpret "Set" as a noun you'll get entirely the wrong idea. Some alternatives that avoid this, but has the better clarity of "Scope"