[webkit-dev] Proposal: Do not support Windows fibers

2017-12-05 Thread Yusuke SUZUKI
Hi, Webkittens, I would like to make sure OR declare that WebKit does not support Windows fibers. While fiber related functions are used in WTF, I believe that it is because fiber local storage (FLS) can have destructors. And it is not intended to support fibers explicitly. Actually, I believe

Re: [webkit-dev] Proposal: Do not support Windows fibers

2017-12-05 Thread Michael Saboff
[Bringing John Lehner from the iTunes team into the discussion] Last I knew, the iTunes team uses fibers. IIRC, the thread they use to call into WebKit/JSC only has one fiber, other parts of the app use multiple fibers on one thread but don’t have JS objects active in those threads / fibers.

Re: [webkit-dev] WinCairo Build and EWS down

2017-12-05 Thread Olmstead, Don
EWS and Buildbots are back up for WinCairo and are successfully building. If there are any problems let me know! Apologies for the downtime. From: webkit-dev [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Olmstead, Don Sent: Friday, December 1, 2017 5:32 PM To: WebKit-Dev Development

Re: [webkit-dev] Proposal: Do not support Windows fibers

2017-12-05 Thread Michael Saboff
Here is the reply from iTunes for the WebKit-Dev list - Michael —— From an iTunes perspective, WebKit can eliminate any remaining Windows Fiber API support. iTunes still uses some cooperative threading, but implements its own mechanism on top of regular preemptive Windows threads. And we

Re: [webkit-dev] Proposal: Do not support Windows fibers

2017-12-05 Thread Ryosuke Niwa
Yeah, I don't think there is much need to support fibers. With features like web workers, supporting fibers doesn't make much sense. - R. Niwa On Tue, Dec 5, 2017 at 9:44 AM, Yusuke SUZUKI wrote: > Hi, Webkittens, > > I would like to make sure OR declare that WebKit does

Re: [webkit-dev] Proposal: Do not support Windows fibers

2017-12-05 Thread Geoffrey Garen
If our Windows clients are cool with it, I think we should remove support for fibers. I don’t think our current implementation works super well with fibers. It is best not to include half-working code in the tree. Geoff > On Dec 5, 2017, at 11:19 AM, Michael Saboff wrote:

Re: [webkit-dev] Proposal: Do not support Windows fibers

2017-12-05 Thread Olmstead, Don
We’re fine with removing it. From: webkit-dev [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Geoffrey Garen Sent: Tuesday, December 5, 2017 2:35 PM To: Michael Saboff Cc: John N. Lehner ; WebKit-Dev Subject: Re: