[webkit-dev] Planned Maintenance: svn.webkit.org downtime this weekend

2018-08-21 Thread Lucas Forschler
Hello WebKit Developers! We are planning maintenance to our webkit.org continuous integration infrastructure this weekend. The last time we had a lengthy outage, many regressions crept into the tree and it took a while to get them all resolved. Therefore, starting at 5pm on Friday August 24th (

Re: [webkit-dev] CSS Logical Properties and Values

2018-08-21 Thread Oriol Brufau
I have written a patch for adding logical shorthand properties. However, I'm not much sure about how I can implement them behind a flag. I tried hiding them behind a run-time flag. But unlike Blink, it seems I can't do this easily in CSSProperties.json. Instead, I wrapped the code added in CSSProp

Re: [webkit-dev] CSS Logical Properties and Values

2018-08-21 Thread Simon Fraser
> On Aug 21, 2018, at 5:56 PM, Oriol Brufau wrote: > > I have written a patch for adding logical shorthand properties. However, > I'm not much sure about how I can implement them behind a flag. > > I tried hiding them behind a run-time flag. But unlike Blink, it seems I > can't do this easily in

Re: [webkit-dev] CSS Logical Properties and Values

2018-08-21 Thread Oriol Brufau
But as far as I can tell, this only prevents conic gradients from being parsed. In my case I want to completely hide some CSS properties. Preventing the parser from accepting their values is not enough, because they are still exposed via `prop in element.style`. El 22/8/18 a les 03:11, Simon Fra

Re: [webkit-dev] CSS Logical Properties and Values

2018-08-21 Thread Oriol Brufau
In Blink, properties are defined in CSSProperties.json5, there you can specify a "runtime_flag" property whose value is the name of a runtime flag. This overrides the IsEnabled method with a check for the runtime flag: https://cs.chromium.org/chromium/src/third_party/blink/renderer/build/scripts/c

Re: [webkit-dev] CSS Logical Properties and Values

2018-08-21 Thread Michael Catanzaro
On Tue, Aug 21, 2018 at 7:56 PM, Oriol Brufau wrote: So I will try a compile flag instead. But there are some Web Platform Tests for the new properties, and I would like them to pass. Is there a way to tell the testbot to compile with this flag? If you absolutely must add a new compile flag...