[webkit-dev] webkit for windows x64

2012-07-31 Thread Alex Christensen
, but doesn't draw. I could use some help finding out why and possibly including my work into Webkit. Any feedback would be appreciated. Thanks. -- Alex Christensen FlexSim Software Products, Inc. *1577 North Technology Way | Building A | Suite 2300 | Orem, Utah 84097* *Voice: 801-224-6914

[webkit-dev] WebKit for Windows x64

2012-08-06 Thread Alex Christensen
I got webkit to compile for Windows x64, and it runs successfully. For anyone that wants to try or help include my changes in webkit, my repository is found at https://github.com/achristensen07/webkit64prep (I'm not a webkit committer yet) -- Alex Christensen FlexSim Software Products, Inc

[webkit-dev] WebGL on Windows

2013-08-02 Thread Alex Christensen
for anyone who does not want to ship the additional dlls. This change will also add about 30 seconds to the clean build time of these ports. Alex Christensen ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman

Re: [webkit-dev] WebGL on Windows

2013-08-05 Thread Alex Christensen
WebCore crash more unless you’re using it with unsafe WebGL content. Alex Christensen ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] WebGL on Windows

2013-08-05 Thread Alex Christensen
1. Do you have a plan to use ACCELERATED_COMPOSITING on Windows port? I had enabled WebGL on Windows port via Angle, it seems like WebGL without ACCELERATED_COMPOSITING has a poor performance. One of my early experimental builds has much higher performance than what is currently in WebKit

[webkit-dev] Wink browser

2013-10-10 Thread Alex Christensen
hope this will be seen as beneficial to the WebKit community. Alex Christensen ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] [WinCairo] : ENABLE_VIDEO = how to activate HTML5 video tag ?

2013-10-11 Thread Alex Christensen
: http://git.igalia.com/cgi-bin/gitweb.cgi?p=webkit.git;a=shortlog;h=refs/heads/win-gst If anyone wants to look at my updated code, let me know and I'll email a diff off of the webkit-dev list. Alex Christensen On Fri, Oct 11, 2013 at 2:25 PM, Brendan Long s...@brendanlong.com wrote: On 10/11

Re: [webkit-dev] WebKit, C++11, and Visual Studio 2013

2013-12-06 Thread Alex Christensen
Is there any advantage of VS2013 instead of VS2012? I've been using VS2012 for a while, and it works fine. It also has the C++11 features we want to use. Staying one version behind the latest usually prevents updates from breaking things. Alex Christensen On Fri, Dec 6, 2013 at 3:53 PM

Re: [webkit-dev] WebKit, C++11, and Visual Studio 2013

2013-12-06 Thread Alex Christensen
http://msdn.microsoft.com/en-us/library/vstudio/hh567368.aspx) that we are already using in the Mac-specific source code: 1. Variadic Templates 2. Initializer Lists 3. Explicit conversion operators 4. Deleted functions 5. range-based for loops. - Anders -- Alex Christensen

Re: [webkit-dev] WebKit, C++11, and Visual Studio 2013

2013-12-09 Thread Alex Christensen
I have working 32-bit and 64-bit WinCairo and WinCairoRequirements builds from VS2013 on my computer, and they even work on Windows XP. I'll upstream my changes as soon as I can. We're ready for the switch on our end. Alex Christensen On Sat, Dec 7, 2013 at 12:07 AM, Mital Vora mital.d.v

[webkit-dev] Enabling video with GStreamer on WinCairo

2013-12-19 Thread Alex Christensen
, but I hope everyone will see the value of this new technology. Merry Christmas! Alex Christensen ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-04 Thread Alex Christensen
in the guideline and in the reviewers' decisions. Alex Christensen On Jan 3, 2014, at 2:49 PM, Michael Saboff msab...@apple.com wrote: On Jan 3, 2014, at 11:28 AM, Geoffrey Garen gga...@apple.com wrote: However I also feel the harm here is debatable enough that people working

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-04 Thread Alex Christensen
? or will this cause problems for other developers? with a style guideline. Alex Christensen On Jan 4, 2014, at 10:51 AM, Darin Adler da...@apple.com wrote: On Jan 4, 2014, at 9:10 AM, Andreas Kling akl...@apple.com wrote: On Jan 4, 2014, at 4:14 PM, Alex Christensen alex.christen...@flexsim.com

Re: [webkit-dev] Remove the WinCE bot?

2014-01-04 Thread Alex Christensen
The wincairo bot was useful as recently as a few days ago. I might even want to add a 64-bit wincairo bot sometime. I caused some configuration issues by enabling video, but it will be fixed soon. I'm not sure about the WinCE bot, though. Alex On Jan 4, 2014, at 12:02 PM, Simon Fraser

Re: [webkit-dev] Make accelerated compositing mandatory

2014-01-28 Thread Alex Christensen
dedicate a lot of time to it right now and I'm not a compositing expert, but I'd be happy to share what I've done. Alex Christensen On Tue, Jan 28, 2014 at 2:16 PM, Maciej Stachowiak m...@apple.com wrote: ENABLE(DECELERATED_COMPOSITING) On Jan 28, 2014, at 10:15 AM, Darin Adler da...@apple.com

Re: [webkit-dev] Subject: Windows CE port in WebKit: status, future work

2014-01-31 Thread Alex Christensen
I was also wondering how the new requirements for svg and accelerated compositing affected the wince port. Alex Christensen On Jan 31, 2014, at 2:36 PM, Patrick Gansterer par...@paroga.com wrote: On 31.01.2014, at 22:10, Anders Carlsson ander...@apple.com wrote looks like the last

Re: [webkit-dev] Error while building webkit on windows

2014-03-04 Thread Alex Christensen
building from within Visual Studio or from the command line build-webkit script? Which configuration were you using (Debug, Debug_WinCairo, Release, Release_WinCairo, Production)? Were you building the WinCairo or the AppleWin port? Alex Christensen On Tue, Mar 4, 2014 at 3:26 AM, Baskar CV

Re: [webkit-dev] remove ENABLE(REQUEST_ANIMATION_FRAME)

2014-03-18 Thread Alex Christensen
Wincairo doesn't by default right now, but I've built with it enabled. It shouldn't cause me much of a problem. I'll clean up in your wake. Alex Christensen On Mar 18, 2014, at 5:57 PM, Dean Jackson d...@apple.com wrote: Thanks. In which case I plan to remove the guard in a day or so

Re: [webkit-dev] Problems building JavaScriptCore/WebKit for Windows desktop

2014-04-01 Thread Alex Christensen
everything on http://www.webkit.org/building/tools.html and build the Release_WinCairo configuration in WebKit.sln in Visual Studio 2013 to do this after running the update-webkit-wincairo-libs script. Feel free to contact me directly if you have any more questions. Alex Christensen On Tue, Apr 1, 2014

[webkit-dev] WinCairo video

2014-04-23 Thread Alex Christensen
is included since Windows Vista. I'm pretty sure I'm the only one working on or using WinCairo video, but I hope to make the switch later this week unless someone wants to maintain GStreamer on Windows. Alex Christensen ___ webkit-dev mailing list webkit-dev

Re: [webkit-dev] WinCairo video

2014-04-24 Thread Alex Christensen
and run the unmodified WinCairo port to make it easier for people who don't know much about WebKit to build and run it. I'm not saying that GStreamer is out of the question in the future, but I think there are more reasons to switch than to stay right now. Alex Christensen On Thu, Apr 24, 2014

[webkit-dev] web timing

2014-05-05 Thread Alex Christensen
could unify the code more. Alex Christensen ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] armv7 css jit

2014-06-17 Thread Alex Christensen
/iPhoneOSABIReference/Articles/ARMv6FunctionCallingConventions.html I imagine it would not be much work to get it working on other arm platforms. Alex Christensen ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] accelerated 2d canvas removal

2014-06-24 Thread Alex Christensen
ACCELERATED_2D_CANVAS seems to be dead code. Is anyone using it, or does anyone have any reason to keep it in WebKit? Alex ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] pointer lock

2014-06-26 Thread Alex Christensen
I’m looking into implementing pointer lock, and I’d like to remove the webkit prefixes now that there is a spec. Has anyone except chromium shipped with pointer lock enabled or oppose me removing the prefixes before possibly enabling it? https://bugs.webkit.org/show_bug.cgi?id=134312 Alex

Re: [webkit-dev] Trying to turn WebRTC's code on - MEDIA_STREAM flags

2014-07-22 Thread Alex Christensen
Welcome to WebKit! I have also spent a fair amount of time blindly switching unfamiliar features on and off. You can usually use the ChangeLogs, svn blame and trac.webkit.org to find some information, but I think it would be mutually beneficial if everyone took a moment to update

Re: [webkit-dev] FeatureDefines.h and .xcconfig

2014-08-06 Thread Alex Christensen
I’ve run into similar issues. I’m working on building the Apple ports with CMake. I would be in favor of switching everything to the xcconfig files, but please don’t forget to edit Source/cmake/OptionsMac.cmake. Now we have 5 files to edit, but hopefully I’ll get that down to 1 when I’m done

[webkit-dev] WebCore.exp.in

2014-08-20 Thread Alex Christensen
I’m attempting to remove WebCore.exp.in, WebKitExports.def.in, and the associated build steps of processing these files. I’d like to continue (more carefully than I did earlier) unless anyone has any objections. This would involve the use of the new WEBCORE_EXPORT macro instead of maintaining

Re: [webkit-dev] Subject: Windows CE port in WebKit: status, future work

2014-08-29 Thread Alex Christensen
I'd like to look at the patch before it lands if possible. Alex On Aug 29, 2014, at 9:07 AM, Yong Li yong.li.web...@outlook.com wrote: I can also help if needed. Yong Li From: Patrick Gansterer Sent: ‎8/‎29/‎2014 10:56 AM To: Osztrogonác Csaba Cc: WebKit Development Subject: Re:

Re: [webkit-dev] Disk cache

2014-10-31 Thread Alex Christensen
Would anything special need to be done for Windows? Alex On Oct 31, 2014, at 11:02 AM, Antti Koivisto koivi...@iki.fi wrote: Hello, I'm planning to add an experimental HTTP cache implementation to WebKit (https://bugs.webkit.org/show_bug.cgi?id=30322). The main motivations are: -

Re: [webkit-dev] Status of WinCairo buildbot?

2014-11-17 Thread Alex Christensen
I've talked to the maintainers, and they have stopped maintaining that bot. I wanted to make my own bot, but I probably won't get around to it for a few more weeks. Go ahead and remove it, but cc me so I can do the inverse once I get time to set up my bot. Alex On Nov 17, 2014, at 9:16 AM,

Re: [webkit-dev] WinCairo 64-bit Bot Failures

2015-02-11 Thread Alex Christensen
I have access to that bot. I was on vacation for several weeks, but I fixed it this morning. Let me know if there are any more complaints about that bot. Alex On Jan 29, 2015, at 4:21 AM, Osztrogonác Csaba o...@inf.u-szeged.hu wrote: Hi, the bot is persistently broken due to the SVN

[webkit-dev] WEBCORE_EXPORT

2015-02-23 Thread Alex Christensen
Last week I switched the iOS and Mac builds to use WEBCORE_EXPORT instead of WebCore.exp.in. This should make maintenance easier, but there are a few quirks everybody should be aware of: 1) Do not use WEBCORE_EXPORT before a function defined in a header. This will cause

Re: [webkit-dev] WEBCORE_EXPORT

2015-02-23 Thread Alex Christensen
Does it matter the function is defined in a header file or that it's an inline? If a function is always inlined that would also cause a problem if the linker tried to export a symbol from an object file, but most of those are defined in headers.

Re: [webkit-dev] CMake dependency bump?

2015-05-12 Thread Alex Christensen
to use, but I would oppose such a change right now if there is another way. http://llvm.org/docs/CMake.html Alex Christensen On May 12, 2015, at 4:54 PM, ryuan Choi ryuan.c...@gmail.com wrote: Hi, I think that it is fine to the EFL port. Best Regards, Ryuan Choi 2015-05-13 7:47

Re: [webkit-dev] CMake dependency bump?

2015-05-13 Thread Alex Christensen
, at 10:29 AM, Alex Christensen achristen...@apple.com wrote: I would not mind requiring 2.8.12 right now. It would be a slight hinderance to the progress of using CMake on Mac and Windows (which is admittedly slow and only contributed to by me right now) but it would not cause much

Re: [webkit-dev] CMake dependency bump?

2015-05-13 Thread Alex Christensen
project started near a year before, but unfortunately I can't see too big effort from Apple contributors, only your occasionally patches. I fully support to progress toward on this way if we can see a real intentions to switch to cmake once in the future. br, Ossy Alex Christensen írta

[webkit-dev] DirectX SDK

2015-07-02 Thread Alex Christensen
Heads up: my recent updating of ANGLE (r186169, r186172, r186201, and r186220) made it so WinCairo uses the DirectX SDK that comes with Visual Studio 2013, not the June 2010 DirectX SDK. Please let me know if this causes a problem for anyone. Alex

[webkit-dev] TestWebKitAPI and CMake

2015-08-07 Thread Alex Christensen
Right now, the Mac and Windows ports have TestWebKitAPI built as a single executable. Tools/TestWebKitAPI/CMakeLists.txt currently creates many executables to test things in groups. I want to make the Windows port build everything with CMake at the beginning of next week, but I’m not sure how

[webkit-dev] forwarding headers and CMake

2015-07-28 Thread Alex Christensen
In my work getting CMake working on Windows, I discovered a subtle difference in how forwarding headers are made. In the existing build system, a forwarding header contains the entire contents of the original header. In the current CMake build, the WEBKIT_CREATE_FORWARDING_HEADERS macro

[webkit-dev] VS2015

2015-08-01 Thread Alex Christensen
As of r187726, you should be able to build Release 32-bit and 64-bit WebKit completely with Visual Studio 2015 with CMake. Not all features are enabled in the CMake build, and we’re still waiting on a few fixes for Debug builds. In anticipation of eventually requiring VS2015, I plan to switch

Re: [webkit-dev] Windows Build Now on VS2015

2015-08-14 Thread Alex Christensen
The days of supporting VS2013 are behind us, so if it works with VS2015, go for it. Not all c++14 features are supported, though. See https://msdn.microsoft.com/en-us/library/hh567368.aspx#cpp14table I’m not sure what the oldest gcc we support is. On Aug 14, 2015, at 5:49 AM, Antti Koivisto

Re: [webkit-dev] CMake on Windows

2015-07-22 Thread Alex Christensen
Hopefully eventually, yes. On Jul 21, 2015, at 8:22 PM, Martin Robinson mrobin...@webkit.org wrote: This is great news! Do you plan to remove the WinCairo portion of the Visual Studio build? --Martin On Tue, Jul 21, 2015 at 4:29 PM, Alex Christensen achristen...@apple.com wrote: I

[webkit-dev] CMake on Windows

2015-07-21 Thread Alex Christensen
I plan to switch build-webkit --wincairo to use CMake in the near future. We are not ready to remove the Visual Studio build system yet and won’t be for a while, but a bot using CMake on Windows will help us notice if anything breaks as we make more progress. Building from

Re: [webkit-dev] Compilation issue with VS2015RC

2015-07-15 Thread Alex Christensen
I only did one 64-bit build with VS2015RC and I did not run into this crash. Please file another bug. It’s definitely worth looking into. My change to CSSPrimitiveValue.h in https://bugs.webkit.org/show_bug.cgi?id=146579 https://bugs.webkit.org/show_bug.cgi?id=146579 is a hack that should not

[webkit-dev] NetworkSession

2015-11-09 Thread Alex Christensen
I made new abstractions for loading in WebKit2: NetworkSession and NetworkDataTask. It is disabled by default right now, but if you switch USE_NETWORK_SESSION to 1, it mostly works on Mac with features like authentication challenges not implemented yet. I believe these new abstractions fit

Re: [webkit-dev] Mac CMake

2015-11-02 Thread Alex Christensen
Sat, Oct 31, 2015 at 6:32 AM, Geoffrey Garen <gga...@apple.com > <mailto:gga...@apple.com>> wrote: >  > >> On Oct 30, 2015, at 2:17 PM, Alex Christensen <achristen...@apple.com >> <mailto:achristen...@apple.com>> wrote: >> >> I got the

[webkit-dev] CMake on Windows

2015-09-28 Thread Alex Christensen
All the Windows buildbots are now using Windows. We are planning to leave all the Visual Studio projects in the tree for a couple weeks, so if you make any changes like adding another file, please try to blindly add it to the Visual Studio build. If you are wondering why the Windows EWS

Re: [webkit-dev] CMake on Windows

2015-09-28 Thread Alex Christensen
*All the Windows buildbots are now using CMake. > On Sep 28, 2015, at 1:28 PM, Alex Christensen <achristen...@apple.com> wrote: > > All the Windows buildbots are now using Windows. We are planning to leave > all the Visual Studio projects in the tree for a couple weeks, so

Re: [webkit-dev] [webkit-help] Issue with Web Inspector debugger breakpoint handling (on Wincairo)

2015-10-02 Thread Alex Christensen
> On Oct 2, 2015, at 3:12 PM, Joseph Pecoraro wrote: > Is WinCairo using WebKit1 or WebKit2? Windows is WebKit1-only. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Fetch API

2015-12-07 Thread Alex Christensen
Exciting! Refactoring the network code is something that has been needed for a while. Code can be modernized because much of it hasn’t been touched since we were using VS2005 and other old compilers. Some things can maybe be removed, some things can be refactored, and many tests need to be

Re: [webkit-dev] Wincairo support for wss:// urls with websockets

2016-01-04 Thread Alex Christensen
> > Thanks, > Isaac > > > On 29 December 2015 at 09:50, Isaac Devine <is...@devinesystems.co.nz > <mailto:is...@devinesystems.co.nz>> wrote: > How are the webkit specific changes seperated from the upstream source in > that repository? > > I

Re: [webkit-dev] DRT Test case video-canvas-drawing-output.html failed on Win Enviornment

2016-01-04 Thread Alex Christensen
Are you using the WinCairo port, which uses MediaFoundation for video, or the AppleWin port, which uses AVFoundation for video? Linux uses GStreamer for video. These are all completely different implementations of video players. It is quite possible there is a bug in one of them that needs

Re: [webkit-dev] Wincairo support for wss:// urls with websockets

2015-12-28 Thread Alex Christensen
Send a pull request to https://github.com/achristensen07/WinCairoRequirements or just send me an email with the changes you want to include. I’m right in the middle of updating icu in that repository, so you might want to go back to

Re: [webkit-dev] Wincairo support for wss:// urls with websockets

2015-12-28 Thread Alex Christensen
org/trac/ticket/11822 > <http://bugs.icu-project.org/trac/ticket/11822> > > > On 29 December 2015 at 08:37, Alex Christensen <achristen...@apple.com > <mailto:achristen...@apple.com>> wrote: > Send a pull request to https://github.com/achristensen07/WinCairoRequi

Re: [webkit-dev] NetworkSession

2015-11-18 Thread Alex Christensen
org/show_bug.cgi?id=151418> Alex > On Nov 9, 2015, at 11:32 AM, Alex Christensen <achristen...@apple.com> wrote: > > I made new abstractions for loading in WebKit2: NetworkSession and > NetworkDataTask. It is disabled by default right now, but if you switch > USE_NETWORK_SESSION t

Re: [webkit-dev] NetworkSession

2015-11-19 Thread Alex Christensen
, and ProcessModel. We will still have a max process limit, and it can be set to 1, and that’s what I’ve used to get ready for this change, too. Alex > On Nov 19, 2015, at 12:04 AM, Carlos Garcia Campos <carlo...@webkit.org> > wrote: > > El mié, 18-11-2015 a las 15:58 -0800, Alex Ch

Re: [webkit-dev] [cmake] Proposal: Move commonly used platform-dependent files in WebCore to .cmake include files.

2016-02-09 Thread Alex Christensen
Let’s go for it. Less duplication is a good thing. The only downside is the occasional “Which CMake file do I add this to?” but that should be just as straightforward as adding the file to multiple platform cmake files, if not more. > On Feb 9, 2016, at 10:44 AM, Michael Catanzaro

Re: [webkit-dev] Building Webkit on Windows

2016-02-24 Thread Alex Christensen
Those instructions are out of date. The most up-to-date instructions about building on Windows are http://trac.webkit.org/wiki/WindowsWithoutCygwin > On Feb 24, 2016, at 9:57 AM, Myles C. Maxfield wrote: > > What is the error you are seeing? > > On Feb 24, 2016, at 9:26

Re: [webkit-dev] Building Webkit on Windows

2016-02-25 Thread Alex Christensen
r does this port still require > cygwin? > > Thomas > > Am 24.02.2016 um 20:32 schrieb Alex Christensen: >> Those instructions are out of date. The most up-to-date instructions about >> building on Windows are >> <http://trac.webkit.org/wiki/WindowsWithou

Re: [webkit-dev] Building Webkit on Windows

2016-02-29 Thread Alex Christensen
there are currently only 64bit available. That doesn't > matter at the moment, but when I am ready for our next build, I would ask > again if you don't mind. > > Thanks for your help! > > Thomas > > Am 25.02.2016 um 19:17 schrieb Alex Christensen: > That also applies to

Re: [webkit-dev] Is someone going to fix Windows EWS?

2016-03-30 Thread Alex Christensen
I agree that it would be better to have one approach to copying forwarding headers, but there is a fundamental disagreement between the needs of the ports. Windows needs the entire header to be copied into the forwarding directory because some internal builds are built without the other

Re: [webkit-dev] CSS Parse error in element.

2017-02-03 Thread Alex Christensen
I would start looking at HTMLLinkElement::parseAttribute. LinkHeader.cpp contains parsers for link headers, which are related. Yoav knows more about those. Those parsers ought to be united more. > On Feb 3, 2017, at 1:17 AM, Atul Sowani wrote: > > At present I am focusing

Re: [webkit-dev] EFL port?

2017-02-14 Thread Alex Christensen
> Konstantin Tokarev maintains a Qt port at https://github.com/annulen/webkit > - sounds like you could do something like > that. We have accepted the upstreaming of many patches from this repository into WebKit. That reduces Konstantin’s maintenance burden

Re: [webkit-dev] WebCore/platform standalone library

2017-01-18 Thread Alex Christensen
Windows must also stay a static library. I can volunteer the currently-completely-experimental-anyways Mac CMake build to have PAL as a shared library. It would be nice if people had more of a reason to keep it working. > On Jan 18, 2017, at 1:23 PM, Michael Catanzaro

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-06 Thread Alex Christensen
I think “take" is a fine word to indicate that you are taking a value from a HashSet, just like “add" indicates you are adding to the set and remove indicates you are “removing" from the set. It’s true that in all these cases the caller is doing the thing, not the object, but it makes sense in

Re: [webkit-dev] WinCairo Maintainers

2016-09-26 Thread Alex Christensen
Right now https://github.com/peavo/WinCairoRequirements is the best maintained repository containing all the requirements, even if Per isn’t maintaining it any more. If you fork it and add fixes, then yours would become the best maintained

Re: [webkit-dev] WinCairo Maintainers

2016-09-26 Thread Alex Christensen
software that they built completely from source. > On Sep 26, 2016, at 11:54 AM, Konstantin Tokarev <annu...@yandex.ru> wrote: > > > > 26.09.2016, 21:46, "Alex Christensen" <achristen...@apple.com > <mailto:achristen...@apple.com>>: >> Rig

Re: [webkit-dev] [CMake] Bumping cmake_minimum_required

2016-09-22 Thread Alex Christensen
Requiring CMake 3.0 would not cause us a problem. > On Sep 21, 2016, at 5:06 AM, Michael Catanzaro wrote: > > On Wed, 2016-09-21 at 18:09 +0900, Fujii Hironori wrote: >> Ubuntu 14.04 has GCC 4.8 and build fails with a following error >> message. > > Hm that's a good

Re: [webkit-dev] [CMake] Bumping cmake_minimum_required

2016-09-23 Thread Alex Christensen
Updating to CMake 3.2 would also not cause us a problem. > On Sep 23, 2016, at 1:14 AM, Konstantin Tokarev <annu...@yandex.ru> wrote: > > > > 23.09.2016, 00:59, "Alex Christensen" <achristen...@apple.com > <mailto:achristen...@apple.com>>: >&

Re: [webkit-dev] WebKit build failed

2016-12-12 Thread Alex Christensen
> On Dec 12, 2016, at 4:30 AM, Konstantin Tokarev wrote: > > > > 12.12.2016, 12:25, "Plamen Dimitrov" : >> Hi all, I am trying to build webkit wincairo 1) I've done 2, 3, 4, 5, 6, 7, >> 8, 9,10 and 13 from this list: >>

Re: [webkit-dev] WebCore/platform standalone library

2017-01-12 Thread Alex Christensen
If PAL were a shared library in a CMake build, then it wouldn’t build successfully if there were layering violations. I think we should do something like that to enforce good design, even if the Mac Xcode projects treat it as a static library or even just a part of WebCore.

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-10 Thread Alex Christensen
>> I’d love to see examples where using auto substantially hurts readability so >> we could debate them. I once saw a RefPtr changed to auto in some generated code where it was unclear what the return type was. For at least one generated instance the return type was Something* that needed a

Re: [webkit-dev] update GCC version?

2017-01-07 Thread Alex Christensen
> On Jan 7, 2017, at 11:39 AM, Konstantin Tokarev <annu...@yandex.ru> wrote: > > > > 07.01.2017, 22:30, "Alex Christensen" <achristen...@apple.com>: >> We are looking into using more C++14 features in WebKit, which would require >> i

[webkit-dev] update GCC version?

2017-01-07 Thread Alex Christensen
We are looking into using more C++14 features in WebKit, which would require increasing the minimum supported compiler versions. For example, Yusuke’s patch in https://bugs.webkit.org/show_bug.cgi?id=165093 compiles successfully in clang and I

Re: [webkit-dev] update GCC version?

2017-01-09 Thread Alex Christensen
> On Jan 9, 2017, at 7:39 AM, Carlos Alberto Lopez Perez > wrote: > > On 09/01/17 01:09, Michael Catanzaro wrote: >> On Sun, 2017-01-08 at 18:59 +0100, z...@falconsigh.net wrote: >>> For the record, GCC 5 has complete C++14 support. The current >>> requirement is 4.9, so the

Re: [webkit-dev] Proposal: upstream the WPE port

2017-04-21 Thread Alex Christensen
This is exciting news, Zan! I’m happy to see innovative new uses of WebKit. What kind of groups hope to use this new port? What kind of groups hope to maintain this new port? Will it be beneficial to the WebKit community to have their cooperative work? I see having more groups motivated to

Re: [webkit-dev] Compile time increase over time

2017-04-24 Thread Alex Christensen
Thanks for the data, Carlos! This is a growing problem that is hurting productivity. We’ve discussed it a bit and haven’t done enough about it. Here are some of the ideas I’ve heard: 1) Reduce #includes by doing more forward declaring and less inlining. We would probably need link time

Re: [webkit-dev] Looking to remove cygwin dependency for javascript tests for Windows ports

2017-08-02 Thread Alex Christensen
I think eventually running all tests on Windows without Cygwin would be a step in the right direction. > On Aug 2, 2017, at 9:53 AM, Szabo, Stephan (San Francisco) > wrote: > > Hi, > > As part of Sony's work on getting the jsconly build for Windows, we're also >

Re: [webkit-dev] Building WebKit for an iOS device

2017-07-12 Thread Alex Christensen
WebKit can be built and run on the iOS simulator by anyone with the public iOS SDK. I use https://webkit.org/blog/3457/building-webkit-for-ios-simulator/ when I forget how to do this. I guess WebKit can be built for device, but

Re: [webkit-dev] !!Tests for equality comparison

2017-04-28 Thread Alex Christensen
I think we should definitely keep !pointerValue instead of pointerValue == nullptr for brevity and it makes sense to think “there’s not a pointer” when there is a pointer to null. I appreciate the reminder that pointers and integers are the same thing at the assembly level when I write

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-09 Thread Alex Christensen
I like switch statements without defaults when possible because if someone adds another enum value, it causes compiler warnings/errors and forces us to update all necessary code. ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] update GCC version?

2017-06-23 Thread Alex Christensen
I’ve been using MSVC 2017 on my WinCairo bot for a while now and it builds fine. It would take a bit to update our internal Windows infrastructure, but we should do that soon. ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

2017-06-13 Thread Alex Christensen
std::function, c++ lambda, and objc blocks are all interchangeable. WTF::Functions cannot be used as objc blocks because the latter must be copyable. Until that changes or we stop using objc, we cannot completely eliminate std::function from WebKit.

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

2017-06-13 Thread Alex Christensen
13, 2017, at 12:31 PM, Chris Dumez <cdu...@apple.com> wrote: > > We already have BlockPtr for passing a Function as a lambda block. > > Chris Dumez > > On Jun 13, 2017, at 12:29 PM, Alex Christensen <achristen...@apple.com > <mailto:achristen...@apple.com>&

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-30 Thread Alex Christensen
> On Aug 29, 2017, at 5:54 PM, Sam Weinig wrote: > In a completely other direction, what does this mean for use of Xcode? Can we > still build from Xcode? Debug? CMake can generate Xcode files, so you can still develop and debug in Xcode. > On Aug 29, 2017, at 5:37 PM, Carlos

Re: [webkit-dev] Running Safari on the simulator

2017-09-27 Thread Alex Christensen
When I want to use the public iOS SDK for WebKit on iOS, I refer to Dan’s blog post at https://webkit.org/blog/3457/building-webkit-for-ios-simulator/ We have bots using this configuration and they’re working successfully at

Re: [webkit-dev] 'CSSPropertyNames.h': No such file or directory

2017-10-02 Thread Alex Christensen
That is supposed to be generated. Maybe something’s failing to generate that, or maybe the command isn’t getting called somehow. See https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/CMakeLists.txt#L3819 > On Oct 2, 2017, at 7:54 AM, Patrick Wright wrote: > >

Re: [webkit-dev] Server Timing API

2017-08-17 Thread Alex Christensen
I think there’s interest. The tricky part would be getting access to the HTTP trailers with NSURLSession, libsoup, and if there’s interest libcurl. I can help out with the NSURLSession implementation if someone else gets it working with libsoup. > On Aug 16, 2017, at 7:51 AM, Vazac, Charles

Re: [webkit-dev] unified sources build + forwarding headers that are copies

2017-11-14 Thread Alex Christensen
Our CMakeLists.txt have many instances of checks like “if (WIN32)” that assume that if you are running CMake on Windows then you are building for Windows. If you can make these checks work for you without breaking the existing Windows builds, then we would welcome such improvements.

Re: [webkit-dev] Move to NavigationClient

2017-10-20 Thread Alex Christensen
on the NSURLAuthenticationChallenge.sender model, and modern WebKit is moving towards a completion handler model. > On Oct 20, 2017, at 1:45 PM, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > On Fri, Oct 20, 2017 at 3:30 PM, Alex Christensen <achristen...@apple.com> > wrote: >> Right now we

Re: [webkit-dev] Move to NavigationClient

2017-10-23 Thread Alex Christensen
I’m not sure I understand your concern. Deciding policies is definitely part of navigation. Why would it be important to have the clients be separate objects? > On Oct 22, 2017, at 9:22 AM, Alfonso Guerra <hupernike...@gmail.com> wrote: > > > > On Oct 20, 2017 4:30

[webkit-dev] libsoup and libcurl networking implementations

2019-01-18 Thread Alex Christensen
TL; DR could someone get my patch from https://bugs.webkit.org/show_bug.cgi?id=193580 working on Linux and Windows? As part of the quest to reduce process-global state especially in the NetworkProcess, I’m moving NetworkStorageSession ownership from a static map to a member variable of the

Re: [webkit-dev] AppleWin/WinCairo Resources

2019-01-15 Thread Alex Christensen
I don’t think there’s a fundamental reason why the resources and code can’t be moved. Just make sure everything still works > On Jan 7, 2019, at 10:45 AM, stephan.sz...@sony.com wrote: > > Hi, > > While working with (non-legacy) WebKit for WinCairo, we realized that we need > to support

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-17 Thread Alex Christensen
onal will be left a bad state. > > I completely disagree with your assessment that this calls for the use of > std::exchange. > > > On Mon, Dec 17, 2018 at 3:55 PM Alex Christensen <mailto:achristen...@apple.com>> wrote: > Let me give a concrete example on why, even

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-17 Thread Alex Christensen
oid std::optional and use an > optional class with well-defined behavior instead. > > Because I do not ❤️ security updates, I do ❤️ defined behavior, and so I ❤️ > this proposal. > > Geoff > >> On Dec 17, 2018, at 12:50 PM, Alex Christensen > <mail

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-17 Thread Alex Christensen
behavior which works for us in most places. > On Dec 17, 2018, at 11:24 AM, Chris Dumez wrote: > > > >> On Dec 17, 2018, at 11:10 AM, Chris Dumez > <mailto:cdu...@apple.com>> wrote: >> >> >> >>> On Dec 17, 2018, at 10:27 AM, A

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-17 Thread Alex Christensen
On Dec 14, 2018, at 1:37 PM, Chris Dumez >>> > wrote: >>> As far as I know, our convention in WebKit so far for our types has been that types getting moved-out are left in a valid “empty” state. This is not necessarily true. When we move out of an

Re: [webkit-dev] Reducing globals

2018-12-20 Thread Alex Christensen
It’s been three weeks. Is anyone maintaining the soup or curl loading code? > On Dec 3, 2018, at 1:03 PM, Alex Christensen wrote: > > > >> On Dec 3, 2018, at 12:55 PM, basuke.suz...@sony.com wrote: >> >> Alex, >> >> Got it. Curl port will catch up

[webkit-dev] Reducing globals

2018-11-29 Thread Alex Christensen
I am embarking on a journey to reduce the number of global variables and singletons we use instead member variables on the proper objects. Feel free to join! Specifically, I’m looking into reducing the number of members in the NetworkProcessCreationParameters structure. Many of them need to

  1   2   >