[webkit-dev] Add support for CSS3 text-decoration* properties

2012-07-31 Thread Bruno Abinader
Hi all :) As suggested by Ojan, I am writing a mail to you about my intention to implement all updated and missing text-decoration* properties from CSS3 spec (currently in development), named below: -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000 ) CSS3 dev spec: http://de

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-01 Thread Bruno Abinader
gt; text editing & execCommand). In particular, we probably need to update > ApplyStyleCommand/EditingStyle to handle -webkit-text-decoration*. > > On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader > wrote: >> >> Hi all :) >> >> As suggested by Ojan, I am writing a

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-01 Thread Bruno Abinader
Hi Elliott, On Wed, Aug 1, 2012 at 7:36 PM, Elliott Sprehn wrote: > It seems weird to have a prefixed version of text-decoration instead of just > making text-decoration allow the new prefixed keywords. > > What's the reason for having a whole new prefixed property? The rationale is that the CSS

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-02 Thread Bruno Abinader
9:53 PM, Maciej Stachowiak wrote: > > On Aug 1, 2012, at 4:36 PM, Elliott Sprehn wrote: > > > On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader > wrote: >> >> Hi all :) >> >> As suggested by Ojan, I am writing a mail to you about my intention to >&

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-02 Thread Bruno Abinader
Hi again, On Thu, Aug 2, 2012 at 6:10 PM, Ryosuke Niwa wrote: > Does the spec require to return new values in the computed style of > text-decoration property without authors specifying new text-decoration > properties and values? > > If not, then using text-decoration property is probably better

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-08 Thread Bruno Abinader
cgi?id=92000 I kindly ask for review and comments :) Best regards, On Fri, Aug 3, 2012 at 2:01 AM, Ryosuke Niwa wrote: > On Thu, Aug 2, 2012 at 9:43 PM, Bruno Abinader > wrote: >> >> On Thu, Aug 2, 2012 at 6:10 PM, Ryosuke Niwa wrote: >> > Does the spec require to

[webkit-dev] New runtime setting: css3TextDecoration

2012-08-14 Thread Bruno Abinader
A series of CSS3 text decoration properties implementations are currently on the works. These adds new properties which specifications are not finished yet, thus subject to changes. In order to avoid early web exposure, a new setting (aka. runtime flag) is going to be added: css3TextDecoration. As

Re: [webkit-dev] New runtime setting: css3TextDecoration

2012-08-14 Thread Bruno Abinader
On Tue, Aug 14, 2012 at 3:06 PM, Ryosuke Niwa wrote: > On Tue, Aug 14, 2012 at 11:56 AM, Julien Chaffraix >> > * If your feature is protected by an ENABLE flag, vendors that want to >> > ship release software can turn it off. >> >> That's true, except that the original thread didn't mention any fo

Re: [webkit-dev] New runtime setting: css3TextDecoration

2012-08-14 Thread Bruno Abinader
On Tue, Aug 14, 2012 at 3:47 PM, Ryosuke Niwa wrote: > On Tue, Aug 14, 2012 at 12:42 PM, Bruno Abinader > wrote: >> >> I do have a working patch with compile flag implementation [1] . The >> "-webkit-text-decoration-line" code works most of the time as an ali

Re: [webkit-dev] New runtime setting: css3TextDecoration

2012-08-15 Thread Bruno Abinader
On Wed, Aug 15, 2012 at 12:55 PM, Darin Adler wrote: > On Aug 14, 2012, at 5:41 PM, Elliott Sprehn wrote: > >> The point of the vendor prefix is to assert the instability of the feature. > > The WebKit project uses vendor prefixes to avoid compatibility conflict > between a feature and a later i

[webkit-dev] Proposal to enable compile flags only for EWS run

2012-08-16 Thread Bruno Abinader
Hi WebKit :) As previously discussed, we decided that compile flag only was the best option for CSS3 Text Decoration feature set (landed in http://trac.webkit.org/changeset/125716 ). I believe this was a general decision and got promptly implemented as such (however I still maintain a runtime flag

Re: [webkit-dev] Proposal to enable compile flags only for EWS run

2012-08-16 Thread Bruno Abinader
On Thu, Aug 16, 2012 at 1:28 PM, Adam Barth wrote: > In that case, he might want to start with one port, get that working > well, and then expand to the other ports. > > Adam That's exactly what I am doing :) As I'm mostly familiar with Qt, it is the chosen platform were I am basing layout test r

[webkit-dev] Proposal for coding guidelines: Do not use fall-through switch cases inside #ifdef's

2012-08-17 Thread Bruno Abinader
I found a very interesting issue on some platform builds that I would like to share. See the example below: ... case CSSPropertyTextDecoration: #if ENABLE(CSS3_TEXT_DECORATION) case CSSPropertyWebkitTextDecorationLine: #endif // CSS3_TEXT_DECORATION return renderTextDecorationFlags

Re: [webkit-dev] Proposal for coding guidelines: Do not use fall-through switch cases inside #ifdef's

2012-08-17 Thread Bruno Abinader
On Fri, Aug 17, 2012 at 2:24 PM, Joe Mason wrote: > What do you mean by "precompiler"? The preprocessor? Or is this a > precompiled headers thing? Indeed, s/precompiler/preprocessor :) > > Are you sure there wasn't a typo in the "case > CSSPropertyWebkitTextDecorationLine:" line which caused

Re: [webkit-dev] Proposal for coding guidelines: Do not use fall-through switch cases inside #ifdef's

2012-08-21 Thread Bruno Abinader
On Sat, Aug 18, 2012 at 10:20 PM, Tim Horton wrote: > Without looking at the code, I vaguely think that > CSSPropertyWebkitTextDecorationLine comes from a generated file that might > not rebuild when it's supposed to. You should try a clean build and see -- > there've been a few problems with t

Re: [webkit-dev] New WebKit Reviewer: Caio Marcelo de Oliveira Filho

2012-10-08 Thread Bruno Abinader
Congratulations Caio! :D On Mon, Oct 8, 2012 at 5:20 PM, wrote: > I am pleased to announce that Caio (@cmarcelo) is now a WebKit reviewer. > Caio has been working in many areas in the past years, starting with focus > on the Qt port with improvements to the Qt/JS bridge, font test results and >

[webkit-dev] About text decoration wavy style implementation on Skia platform

2012-11-05 Thread Bruno Abinader
Hi all, I am implementing the CSS3 text decoration style "wavy" for Skia platform [3], and I would like to know a few things (please let me know if this is not the right mailing list to ask this): - There is already a "spelling line" style implementation which mimics "wavy" style behavior, only w

Re: [webkit-dev] About text decoration wavy style implementation on Skia platform

2012-11-05 Thread Bruno Abinader
2012/11/5 Nico Weber > The spelling underline on OS X is not a wavy line. If you end up > changing the skia code, please make sure the chromium/mac spelling > underline doesn't become a wavy line. > > Nico > Interesting point. Said this, I'd say it is so far a matter of porting the drawErrorUnde

[webkit-dev] Testing feature suggestion: Custom measurable data @ Performance Tests

2013-02-15 Thread Bruno Abinader
Hi all, I'd like to suggest us to provide ways to aggregate custom measurable data to Performance Test results (i.e. as seen on perf-o-matic tool). As example of a custom measurable data, I'd suggest counting the amount of OpenGL context-summarized calls per frame. This kind of data is useful when