[webkit-dev] Mixed content checking

2014-07-23 Thread Michael Catanzaro
connections when allow-running-of-insecure-content is false. Thanks, Michael Catanzaro ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Mixed content checking

2014-07-24 Thread Michael Catanzaro
Hi Alexey, On Wed, 2014-07-23 at 22:59 -0700, Alexey Proskuryakov wrote: Thank you for the heads up! Can you elaborate on why this is desirable? A non-https frame always has a different origin, so it can't script the main frame. In other words, how is active content defined here? One big

Re: [webkit-dev] Mixed content checking

2014-08-05 Thread Michael Catanzaro
On Tue, 2014-08-05 at 11:03 +0200, Mike West wrote: Apologies for digging up an old thread; I didn't see it until now. On Thu, Jul 24, 2014 at 7:59 AM, Alexey Proskuryakov a...@webkit.org wrote: In other words, how is active content defined here? Note that the WebAppSec WG is working on

Re: [webkit-dev] Pattern for singleton classes instance getters

2015-01-28 Thread Michael Catanzaro
On Wed, Jan 28, 2015 at 8:11 PM, Maciej Stachowiak m...@apple.com wrote: Yet another possibility is finding a better name than ‘shared’ for the singleton pattern function, but I don’t have any better ideas. Class::getSingleton() is more explicit but the extra verbosity doesn’t seem helpful to

Re: [webkit-dev] webkit browser always minimzed on CentOS 7.1

2015-05-04 Thread Michael Catanzaro
On Mon, 2015-05-04 at 07:54 -0400, Jerry Geis wrote: So I looked closer at my functions... void maximize(void) { gtk_window_maximize(GTK_WINDOW(window)); gtk_window_fullscreen(GTK_WINDOW(window)); gtk_window_set_decorated(GTK_WINDOW(window), FALSE); } Are you sure this problem

[webkit-dev] CMake dependency bump?

2015-05-12 Thread Michael Catanzaro
Hi, For bug #144747 it would be helpful to require CMake 2.8.12, so that I can use the SYSTEM argument to target_include_directories. Would this be a problem for anyone (in particular, the EFL port)? It was released October 2013 and it's present in Ubuntu 14.04. Thanks, Michael

Re: [webkit-dev] *.webkit.org network issues

2015-05-18 Thread Michael Catanzaro
On 05/18/2015 03:30 PM, Osztrogonác Csaba wrote: Unfortunately I still don't get any bugzilla e-mail, but I got all webkit-dev mails. (However I am subscribed to webkit-dev with this mail address, but set the webkit.org one in bugzilla - which is forwarded to this one.) Does everything work fine

Re: [webkit-dev] *.webkit.org network issues

2015-05-18 Thread Michael Catanzaro
On 05/18/2015 03:37 PM, Michael Catanzaro wrote: I haven't noticed any network issues, but I've had no mail from Bugzilla since Saturday, which seems highly improbable. I just got all the (backdated) bugmail within the past hour or two, so I guess that problem's been resolved

Re: [webkit-dev] CMake dependency bump?

2015-05-12 Thread Michael Catanzaro
On Tue, 2015-05-12 at 18:26 -0700, Alex Christensen wrote: It would be quite helpful to my CMake on Mac effort (which isn’t complete yet) and the long-term CMaking of WebKit, JavaScriptCore, and in particular JSC’s FTL to keep the CMake requirements the same as LLVM, which are 2.8.8 right

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-06-07 Thread Michael Catanzaro
On Sun, 2015-06-07 at 17:39 -0700, Darin Adler wrote: As one next step in the discussion, is there anyone that wants to present a use case for a protocol other than mailto? irc:// would be useful for those who don't like desktop clients. ___

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-06-02 Thread Michael Catanzaro
On Wed, 2015-05-20 at 10:31 +0900, Gyuyoung Kim wrote: I would like to listen what do you think to support 'registerProtocolHandler' in WebKit2. This feature is to execute web content through registered custom protocol. Hi, I think this would be useful for GNOME. One of our goals is for

Re: [webkit-dev] TestWebKitAPI and CMake

2015-08-08 Thread Michael Catanzaro
On Fri, 2015-08-07 at 16:59 -0700, Alex Christensen wrote: I consider each option to have about equal merit, but I think I need input from the GTK and EFL maintainers before proceeding. I don't have a strong opinion, so long as if you go with (1) it remainspossible to run tests individually.

Re: [webkit-dev] PSA: you should use WTF::Lock and WTF::Condition instead of WTF::SpinLock, WTF::Mutex, WTF::ThreadCondition, std::mutex, std::condition_variable, or std::condition_variable_any

2015-08-21 Thread Michael Catanzaro
On Wed, 2015-08-19 at 13:08 -0700, Filip Pizlo wrote: TL;DR. Don’t use WTF::SpinLock, WTF::Mutex, std::mutex, WTF::ThreadCondition, std::condition_variable, or std::condition_variable_any. They waste CPU time and they waste memory. Use WTF::Lock and WTF::Condition instead. Hi, I recommend

Re: [webkit-dev] Bugzilla default assignees

2015-10-09 Thread Michael Catanzaro
On Fri, 2015-10-09 at 14:04 -0700, Lucas Forschler wrote: > Changes to the component WebKit Gtk have been saved: > Default CC list updated to bugs-nore...@webkitgtk.org Thanks Lucas! ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Bugzilla default assignees

2015-10-09 Thread Michael Catanzaro
On Mon, 2015-09-28 at 15:41 -0700, Lucas Forschler wrote: > I can add a default CC for the WebKit Gtk component. However, I’m not > sure if using a fake email would cause any negative side effects. > (possibly an email bounce message on the mail server every time a bug > was created?) > > Lucas

Re: [webkit-dev] Bugzilla default assignees

2015-10-09 Thread Michael Catanzaro
On Fri, 2015-10-09 at 09:15 -0700, Lucas Forschler wrote: > Hi Michael, > > Attempting to add it resulted in an error. I believe this may have to > be a valid/registered email address inside bugzilla. > Here is the error I received: > > Bugzilla was unable to make any match at all for one or

Re: [webkit-dev] Bugzilla default assignees

2015-10-09 Thread Michael Catanzaro
On Fri, 2015-10-09 at 09:15 -0700, Lucas Forschler wrote: > Default CC List: > bugs-nore...@webkitgtk.org did not match anything > > Can you create a bugzilla user with that email, and I’ll try again? > Thanks, > Lucas Done, could you try again please? We also experimented a bit with it

[webkit-dev] Bugzilla default assignees

2015-09-12 Thread Michael Catanzaro
Hi, In WebKit Bugzilla the default assignee for all bugs is Nobody. This is problematic because it makes it really hard to notice when new bugs are filed against a particular component. For example, I want to be CCed on all new bugs in the WebKit Gtk component. If there was a fake default

Re: [webkit-dev] Bugzilla default assignees

2015-09-14 Thread Michael Catanzaro
On Mon, 2015-09-14 at 09:39 -0700, Alexey Proskuryakov wrote: > Yet another approach used by the Accessibility component is to have a > technical account auto-CC'ed, and then anyone interested can follow > this account. This seems like the most reliable solution to me. Yeah, I think that would be

Re: [webkit-dev] Bugzilla default assignees

2015-09-27 Thread Michael Catanzaro
On Mon, 2015-09-14 at 09:39 -0700, Alexey Proskuryakov wrote: > Yet another approach used by the Accessibility component is to have a > technical account auto-CC'ed, and then anyone interested can follow > this account. This seems like the most reliable solution to me. If someone with admin

Re: [webkit-dev] CMake on Windows

2015-09-28 Thread Michael Catanzaro
On Mon, 2015-09-28 at 13:28 -0700, Alex Christensen wrote: > All the Windows buildbots are now using Windows. We are planning to > leave all the Visual Studio projects in the tree for a couple weeks, Thanks Alex! It sounds like you're planning to remove the Visual Studio projects in a couple

Re: [webkit-dev] Bugzilla default assignees

2015-09-28 Thread Michael Catanzaro
On Mon, 2015-09-28 at 14:32 -0700, Darin Adler wrote: > Yes, I’m sure someone can help. Do you have the accounts for each > component? Then we can add these to the auto-CC list. I was thinking it might be possible to just add some fake email addresses to the auto-CC list, like

Re: [webkit-dev] Clipboard API and events

2016-01-05 Thread Michael Catanzaro
On Tue, 2016-01-05 at 16:48 +0200, Claudio Saavedra wrote: > Hi, > > It seems to me that this API is missing from WK. Is there a reason > for > this other than "nobody has stepped up yet"? > > Claudio What is the security model regarding the clipboard API? I'm not enthusiastic about web pages

Re: [webkit-dev] Thought about Nix JavaScriptCore port

2015-12-31 Thread Michael Catanzaro
On Thu, 2015-12-31 at 19:25 +0300, Konstantin Tokarev wrote: > Hi Yusuke, > > What is the status of this proposal? > AFAICS there were no serious objections, quite the opposite, many > people support your proposal (me too). However, no patches were > landed yet. I only wonder why it is called

[webkit-dev] CC on reviewed bugs

2016-01-07 Thread Michael Catanzaro
Hi, I notice that when my only comment on a bug is the comment added using the WebKit review feature, I do not get CCed on the bug and so do not notice follow-up responses to my review. It would be awesome if auto-CC could be implemented. I always want to be CCed on bugs with patches I have

Re: [webkit-dev] CC on reviewed bugs

2016-01-07 Thread Michael Catanzaro
On Thu, 2016-01-07 at 13:09 -0800, Brian Burg wrote: > The only reason that normal commenting will CC you is that the [X] > Add me to CC list is checked by default. > I agree it would be reasonable to duplicate that behavior when > commenting via the review tool. > > To do this, you’d have to

Re: [webkit-dev] REQUEST_ANIMATION_FRAME on all ports?

2016-06-08 Thread Michael Catanzaro
On Wed, 2016-06-08 at 13:59 -0700, Dean Jackson wrote: > Do the EFL and GTK ports always enable this feature? Yes ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Are there any plans to upgrade SVN server on svn.webkit.org?

2016-06-20 Thread Michael Catanzaro
On Mon, 2016-06-20 at 13:29 +0900, Yusuke SUZUKI wrote: > Great work, thanks. > > I've just noticed that the ToT git revision in git:// > git.webkit.org/WebKit.git is r202198 while ToT SVN revision is > r202223. Indeed, this is broken. A workaround is to run 'git svn fetch' instead of 'git

Re: [webkit-dev] [cmake] Proposal: Move commonly used platform-dependent files in WebCore to .cmake include files.

2016-02-09 Thread Michael Catanzaro
I'm curious what Martin and Alex think about this. It seems fine to me; the downside is there are more CMake files to maintain, the upside is the big ones should be slightly smaller, and we can reduce duplication between PlatformEFL.cmake and PlatformGTK.cmake. Michael

[webkit-dev] Web inspector images

2016-02-06 Thread Michael Catanzaro
Hi, I'd like to address the problem with the license for the web inspector images. The background on this is that a WebKitGTK+ release was rejected by the legal department of one of our distributors after it discovered the file Source/WebInspectorUI/APPLE_IMAGES_LICENSE.rtf, which covers the

Re: [webkit-dev] Some text about the B3 compiler

2016-01-29 Thread Michael Catanzaro
On Fri, 2016-01-29 at 13:44 +0900, Yusuke SUZUKI wrote: > Awesome, awesome work! > Thanks Fil and all the JSC B3 developers! > > After this https://bugs.webkit.org/show_bug.cgi?id=153422 is landed, > jsc-layout-tests.yaml/js/script-tests/array-enumerators- > functions.js.layout-ftl-eager-no-cjit

Re: [webkit-dev] Thought about Nix JavaScriptCore port

2016-01-31 Thread Michael Catanzaro
Hi, On Sun, 2016-01-31 at 15:22 -0800, Eric Wing wrote: > - libICU is a difficult dependency because it is big and it is not > guaranteed to be on all systems. (Some context, I’m interested in > deploying binaries, e.g. SteamOS, Android, so I can’t make users > install it via package management).

Re: [webkit-dev] Some text about the B3 compiler

2016-01-30 Thread Michael Catanzaro
On Sat, 2016-01-30 at 14:13 -0800, Filip Pizło wrote: > That's so awesome!  I can't wait to see it enabled on Linux! > > The gcc-clang differences suggest that we will need to be extra > careful now. I'd like to see more Linux testing of JSC.  > > -Filip Hi, We have two bots that run the JSC

Re: [webkit-dev] Some text about the B3 compiler

2016-01-30 Thread Michael Catanzaro
On Sun, 2016-01-31 at 06:00 +0900, Yusuke SUZUKI wrote: > Now, https://bugs.webkit.org/show_bug.cgi?id=153647 and > https://bugs.webkit.org/show_bug.cgi?id=153711 are landed. > > So, now, in GTK Linux x64 port, all the JSC tests pass! I think it's > time > to enable B3 in Linux x64 :D > >

Re: [webkit-dev] Some text about the B3 compiler

2016-01-30 Thread Michael Catanzaro
On Sat, 2016-01-30 at 16:06 -0800, Filip Pizło wrote: > Do we have Linux bots that run Octane, Speedometer, JetStream and > Kraken in browser? > > We find that this catches a lot of bugs that none of the other tests > catch.  > > -Filip This is the command that the bots run: /usr/bin/env ruby

Re: [webkit-dev] Some text about the B3 compiler

2016-01-30 Thread Michael Catanzaro
On Sat, 2016-01-30 at 16:06 -0800, Filip Pizło wrote: > Do we have Linux bots that run Octane, Speedometer, JetStream and > Kraken in browser? > > We find that this catches a lot of bugs that none of the other tests > catch.  > > -Filip I would assume it just executes 'run-jsc-tests'. I didn't

[webkit-dev] Unprefixing hyphens property?

2016-01-25 Thread Michael Catanzaro
Hi, Mozilla has unprefixed the CSS hyphens property as of Firefox 43. Is there any interest in unprefixing it for WebKit? Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Fonts for WebKit tests on OS X?

2016-03-11 Thread Michael Catanzaro
On Fri, 2016-03-11 at 13:12 -0800, Myles C. Maxfield wrote: > 2. Petition for the fonts to be preinstalled on all future releases > of OS X, and mark the tests as expected to fail on all current > versions of OS X. Fred, if these fonts are not preinstalled, is MathML broken for users in practice?

Re: [webkit-dev] Proposal: Use #pragma once instead of header guards

2016-03-09 Thread Michael Catanzaro
On Wed, 2016-03-09 at 17:27 -0800, Anders Carlsson wrote: > Hi floks, > > Currently we use  > > #ifndef Header_h > #define Header_h > > …  > > #endif > > I propose that we instead start using > > #pragma once > > which does the same thing. I think it's fine for the GTK port in general, but

Re: [webkit-dev] Fonts for WebKit tests on OS X?

2016-03-12 Thread Michael Catanzaro
On Sat, 2016-03-12 at 10:27 +0100, Frédéric WANG wrote: > So it's relatively easy for users to install the fonts. > Ideally, the Latin Modern package should be a dependency of > WebKitGTK+, > which I think I (or Martin Robinson) already asked in the past to > some > distro maintainers when we

Re: [webkit-dev] Fonts for WebKit tests on OS X?

2016-03-12 Thread Michael Catanzaro
On Sat, 2016-03-12 at 17:50 +0100, Frédéric WANG wrote: > This depends on what distro / maintainer prefers. In Debian-base > distro > the fontconfig changes are automatically done for Latin Modern Math, > but > one Arch Linux user told me that their philosophy is rather to always > do > the

Re: [webkit-dev] question about WSA-2016-0002

2016-03-26 Thread Michael Catanzaro
On Sat, 2016-03-26 at 15:53 -0600, Brian Martin wrote: > http://webkitgtk.org/security/WSA-2016-0002.html > > Of the six issues, five say to upgrade to 10.2.5 to mitigate, while > the > sixth (CVE-2016-1726) says upgrade to 10.2.8. Can you confirm that is > the case rather than a typo? > > Thank

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-04 Thread Michael Catanzaro
On Thu, 2016-03-03 at 11:38 -0800, Geoffrey Garen wrote: > I volunteer for any future needs in the physical restraint department > -- but in this case, I think (3) sounds like a good idea. Allowing Darin to perform (3) sounds good to me, what could possibly go wrong? Some folks will have to

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-04 Thread Michael Catanzaro
On Fri, 2016-03-04 at 17:54 +0300, Konstantin Tokarev wrote: > clang-modernize can do that automatically, I have WebCore patch ready > for upload. clang. :) Let's do this? ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-03 Thread Michael Catanzaro
On Thu, 2016-03-03 at 09:54 -0800, Ryosuke Niwa wrote: > I think "virtual" + "override" is more of a historical artifact than > the preferred style because we used to have OVERRIDE macro before all > compilers supported C++11.  I think we should just use only > "override" > going forward. > - R.

Re: [webkit-dev] Regarding CVE-2014-1303

2016-03-07 Thread Michael Catanzaro
On Mon, 2016-03-07 at 08:45 -0800, Darin Adler wrote: > If you have a specific legitimate reason that you need to know more > information about this particular bug, then you’ll need to state the > reason, and given what it says on that webpage, you should send the > inquiry to secur...@webkit.org

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-04 Thread Michael Catanzaro
On Fri, 2016-03-04 at 14:04 -0800, Darin Adler wrote: > I’d like to learn more about this. Are the relevant warnings on for > all the WebKit project’s compilers, ports, and build systems? See: https://bugs.webkit.org/show_bug.cgi?id=153695 https://bugs.webkit.org/show_bug.cgi?id=155048 GCC and

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-04 Thread Michael Catanzaro
On Fri, 2016-03-04 at 10:32 -0800, Darin Adler wrote: > Here are three other loose ends I am thinking about: > > - Style guide should say that in a class marked final, virtual > functions should all be marked final, not override and certainly not > virtual. Agreed? Can we check that with the

Re: [webkit-dev] RFC: stop using std::chrono, go back to using doubles for time

2016-05-23 Thread Michael Catanzaro
On Mon, 2016-05-23 at 07:27 -0700, Filip Pizło wrote: > You guys are making a convincing case for > Seconds/WallTime/MonotonicTime! > > -Filip I will add: the convention "double means seconds" is very much not obvious. It's OK when we're careful to consistently use "seconds" in function and

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

2016-04-18 Thread Michael Catanzaro
On Mon, 2016-04-18 at 22:36 +0300, Konstantin Tokarev wrote: > Are there any objections for lowering GCC requirement from 4.9.0 to > 4.8.4 (only for JavaScriptCore without B3)? I'm going to fix arising > compilation errors myself. I've been kinda hoping to do this regardless, since you started

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

2016-04-19 Thread Michael Catanzaro
On Mon, 2016-04-18 at 17:26 -0700, Filip Pizlo wrote: > Yeah.  If we allow GCC 4.8 then I think we should make all of our > code compile with it.  If that proves too difficult (like if we had > to get rid of all lambdas), then I think we need to not allow GCC > 4.8. Agreed. And don't worry, we

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

2016-04-19 Thread Michael Catanzaro
Hi, On Mon, 2016-04-18 at 17:27 -0700, Filip Pizlo wrote: > I am sympathetic to the principle that we should support the > compilers that ship on the most popular versions of Linux. Great. :) > I’d like to understand if that argument is sufficient to support GCC > 4.8. > > Can you clarify, is

Re: [webkit-dev] SPAM on trac.webkit.org

2016-04-16 Thread Michael Catanzaro
A bunch of spam pages are currently being created on the wiki. I don't have permission to delete the pages so a wiki admin will have to clean this up (and ban the user). The first such page is: http://trac.webkit.org/wiki/Microsoft%20Office%20Support@%201844.811.60

Re: [webkit-dev] SPAM on trac.webkit.org

2016-04-17 Thread Michael Catanzaro
On Sun, 2016-04-17 at 06:44 -0700, Lucas Forschler wrote: > I believe the spam is coming only from users who are not identified > as developers (committers). Therefore, I’ve re-enabled WIKI_CREATE > and WIKI_MODIFY permissions to the trac ‘developer’ group.  > This will keep the wiki locked down

Re: [webkit-dev] Improving the flexibility of the cookie manager

2016-04-17 Thread Michael Catanzaro
On Sun, 2016-04-17 at 08:57 -0400, Drew DeVault wrote: > 2. Add sufficient signals and APIs to WebKitCookieManager to allow > the > UA to effectively manage cookies themselves. > > I'm leaning towards the second option. Would like to hear your > thoughts. I would lean towards the second option

Re: [webkit-dev] Build slave for JSCOnly Linux MIPS

2016-04-18 Thread Michael Catanzaro
On Mon, 2016-04-18 at 15:01 -0700, Geoffrey Garen wrote: > GCC 4.8 is three years old. Yeah, unfortunately no Linux distros are ever willing to do major compiler upgrades, even Fedora is only willing to take minor compiler upgrades, so our willingness to support old compilers is proportional to

Re: [webkit-dev] Is anyone here interested in improving rebaseline-server?

2016-07-14 Thread Michael Catanzaro
On Thu, 2016-07-14 at 18:03 +0300, Konstantin Tokarev wrote: > Is anybody here using rebaseline-server as well, or everyone is using > garden-o-matic? Hm, I didn't know about these tools; is there documentation for them? I've always rebased tests manually Michael

Re: [webkit-dev] SIGSEGV possibly (?) due to libwebkitgtk (backtrace included)

2016-07-09 Thread Michael Catanzaro
On Mon, 2016-07-04 at 00:53 -0700, Saam Barati wrote: > Presumably this is an older version of JSC, so whatever bug you're > seeing might be fixed in ToT. Possibly. We don't support this very old version of WebKitGTK+ anymore and gnome-web-photo is a long dead project, so I doubt anyone will be

Re: [webkit-dev] Settings and Testing (Settings, RuntimeEnabledFeatures, WebPreferences)

2017-01-20 Thread Michael Catanzaro
Thanks for this writeup. I encourage you to move this knowledge to a wiki page on trac, so we don't lose it here in the list archives. Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Implementing Universal Second Factor (U2F)

2017-02-22 Thread Michael Catanzaro
On Wed, 2017-02-22 at 12:20 -0500, Jacob Greenfield wrote: > Michael, > > Thanks for the info. After looking into things a bit more - let me > know if this does not make sense - it looks like it may be better to > reimplement for WebKit. OK, your explanation sounds reasonable to me. Michael

Re: [webkit-dev] Implementing Universal Second Factor (U2F)

2017-02-22 Thread Michael Catanzaro
On Wed, 2017-02-22 at 08:52 -0500, Jacob Greenfield wrote: > The (USB) protocol itself works by sending USB HID reports (packets) > to the key and getting USB HID reports back. There is a reference > implementation by one of the members of the specification group - > libu2f-host (by Yubico);

Re: [webkit-dev] ReadMe.md on Github

2017-02-22 Thread Michael Catanzaro
On Tue, 2017-02-21 at 22:53 -0800, Ryosuke Niwa wrote: > I feel like GTK+ port's instruction can be consolidated enough to fit > there but we might want to write some script that someone can run to > do everything you need like Tools/Scripts/configure-xcode-for-ios- > development for iOS first.

Re: [webkit-dev] Why does RELEASE_ASSERT not have an error message?

2017-02-22 Thread Michael Catanzaro
On Wed, 2017-02-22 at 11:58 -0800, Geoffrey Garen wrote: > (2) Change RELEASE_ASSERT to do the normal debug ASSERT thing in > Debug builds. (There’s not much need to preserve register state in > debug builds.) This seems like a more desirable approach. Michael

[webkit-dev] Bugzilla spammer

2017-01-16 Thread Michael Catanzaro
Hi, We appear to have a Bugzilla spammer [1]. The user posts a link to an unrelated website (I guess trying to improve SEO) and gave herself away by asking a nonsensical question about the bug (a request for detailed instructions on how to solve the bug when the bug was "add a comment"). In

Re: [webkit-dev] WebCore/platform standalone library

2017-01-18 Thread Michael Catanzaro
On Wed, 2017-01-18 at 12:17 -0800, Myles C. Maxfield wrote: > Static (At least for the Xcode projects. I imagine the cmake-based > projects could do whatever they want here). For GTK+ we really want static as well, we do not want a new shared library. So no difference here. Michael

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-06 Thread Michael Catanzaro
On Mon, 2016-09-05 at 10:23 -0700, Filip Pizlo wrote: > The use of "take" for these methods grinds my gears, for the same > reason you were distracted: "take" describes the desires of the > caller, but that doesn't work for me because I read > "fred.makeCoffee()" as "makeCoffee()" being an

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-06 Thread Michael Catanzaro
On Tue, 2016-09-06 at 11:12 -0700, Filip Pizlo wrote: > FWIW, I still like release() better than move().  a = move(b) is a > command to the system to move b to a.  So, value = > collection.move(key) feels like a command to the collection to move > key to value, which is clearly not what is going

[webkit-dev] WebKit2 build breakage

2016-09-01 Thread Michael Catanzaro
> The difference is that the GObject bindings are a seriously difficult > issue for Apple that materially slows down their development (or at > least appears to me to do so). It's impressive how much extra effort > Apple devs (hi Chris) have spent trying to keep our bindings building > (thanks!),

Re: [webkit-dev] WebKit GObject bindings: Who is guiding their future?

2016-08-30 Thread Michael Catanzaro
I'm OK with freezing the bindings. I'm disappointed in that these are a killer feature for us and they'll never get improved now, but generating them seems to be causing too many problems that we cannot easily solve. On Tue, 2016-08-30 at 08:54 +0200, Carlos Garcia Campos wrote: > haha, no, of

[webkit-dev] Terminate handler for WebKit

2016-09-09 Thread Michael Catanzaro
Hi, The GTK+ port currently has an interesting web process crash on exit: pure virtual method called terminate called without an active exception I found the easiest way to debug it was to rebuild with a terminate handler set:     std::set_terminate([] { CRASH(); }); Even if such

Re: [webkit-dev] Terminate handler for WebKit

2016-09-09 Thread Michael Catanzaro
On Fri, 2016-09-09 at 11:03 -0700, JF Bastien wrote: >    - The state of the stack when std::terminate is called is > implementation >    defined (it could be unwound, unwound partially, or not unwound at > all). Hi, I think it's very unlikely to ever be unwound because we compile with

Re: [webkit-dev] Terminate handler for WebKit

2016-09-09 Thread Michael Catanzaro
On Fri, 2016-09-09 at 10:47 -0700, Anders Carlsson wrote: > On macOS and iOS, we already get this by setting > NSApplicationCrashOnExceptions in our initialize function. > > - Anders OK, so we'd have to do it in ChildProcess::platformInitialize to not disturb you then. Michael

Re: [webkit-dev] [CMake] Bumping cmake_minimum_required

2016-09-20 Thread Michael Catanzaro
On Tue, 2016-09-20 at 18:35 +0900, Fujii Hironori wrote: > I'm interested in bumping cmake_minimum_required for > . > Which version of CMake is minimum version to be supported? Hi, WebKitGTK+ intends to continue supporting 2.8.12 until April, when we drop support for

Re: [webkit-dev] [CMake] Bumping cmake_minimum_required

2016-09-20 Thread Michael Catanzaro
On Tue, 2016-09-20 at 17:57 +0200, Carlos Garcia Campos wrote: > So, is our deps policy about build-time only dependencies too? I > don't > think it should be. The problem, as you're well aware, is that once our build dependencies exceed what's available in a particular distro, that distro will

Re: [webkit-dev] [CMake] Bumping cmake_minimum_required

2016-09-21 Thread Michael Catanzaro
On Wed, 2016-09-21 at 18:09 +0900, Fujii Hironori wrote: > Ubuntu 14.04 has GCC 4.8 and build fails with a following error > message. Hm that's a good point. Looks like that ship has already sailed. No, we don't want to support GCC 4.8. Our dependency policy is only a month old, and we just

Re: [webkit-dev] WebKit gobject bindings: Who is guiding their future?

2016-08-29 Thread Michael Catanzaro
On Mon, 2016-08-29 at 10:16 +0200, Carlos Garcia Campos wrote: > We basically have a Exception member > in WebKitDOMObject base class that is reset for every method call, > and > set in case of exception. Then we add > webkit_dom_object_get_exception() > to query if there were a exception. That's

Re: [webkit-dev] WebKit gobject bindings: Who is guiding their future?

2016-08-29 Thread Michael Catanzaro
On Mon, 2016-08-29 at 14:45 +0200, Carlos Garcia Campos wrote: > I agree this is not ideal for a GObject API, but I really don't see > how > this is a major problem, to be honest. The problem is that you would either have to check for errors on every function call, including the 95% of function

[webkit-dev] Bugzilla clock

2016-11-08 Thread Michael Catanzaro
I notice that the clock on Bugzilla is about four minutes fast. I guess it's not using NTP? This is not anywhere near as important as not being able to commit. It's just very slightly annoying. But I did want to report it somewhere! Michael ___

Re: [webkit-dev] Experimental features enabled at runtime

2016-11-05 Thread Michael Catanzaro
Hi Brady! On Sat, 2016-11-05 at 11:04 -0700, Brady Eidson wrote: > This has come up in Apple, where some people assume that the fact > they're called "Experimental" features means they are still under > heavy development or in some way unstable or potentially harmful. > > I don't believe that is

Re: [webkit-dev] Experimental features enabled at runtime

2016-11-05 Thread Michael Catanzaro
On Sat, 2016-11-05 at 16:03 -0700, Ryosuke Niwa wrote: > Maybe what we really need is one set of defaults that are appropriate > > for development (our bots, ENABLE(DEVELOPER_MODE), Safari Tech > Preview, > > etc.) and a different set of defaults that are appropriate for > stable > > releases and

[webkit-dev] Experimental features enabled at runtime

2016-11-05 Thread Michael Catanzaro
Hi, We discovered that several experimental features are currently enabled by default: https://bugs.webkit.org/show_bug.cgi?id=164367 It looks like the change was made to avoid needing to enable the features manually in Safari Tech Preview, but of course this is bad for all the non-Safari

Re: [webkit-dev] Bugzilla clock

2016-11-14 Thread Michael Catanzaro
On Mon, 2016-11-14 at 15:13 -0800, Lucas Forschler wrote: > This is really strange… When I compare the date on bugs.webkit.org to > my local time, bugzilla is actually 2 minutes behind.  > I don’t see any NTP errors when syncing. > Adding Ling to see if he has any ideas, or bandwidth to

Re: [webkit-dev] Proposal: Remove Battery Status API code

2016-10-30 Thread Michael Catanzaro
On Sun, 2016-10-30 at 17:14 -0700, Brady Eidson wrote: > What to other Apple folks think? What do port maintainers who enable > the API think? Hi, The GTK+ implementation has been broken for years [1] so we're definitely not going to miss it! Michael [1] 

Re: [webkit-dev] WebKit GPU rendering possibility

2016-11-04 Thread Michael Catanzaro
On Fri, 2016-11-04 at 08:23 +0100, Carlos Garcia Campos wrote: > What I can say as the GTK+ port maintainer is that we are very > interested in this. We are actually looking for a cairo replacement, > because unfortunately cairo is nowadays pretty much unmaintained. So, > if FastUIDraw can be used

Re: [webkit-dev] WebCore/platform standalone library

2017-01-13 Thread Michael Catanzaro
On Fri, 2017-01-13 at 11:39 -0200, Gustavo Sverzut Barbieri wrote: > On Thu, Jan 12, 2017 at 7:11 PM, Alex Christensen > wrote: > > If PAL were a shared library in a CMake build, then it wouldn’t > > build successfully if there were layering violations.  I think we > >

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-11 Thread Michael Catanzaro
Perhaps we need to be especially careful about replacing Refs and RefPtrs with auto. It was mentioned that using typedefs to hide pointer types is often the source of serious bugs. A similar rule could apply to using auto with smart pointers. On Wed, 2017-01-11 at 09:43 -0800, Darin Adler wrote:

Re: [webkit-dev] WebCore/platform standalone library

2017-01-11 Thread Michael Catanzaro
On Tue, 2017-01-10 at 21:28 -0800, Darin Adler wrote: > Given that WTF chose , what is the reasoning for PAL > choosing the all capital ? I kinda prefer myself, in order to parallel WTF. On the one hand, it almost doesn't matter, but on the other it's one more rule to have to memorize which

Re: [webkit-dev] WebCore/platform standalone library

2017-01-11 Thread Michael Catanzaro
Really happy to see progress on this! On Tue, 2017-01-10 at 21:24 -0800, Myles C. Maxfield wrote: > First of all, this isn’t a new project; instead, it’s a new target > inside the WebCore project. The target creates a static library which > gets linked into WebCore, which means that the

Re: [webkit-dev] WebCore/platform standalone library

2017-01-11 Thread Michael Catanzaro
On Wed, 2017-01-11 at 23:30 +, Olmstead, Don wrote: > I had thought of PAL as a library that is internal to WebCore that > provides a clear porting layer. I would not expect anyone outside of > WebCore to be linking to it. So honestly, I don't think this is very realistic. Lots of stuff

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Michael Catanzaro
On Thu, 2017-01-05 at 17:48 +0900, Yusuke SUZUKI wrote: > 1. specifying "org.webkit.ImageDecoder" > 2. In Linux, we just use "ImageDecoder" part. > 3. In macOS port, we automatically convert it to "WebKit: Image > Decoder" This sounds like a good path forward that works for all platforms. It's a

Re: [webkit-dev] update GCC version?

2017-01-09 Thread Michael Catanzaro
On Mon, 2017-01-09 at 16:39 +0100, Carlos Alberto Lopez Perez wrote: > Another idea is: (c) Drop the "one year after the release" > requirement. > Which means that we could update to minimum GCC version to 5.3 (the > one > in last Ubuntu LTS) when Debian 9 is released (which hopefully is >

Re: [webkit-dev] update GCC version?

2017-01-09 Thread Michael Catanzaro
On Mon, 2017-01-09 at 16:39 +0100, Carlos Alberto Lopez Perez wrote: > I strongly oppose to do (a). Also, it is false that Debian doesn't > take > our updates. They take our updates in the backports repository for > stable. Nobody uses that. Users expect to receive security updates in the

Re: [webkit-dev] update GCC version?

2017-01-09 Thread Michael Catanzaro
On Mon, 2017-01-09 at 16:56 +0100, Carlos Alberto Lopez Perez wrote: > Can you please explain how you reach that conclusion? > Do you have any data to back up such claim? No, I don't have data, but it seems extremely naive to assume that any significant subset of users use backports. It is not

Re: [webkit-dev] fullscreen-webkit.c

2016-12-29 Thread Michael Catanzaro
On Thu, 2016-12-29 at 14:26 -0500, Jerry Geis wrote: > Hi All, > > I took fullscreen-webkit.c and added some functionality. Hi, So my first question would be: where is this file? We can't help you much if we don't know what you're doing. :) > I now updated to CentOS 7.3 and the program still

Re: [webkit-dev] update GCC version?

2017-01-08 Thread Michael Catanzaro
On Sun, 2017-01-08 at 18:59 +0100, z...@falconsigh.net wrote: > For the record, GCC 5 has complete C++14 support. The current > requirement is 4.9, so the bump would be minimal. > https://gcc.gnu.org/projects/cxx-status.html#cxx14 We would need to redefine our dependencies policy:

Re: [webkit-dev] Web inspector images

2016-12-19 Thread Michael Catanzaro
On Tue, 2016-02-09 at 11:44 -0800, Timothy Hatcher wrote: > Hi Michael, > > I am looking into our options for the license of the images. Stay > tuned. > > — Timothy Hatcher Hi Timothy, Any update on this? We should really remove these images from OpenSource if Apple does not want to relicense

Re: [webkit-dev] Naming preference: SetForScope vs. TemporaryChange

2016-12-23 Thread Michael Catanzaro
On Fri, 2016-12-23 at 05:42 +, Yusuke SUZUKI wrote: > Personally I like the name "SetForScope" since the name "scope" > states that this value change is tied to C++ scope. Me too. The name is pretty clear. The first time I saw TemporaryChange I had to look at the implementation to see what it

Re: [webkit-dev] MiniBrowser

2017-03-15 Thread Michael Catanzaro
On Wed, 2017-03-15 at 14:37 +0100, Carlos Alberto Lopez Perez wrote: > Please, report bugs in bugzilla: https://bugs.webkit.org/ > > If the bug is about WebKitGTK+ (I guess it is, because you are using > Linux), then either select component WebKit Gtk or include in the CC > list the address

Re: [webkit-dev] Introduce WebKit Android port

2017-03-16 Thread Michael Catanzaro
Hi, Is this just a code drop? Or will you be committing to its maintenance and attempting to upstream it? It's interesting regardless! Michael ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Proposal: upstream the WPE port

2017-04-22 Thread Michael Catanzaro
On Fri, Apr 21, 2017 at 6:01 PM, Geoffrey Garen wrote: I think the biggest consideration here is the problems we’ve noticed in the C API that have produced poor designs that we don’t intend to support going forward. Does the WPE port’s API need to be backwards-compatible in

  1   2   3   >