[webkit-dev] CSS Logical Properties and Values

2018-08-08 Thread Oriol Brufau
https://drafts.csswg.org/css-logical-1/defines properties and values to control layout through logical, rather than physical, direction and dimension mappings.   I have been working on implementing this in Blink, now I'm starting with WebKit.   Various properties are already supported but using non

Re: [webkit-dev] CSS Logical Properties and Values

2018-08-21 Thread Oriol Brufau
I have written a patch for adding logical shorthand properties. However, I'm not much sure about how I can implement them behind a flag. I tried hiding them behind a run-time flag. But unlike Blink, it seems I can't do this easily in CSSProperties.json. Instead, I wrapped the code added in CSSProp

Re: [webkit-dev] CSS Logical Properties and Values

2018-08-21 Thread Oriol Brufau
But as far as I can tell, this only prevents conic gradients from being parsed. In my case I want to completely hide some CSS properties. Preventing the parser from accepting their values is not enough, because they are still exposed via `prop in element.style`. El 22/8/18 a les 03:11, Simon Fra

Re: [webkit-dev] CSS Logical Properties and Values

2018-08-21 Thread Oriol Brufau
In Blink, properties are defined in CSSProperties.json5, there you can specify a "runtime_flag" property whose value is the name of a runtime flag. This overrides the IsEnabled method with a check for the runtime flag: https://cs.chromium.org/chromium/src/third_party/blink/renderer/build/scripts/c

Re: [webkit-dev] CSS Logical Properties and Values

2018-11-02 Thread Oriol Brufau
posed properties. Does this approach look good? Please review my patch (only the parts related with runtime flags, Simon Fraser already approved the logical shorthands). El 22/8/18 a les 02:56, Oriol Brufau ha escrit: > I have written a patch for adding logical shorthand properties. However, &