Re: [webkit-dev] WebCore/platform standalone library

2015-03-19 Thread saam barati
I think JavaScriptCore will need access to 'platform', too, to implement some ES6 features.  Saam On Thu, Mar 19, 2015 at 2:50 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 19, 2015, at 1:47 PM, Benjamin Poulain benja...@webkit.org wrote: On 3/18/15 9:43 PM, Myles C. Maxfield

Re: [webkit-dev] Contributing to webkit Open Source project

2015-08-03 Thread saam barati
Hi Mukesh, I agree with Geoff that working ES6 features is a great starting point. Also, going on #webkit IRC is helpful and you can speak with other people working on JSC/WebKit. If you have any questions, my IRC handle is saamyjoon. On Mon, Aug 3, 2015 at 11:14 AM, Geoffrey Garen

[webkit-dev] Getting the frame pointer and program counter of a thread on gtk and efl ports

2016-01-06 Thread Saam barati
Hi all, I’m writing some platform dependent code for a sampling profiler I’m adding to JSC. I’m looking for a way to get a thread’s frame pointer and program counter in the gtk and efl ports while that thread is paused. We already have a way to grab the stack pointer of a thread on all ports. If

Re: [webkit-dev] Some text about the B3 compiler

2016-01-29 Thread saam barati
both B3 and the documentation in one go, and the documentation would go >>> live when it’s committed. >>> >>> Does anyone object to this? >>> >>> -Filip >>> >>> >>>> On Jan 28, 2016, at 4:39 PM, Saam barati <sbar.

Re: [webkit-dev] Some text about the B3 compiler

2016-01-28 Thread Saam barati
lip > > On Jan 28, 2016, at 4:32 PM, Saam barati <sbar...@apple.com > <mailto:sbar...@apple.com>> wrote: > >> This is great. Thanks Fil. >> >> I propose that we do all that we can to keep this updated. >> I suggest that all patches that

Re: [webkit-dev] Some text about the B3 compiler

2016-01-28 Thread Saam barati
This is great. Thanks Fil. I propose that we do all that we can to keep this updated. I suggest that all patches that change to the IR should also include with it a change to the documentation, and that reviewers should require this. It’d also be great if other significant changes that seem

Re: [webkit-dev] Which bugzilla component should be used for bmalloc?

2016-02-23 Thread saam barati
I also came across this when doing a bmalloc patch recently. I think it'd be useful to have a bmalloc component. Saam > On Feb 22, 2016, at 7:58 AM, Konstantin Tokarev wrote: > > Hello, > > It seems like there is no appropriate bugzilla component for bmalloc. In my >

Re: [webkit-dev] Sukolsak Sakshuwong is now a WebKit Reviewer

2016-03-08 Thread Saam barati
Congrats Sukol! Saam > On Mar 8, 2016, at 6:33 PM, Yusuke SUZUKI wrote: > > Congrats! > > --- > Regards, > Yusuke Suzuki > > On Wed, Mar 9, 2016 at 6:01 AM, Ryosuke Niwa > wrote: > Congratulations, Sukolsak! > > - R. Niwa

Re: [webkit-dev] Keith Miller is now a WebKit reviewer

2016-04-05 Thread Saam Barati
Congrats! Saam > On Apr 5, 2016, at 12:32 PM, Mark Lam wrote: > > Hi everyone, > > Just want to announce that Keith Miller is now a reviewer. Keith primarily > works on JavaScriptCore. Feel free to ask him for reviews. > > Congratulations, Keith. > > Mark > >

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-03 Thread Saam barati
+1. I like how “override” only reads. Saam > On Mar 3, 2016, at 9:54 AM, Ryosuke Niwa wrote: > > I think "virtual" + "override" is more of a historical artifact than > the preferred style because we used to have OVERRIDE macro before all > compilers supported C++11. I think

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-03 Thread Saam barati
(3) seems like a good idea to me! I’ll volunteer for (1) Saam > On Mar 3, 2016, at 11:35 AM, Darin Adler wrote: > > 3) physically restrain me from turning do-webcore-rename into a perl script > that does this all the code in the entire source tree all at one go, since > that

Re: [webkit-dev] SIGSEGV possibly (?) due to libwebkitgtk (backtrace included)

2016-07-04 Thread Saam Barati
Looks like JSValue() (which is the empty JS Value, with bit representation as zero) is showing up somewhere it shouldn't be. It's hard to tell what the bug is just from your stack trace. It could be helpful to enable/disable various JIT tiers to see if it still reproduces and take it from

Re: [webkit-dev] Why does RELEASE_ASSERT not have an error message?

2017-02-21 Thread Saam barati
I thought the main point of moving to SIGTRAP was to preserve register state? That said, there are probably places where we care more about the message than the registers. - Saam > On Feb 21, 2017, at 5:43 PM, Mark Lam wrote: > > Is there a reason why RELEASE_ASSERT (and

Re: [webkit-dev] Why does RELEASE_ASSERT not have an error message?

2017-02-22 Thread Saam barati
017, at 5:56 PM, Mark Lam <mark@apple.com> wrote: >>> >>> Oh yeah, I forgot about that. I think the register state is more important >>> for crash analysis, especially if we can make sure that the compiler does >>> not aggregate the int3s. I’ll explore alternatives

Re: [webkit-dev] Why does RELEASE_ASSERT not have an error message?

2017-02-22 Thread Saam barati
>> } >>> >>> Look in the code - you'll find lots of stuff like this. >>> >>> I don't think analyzing register state at crashes is more important than >>> keeping our code sane. >>> >>> -Filip >>> >>>

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-17 Thread Saam barati
> On Jan 12, 2017, at 10:37 AM, Geoffrey Garen wrote: > >>> e.g. I think this is great: >>> auto ptr = std::make_unique(bar); >>> Proposed rule: if the type is obvious because it's on the line, then auto >>> is good. >>> Similarly: >>> auto i = static_cast(j); >>> auto foo =

Re: [webkit-dev] [webkit-reviewers] usage of auto

2017-01-11 Thread saam barati
> On Jan 11, 2017, at 11:15 AM, JF Bastien wrote: > > Would it be helpful to focus on small well-defined cases where auto makes > sense, and progressively grow that list as we see fit? > > > e.g. I think this is great: > auto ptr = std::make_unique(bar); > Proposed rule:

[webkit-dev] Naming preference: SetForScope vs. TemporaryChange

2016-12-22 Thread Saam barati
Hi all, Recently, Yusuke found that JSC and WTF both had the exact same RAII helper data structure. JSC called it SetForScope, and WTF called it TemporaryChange. (Details here: https://bugs.webkit.org/show_bug.cgi?id=164761 ). Yusuke went to

Re: [webkit-dev] Naming preference: SetForScope vs. TemporaryChange

2016-12-25 Thread Saam Barati
I like ScopedChange the most out of all the names. It's a bit unfortunate that such a name doesn't work well in the context of having a ScopedChange as a member variable. I think TemporaryChange works much better as a name if the use is as a member variable. My hunch would be the most frequent

Re: [webkit-dev] Naming preference: SetForScope vs. TemporaryChange

2016-12-26 Thread Saam Barati
is admittedly an odd use case that probably doesn't exist in WebKit. However, if this use case were common, the name ScopedChange feels wrong for it. - Saam > On Dec 25, 2016, at 7:29 PM, Maciej Stachowiak <m...@apple.com> wrote: > > >> On Dec 25, 2016, at 11:35 AM, Saam Barati <

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-13 Thread Saam barati
Can you please run Octane and Kraken too? - Saam > On Jul 13, 2017, at 7:47 AM, Caio Lima wrote: > > Finally I got the results from the last benchmark run. The results > shows that the speed-ups are considerable comparing with CLoop > version, since we get faster results

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-13 Thread Saam barati
And ARES6. - Saam > On Jul 13, 2017, at 1:50 PM, Saam barati <sbar...@apple.com> wrote: > > Can you please run Octane and Kraken too? > > - Saam > >> On Jul 13, 2017, at 7:47 AM, Caio Lima <ticaiol...@gmail.com >> <mailto:ticaiol...@gmail.com>&

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-07-05 Thread Saam barati
What’s the testing plan here? Do y'all plan to add a bot that ensures ARMv6 stays working? - Saam > On Jun 13, 2017, at 6:48 PM, Caio Lima wrote: > > Hi All. > > Some of you guys might know me through the work I have been doing in > JSC. The experience working with

Re: [webkit-dev] User agent woes

2017-05-07 Thread Saam Barati
> On May 6, 2017, at 5:19 PM, Michael Catanzaro wrote: > > Hi, > > You're probably aware that WebKitGTK+ has user agent quirks to make various > popular websites work, most notably google.com. For our list of quirks, see: > >

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Saam Barati
> On Aug 29, 2017, at 1:22 PM, Olmstead, Don wrote: > > Sure but in a corporate environment it can be a really big win. All of our > developers have their machines hooked up to the distributed build system and > we also have servers hanging out that can be used in the

Re: [webkit-dev] Can we drop supporting mixed Wasm::MemoryMode in one process?

2018-08-28 Thread Saam Barati
I would also expect bytecode interpreter compilation to be so much faster than JIT compilation that we could laziliy compile either: - When we instantiate - When functions are called for the first time - Saam > On Aug 28, 2018, at 12:17 PM, Yusuke Suzuki > wrote: > > > > On Wed, Aug 29,

Re: [webkit-dev] BigIntBench

2018-10-07 Thread Saam Barati
Hi Caio, > On Oct 6, 2018, at 7:30 AM, Caio Lima wrote: > > Hi all. > > I'm starting working to fix JIT support of BigInt in some operations > we already have upstream. In such case, I'm sending > (https://bugs.webkit.org/show_bug.cgi?id=186177) to support BigInt > speculation into ValueAdd

Re: [webkit-dev] [jsc-dev] Proposal: Using LLInt Asm in major architectures even if JIT is disabled

2018-09-19 Thread Saam Barati
To elaborate: I ran this same experiment before. And I forgot to turn off the RegExp JIT and got results similar to what you got. Once I turned off the RegExp JIT, I saw no perf difference. - Saam > On Sep 19, 2018, at 8:53 AM, Saam Barati wrote: > > Did you turn off the R

Re: [webkit-dev] Proposal: Using LLInt Asm in major architectures even if JIT is disabled

2018-09-19 Thread Saam Barati
Did you turn off the RegExp JIT? - Saam > On Sep 18, 2018, at 11:23 PM, Yusuke Suzuki > wrote: > > Hi WebKittens! > > Recently, node-jsc is announced[1]. When I read the documents of that project, > I found that they use LLInt ASM interpreter instead of CLoop in non-JIT > environment. > So

Re: [webkit-dev] [jsc-dev] Proposal: Using LLInt Asm in major architectures even if JIT is disabled

2018-09-20 Thread Saam Barati
Interesting! I must have not run this experiment correctly when I did it. - Saam > On Sep 19, 2018, at 7:31 PM, Yusuke Suzuki wrote: > >> On Thu, Sep 20, 2018 at 12:54 AM Saam Barati wrote: >> To elaborate: I ran this same experiment before. And I forgot to turn off >>

Re: [webkit-dev] Can we jettison Sputnik?

2019-01-15 Thread Saam barati
Hi Ross, > On Jan 15, 2019, at 11:50 AM, ross.kirsl...@sony.com wrote: > > Hi everybody, > > I’d like to verify whether there’s any specific reason that the > LayoutTests/sputnik directory continues to exist. > > According to Wikipedia, “All current Sputnik tests have been incorporated >

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-14 Thread Saam Barati
> On Dec 14, 2018, at 1:54 PM, Saam Barati wrote: > > > >> On Dec 14, 2018, at 1:37 PM, Chris Dumez > <mailto:cdu...@apple.com>> wrote: >> >> Hi, >> >> I have now been caught twice by std::optional’s move constructor. It turns &

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-14 Thread Saam Barati
> On Dec 14, 2018, at 1:37 PM, Chris Dumez wrote: > > Hi, > > I have now been caught twice by std::optional’s move constructor. It turns > out that it leaves the std::optional being moved-out *engaged*, it merely > moves its value. > > For example, testOptional.cpp: > #include > #include

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-14 Thread Saam Barati
> On Dec 14, 2018, at 1:59 PM, Chris Dumez wrote: > >> >> On Dec 14, 2018, at 1:56 PM, Saam Barati > <mailto:sbar...@apple.com>> wrote: >> >> >> >>> On Dec 14, 2018, at 1:54 PM, Saam Barati >> <mailto:sbar...@apple.com>

Re: [webkit-dev] node-jsc: A node.js port to the JavaScriptCore engine and iOS

2018-09-16 Thread Saam Barati
Hi Koby, This sounds awesome. A good list of people to CC on the bug for reviews are: sbar...@apple.com,fpi...@apple.com,keith_mil...@apple.com,mark@apple.com,msab...@apple.com,yusukesuz...@slowstart.org - Saam > On Sep 16, 2018, at 11:44 AM, Filip Pizlo wrote: > > > >> On Sep 16,

Re: [webkit-dev] Code Style: Opinion on returning void

2019-02-20 Thread Saam Barati
I prefer it as well. - Saam > On Feb 20, 2019, at 6:58 AM, Chris Dumez wrote: > > I also prefer allowed returning void. > > Chris Dumez > >> On Feb 19, 2019, at 10:35 PM, Daniel Bates wrote: >> >> >> >>> On Feb 19, 2019, at 9:42 PM, Ryosuke Niwa wrote: >>> On Tue, Feb 19, 2019 at

Re: [webkit-dev] Code Style: Opinion on returning void

2019-02-07 Thread Saam Barati
> On Feb 7, 2019, at 12:53 PM, Tim Horton wrote: > > > >> On Feb 7, 2019, at 12:47 PM, Daniel Bates wrote: >> >> Hi all, >> >> Something bothers me about code like: >> >> void f(); >> void g() >> { >>if (...) >>return f(); >>return f(); >> } > > ⸘do people do this‽ I've

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

2019-02-14 Thread Saam Barati
Hi Caitlin and Xan, > On Feb 13, 2019, at 1:51 PM, ca...@igalia.com wrote: > > Hi WebKitters, > > My colleagues at Igalia have been working on a number of JS language > features! We want WebKit to have implementations in order to provide feedback > for TC39, and to help meet the requirements

Re: [webkit-dev] CI builds failing for ppc64, ppc64le and s390x

2019-06-03 Thread Saam Barati
In JavaScriptCore, we make changes all the time that could break builds along these lines. For this, it sounds like someone is doing a bad bitwise_cast, and it should be trivial to fix. My guess based on the variable names is it’s one of Keith’s RegExp changes. - Saam > On Jun 3, 2019, at

[webkit-dev] Tadeu and Robin are now WebKit reviewers

2019-06-10 Thread Saam Barati
Hi folks, Tadeu and Robin are both now WebKit reviewers. Join me in congratulating them. Please ask them to review your code! They both have a focus in JSC. - Saam ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] CI builds fail on all platforms with "ReferenceError: Can't find variable: WebAssembly"

2019-09-06 Thread Saam Barati
Those tests should be checking if WebAssembly is enabled at all before running the test. Something like: if (this.WebAssembly) { ... put test here ... } Feel free to post a patch and I can review it. - Saam > On Sep 6, 2019, at 2:59 AM, Eike Rathke wrote: > > Hi, > > our CI builds keep

Re: [webkit-dev] 2019 WebKit Contributors Meeting - Registration is Open

2019-09-18 Thread Saam Barati
You need to first login to: trac.webkit.org You'll get an email to verify your email. After verifying, you'll be able to login on webkit.org (Thanks to Tadeu for figuring this out) - Saam > On Sep 18, 2019, at 2:14 PM, Chris Dumez wrote: > >

Re: [webkit-dev] Planned EWS improvements

2019-09-26 Thread Saam Barati
Hi Aakash, Thanks for doing this work. > On Sep 26, 2019, at 11:27 AM, Aakash Jain wrote: > > Hi Everyone, > > I have been making number of improvements to EWS. I also have various planned > improvements to EWS. I wanted to reach out to you guys to see if anyone wants > me to prioritize any

Re: [webkit-dev] [Styling] Space between [] and () in C++ lambdas

2019-11-01 Thread Saam Barati
> On Nov 1, 2019, at 11:19 AM, Ryosuke Niwa wrote: > > Hi all, > > There seems to be inconsistency in our coding style with regards to spacing > in lambdas. I've noticed this too and the lack of consistency slightly annoys me. > > Namely, some people write a lambda as: > auto x = [] () {

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Saam Barati
> > Thanks, > Geoff > >> On Jun 18, 2020, at 9:30 PM, Saam Barati > <mailto:sbar...@apple.com>> wrote: >> >> Why are we insisting on doing something on the bots that takes ~10x longer >> to run than necessary? I’d rather have that time spent r

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Saam Barati
ld take ~4-8 hours. We >>> can wait for official confirmation from Mark. >> >> Alexey, do the JSC stress tests run now on bots? If not, how fast would they >> need to run in order to be eligible to run on bots? > > I don't think that there is a simple answ

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-19 Thread Saam Barati
> On Jun 19, 2020, at 10:02 AM, Saam Barati wrote: > > > >> On Jun 19, 2020, at 8:04 AM, Geoffrey Garen > <mailto:gga...@apple.com>> wrote: >> >> Can you explain more about what "O3 with no-inlining” is? How does >> --force-opt=O3 a

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-18 Thread Saam Barati
Why are we insisting on doing something on the bots that takes ~10x longer to run than necessary? I’d rather have that time spent running more tests. Overall, how we’re doing things now feels like a bad allocation of bot resources. The differences I see between O3 with no-inlining vs O0 is: -

Re: [webkit-dev] Switching open source Debug bots to building and testing with configuration --force-opt=O3

2020-06-24 Thread Saam Barati
don’t >>>>> have to share the build artifacts for running the tests. JSC test runs >>>>> should be able to just build JSC for each O3 Debug JSC test run and it is >>>>> still a win over the current status quo i.e. test runs never complete. >>&