Re: [webkit-dev] Experimental and (new) Internal feature flags

On 05/11/2018 09:28, Manuel Rego Casasnovas wrote: > I'm not sure about DRT. It seems you need to modify > https://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/TestOptions.cpp#L102 > in order that these headers work there. Thanks rego. Probably this file should assert or log error for

Re: [webkit-dev] Experimental and (new) Internal feature flags

On 25/09/18 01:00, Ryosuke Niwa wrote: > On Mon, Sep 24, 2018 at 1:26 AM Frédéric Wang > wrote: > > On 12/09/2018 23:48, Dean Jackson wrote: > > What about testing? > > > > > > You can turn both experimental and internal features on via >

Re: [webkit-dev] Experimental and (new) Internal feature flags

On Mon, Sep 24, 2018 at 1:26 AM Frédéric Wang wrote: > On 12/09/2018 23:48, Dean Jackson wrote: > > What about testing? > > > > > > You can turn both experimental and internal features on via headers in > WebKitTestRunner. Use experimental:FeatureName or internal:FeatureName. For >

Re: [webkit-dev] Experimental and (new) Internal feature flags

On 12/09/2018 23:48, Dean Jackson wrote: > What about testing? > > > You can turn both experimental and internal features on via headers in > WebKitTestRunner. Use experimental:FeatureName or internal:FeatureName. For > example... > > IIUC some platforms (WK1?) still use DumpRenderTree to

Re: [webkit-dev] Experimental and (new) Internal feature flags

> On 13 Sep 2018, at 13:49, youenn fablet wrote: > > When implementing a new feature, the first thing we usually do is having an > experimental flag turned off by default. At some point, we turn on the > experimental flag for tests. When ready, the flag is turned on by default. This isn't

Re: [webkit-dev] Experimental and (new) Internal feature flags

On Wed, Sep 12, 2018 at 11:02 PM Frédéric Wang wrote: > Thanks for the heads-up. Some random thoughts on this: > > * For WPT tests, I would like a solution that does not discourage WebKit > developers to contribute new tests to upstream WPT. It seems to me that > such a risk exists for the

Re: [webkit-dev] Experimental and (new) Internal feature flags

Thanks for the heads-up. Some random thoughts on this: * For WPT tests, I would like a solution that does not discourage WebKit developers to contribute new tests to upstream WPT. It seems to me that such a risk exists for the proposal based on a header in the files. * The per-directory or

Re: [webkit-dev] Experimental and (new) Internal feature flags

> On Wed, Sep 12, 2018 at 8:49 PM youenn fablet wrote: > >> >> Since an experimental feature flag should not remain off for a long time, >>> a per-experimental-feature file listing the tests to which activate the >>> feature could be considered. >>> >>> >>> That clashes with Ryosuke's point that

Re: [webkit-dev] Experimental and (new) Internal feature flags

> On 13 Sep 2018, at 09:03, youenn fablet wrote: > > > What about testing? > > > You can turn both experimental and internal features on via headers in > WebKitTestRunner. Use experimental:FeatureName or internal:FeatureName. For > example... > > > > It seems tedious to add such

Re: [webkit-dev] Experimental and (new) Internal feature flags

> What about testing? > > > You can turn both experimental and internal features on via headers in > WebKitTestRunner. Use experimental:FeatureName or internal:FeatureName. For > example... > > > It seems tedious to add such things to every test. That would also mean we would need to remove

Re: [webkit-dev] Experimental and (new) Internal feature flags

On Wed, Sep 12, 2018 at 3:53 PM Dean Jackson wrote: > On 13 Sep 2018, at 08:50, Ryosuke Niwa wrote: > > > On Wed, Sep 12, 2018 at 3:09 PM Dean Jackson wrote: > >> On 13 Sep 2018, at 08:05, Ali Juma wrote: >> >> Is there a plan for how to handle web platform tests (where we can't add >> such a

Re: [webkit-dev] Experimental and (new) Internal feature flags

> On 13 Sep 2018, at 08:50, Ryosuke Niwa wrote: > > > On Wed, Sep 12, 2018 at 3:09 PM Dean Jackson > wrote: >> On 13 Sep 2018, at 08:05, Ali Juma > > wrote: >> >> Is there a plan for how to handle web platform tests (where we can't add >>

Re: [webkit-dev] Experimental and (new) Internal feature flags

On Wed, Sep 12, 2018 at 3:09 PM Dean Jackson wrote: > On 13 Sep 2018, at 08:05, Ali Juma wrote: > > Is there a plan for how to handle web platform tests (where we can't add > such a header)? > > Currently, WebKitTestRunner enables all experimental features in tests > (including those disabled

Re: [webkit-dev] Experimental and (new) Internal feature flags

> On 13 Sep 2018, at 08:05, Ali Juma wrote: > > Is there a plan for how to handle web platform tests (where we can't add such > a header)? > > Currently, WebKitTestRunner enables all experimental features in tests > (including those disabled by default), so adding an experimental feature >

Re: [webkit-dev] Experimental and (new) Internal feature flags

On Wed, Sep 12, 2018 at 5:48 PM Dean Jackson wrote: > I just added support for a new category of WebKit2 preference: internal > debug. > > The motivating factor was that people were abusing experimental features > to add flags for anything they wanted to toggle at runtime, even if our > users

[webkit-dev] Experimental and (new) Internal feature flags

I just added support for a new category of WebKit2 preference: internal debug. The motivating factor was that people were abusing experimental features to add flags for anything they wanted to toggle at runtime, even if our users would have no idea what it meant (nor should they ever toggle