> On Jul 14, 2016, at 11:17 AM, Frédéric WANG wrote:
>
> FYI, I just performed that change as part of a general cleanup of MathML
> headers:
>
> https://trac.webkit.org/changeset/203228
>
> The code style guidelines still mention the old-style header guards so
> it should
FYI, I just performed that change as part of a general cleanup of MathML
headers:
https://trac.webkit.org/changeset/203228
The code style guidelines still mention the old-style header guards so
it should probably be updated:
https://webkit.org/code-style-guidelines/#names-header-guards
Le
> On Mar 17, 2016, at 9:35 AM, Konstantin Tokarev wrote:
>
> Here is a script which apparently can be used to convert whole code base to
> new style:
>
> https://github.com/cgmb/guardonce
They sound like they are worth trying. Especially the “checkguard” script.
Whoever
10.03.2016, 05:07, "Brent Fulgham" :
>> On Mar 9, 2016, at 5:27 PM, Anders Carlsson wrote:
>>
>> I propose that we instead start using
>>
>> #pragma once
>
> +1
Here is a script which apparently can be used to convert whole code base to new
style:
Yeah, I agree.
- Anders
> On Mar 9, 2016, at 6:46 PM, Michael Catanzaro wrote:
>
> On Wed, 2016-03-09 at 17:27 -0800, Anders Carlsson wrote:
>> Hi floks,
>>
>> Currently we use
>>
>> #ifndef Header_h
>> #define Header_h
>>
>> …
>>
>> #endif
>>
>> I propose that we
On Wed, 2016-03-09 at 17:27 -0800, Anders Carlsson wrote:
> Hi floks,
>
> Currently we use
>
> #ifndef Header_h
> #define Header_h
>
> …
>
> #endif
>
> I propose that we instead start using
>
> #pragma once
>
> which does the same thing.
I think it's fine for the GTK port in general, but
> On Mar 9, 2016, at 5:27 PM, Anders Carlsson wrote:
>
> I propose that we instead start using
>
> #pragma once
+1
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev
I think we should put it where we currently have the header guard. I think the
pragma is easier to understand than a #ifndef/#define.
- Anders
> On Mar 9, 2016, at 5:33 PM, Brian Burg wrote:
>
> Cool! It sounds like something good for new headers and drive-by cleanups, to
>
Cool! It sounds like something good for new headers and drive-by cleanups, to
start.
To clarify, it would always go after the license block? Is the pragma name
stable and understandable enough to paste everywhere?
-Brian
> On Mar 9, 2016, at 17:27, Anders Carlsson
Hi floks,
Currently we use
#ifndef Header_h
#define Header_h
…
#endif
I propose that we instead start using
#pragma once
which does the same thing. It can be faster on some compilers, is less error
prone and is one line instead of three! All compilers we use support #pragma
once.
10 matches
Mail list logo