Re: [webkit-dev] Reminder: include everything that you use in implementation files

I think, without EWS / post-build bots using non-unified builds, this is difficult to achieve… -Yusuke > On Nov 12, 2020, at 4:16 AM, Adrian Perez de Castro via webkit-dev > wrote: > > Hello Peng, > > On Wed, 11 Nov 2020 12:05:18 -0800 "Peng (WebKit) Liu via webkit-dev" > wrote: > >> Any

Re: [webkit-dev] Reminder: include everything that you use in implementation files

Hello Peng, On Wed, 11 Nov 2020 12:05:18 -0800 "Peng (WebKit) Liu via webkit-dev" wrote: > Any way/option to turn off the unified build completely or partially in a > local build? That would be very helpful for a developer to locally verify > that header files are included correctly in a

Re: [webkit-dev] Reminder: include everything that you use in implementation files

Hi Brian, Any way/option to turn off the unified build completely or partially in a local build? That would be very helpful for a developer to locally verify that header files are included correctly in a patch. Thanks! Best regards Peng > On Nov 6, 2020, at 11:21 AM, Brian Burg via webkit-dev

[webkit-dev] Reminder: include everything that you use in implementation files

Hello folks, I'd like to remind everyone to please include what you use in .cpp, .mm, and other files. When reviewing patches, please ensure that new mentions of classes, structs, etc. within an implementation file have a corresponding header include. All of our headers have #pragma once, so