Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-08 Thread Ashod Nakashian
From: Simon Fraser simon.fra...@apple.com To: Eric Seidel e...@webkit.org Cc: WebKit Development webkit-dev@lists.webkit.org Sent: Thursday, March 8, 2012 3:37 AM Subject: Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing The best way to enforce

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-08 Thread Ojan Vafai
:* WebKit Development webkit-dev@lists.webkit.org *Sent:* Thursday, March 8, 2012 3:37 AM *Subject:* Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing The best way to enforce it would be with a pre-commit hook: https://bugs.webkit.org/show_bug.cgi?id=80548

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-08 Thread Philip Rogers
:* Thursday, March 8, 2012 3:37 AM *Subject:* Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing The best way to enforce it would be with a pre-commit hook: https://bugs.webkit.org/show_bug.cgi?id=80548 Simon On Mar 7, 2012, at 3:33 PM, Eric Seidel wrote

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-08 Thread Eric Seidel
: [webkit-dev] Please set the svn:mime-type property on binary files before committing The best way to enforce it would be with a pre-commit hook: https://bugs.webkit.org/show_bug.cgi?id=80548 Simon On Mar 7, 2012, at 3:33 PM, Eric Seidel wrote: Unless this is enforced by a tool, it's very

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-08 Thread Dan Bernstein
, 2012 3:37 AM Subject: Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing The best way to enforce it would be with a pre-commit hook: https://bugs.webkit.org/show_bug.cgi?id=80548 Simon On Mar 7, 2012, at 3:33 PM, Eric Seidel wrote: Unless

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-07 Thread James Robinson
On Wed, Mar 7, 2012 at 3:21 PM, Dan Bernstein m...@apple.com wrote: Please set the svn:mime-type property on binary files that you add to the tree, such as *-expected.png, before committing. Otherwise the resulting webkit-changes message will include those files as text, which is

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-07 Thread Eric Seidel
Unless this is enforced by a tool, it's very likely to be forgotten. https://bugs.webkit.org/show_bug.cgi?id=75824 https://bugs.webkit.org/show_bug.cgi?id=75825 On Wed, Mar 7, 2012 at 3:21 PM, Dan Bernstein m...@apple.com wrote: Please set the svn:mime-type property on binary files that you

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-07 Thread Simon Fraser
The best way to enforce it would be with a pre-commit hook: https://bugs.webkit.org/show_bug.cgi?id=80548 Simon On Mar 7, 2012, at 3:33 PM, Eric Seidel wrote: Unless this is enforced by a tool, it's very likely to be forgotten. https://bugs.webkit.org/show_bug.cgi?id=75824

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-03-07 Thread Sravan
Hi, If i get the context correct, then mime-type is automatically set to png files as Property changes on: abc.png ___ Added: svn:mime-type ## -0,0 +1 ## +image/png when we run ./Tools/Scripts/svn-create-patch if the svn version is

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-01-08 Thread Benjamin Poulain
On Sun, Jan 8, 2012 at 6:15 PM, Dan Bernstein m...@apple.com wrote: Please set the svn:mime-type property on binary files that you add to the tree, such as *-expected.png, before committing. Otherwise the resulting webkit-changes message will include those files as text, which is inconvenient.

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-01-08 Thread Mike Lawther
And for git users: http://trac.webkit.org/wiki/UsingGitWithWebKit (there is a section on setting mime-types via subversion's config file). On 9 January 2012 13:44, Benjamin Poulain benja...@webkit.org wrote: On Sun, Jan 8, 2012 at 6:15 PM, Dan Bernstein m...@apple.com wrote: Please set the

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2012-01-08 Thread Eric Seidel
Seems like something our tools should do automatically for you. Humans are inevitably going to get this wrong. https://bugs.webkit.org/show_bug.cgi?id=75824 https://bugs.webkit.org/show_bug.cgi?id=75825 On Sun, Jan 8, 2012 at 6:44 PM, Benjamin Poulain benja...@webkit.org wrote: On Sun, Jan 8,

Re: [webkit-dev] Please set the svn:mime-type property on binary files before committing

2011-01-14 Thread Eric Seidel
Is this something we should have webkit-patch or the commit-queue do automatically? Does git (which the commit-queue uses) already do this? I'm happy to make such a change to webkit-patch land and the commit-queue if someone can tell me what needs to be done. (That should cover the 90% case