On Thu, Feb 28, 2019 at 12:40 PM Sam Weinig wrote:
>
>
> > On Feb 27, 2019, at 4:05 PM, Keith Rollin wrote:
> >
> >> On Wed, Feb 27, 2019 at 2:36 PM Michael Catanzaro <
> mcatanz...@igalia.com> wrote:
> >> Hi,
> >>
> >> For the past several years, I've been regularly fixing -Wformat
> >> warning
> On Feb 27, 2019, at 6:46 PM, Michael Catanzaro wrote:
>
> On Wed, Feb 27, 2019 at 6:05 PM, Keith Rollin wrote:
>> The underlying Cocoa os_log facility
>
> Yeah this is really interesting too. RELEASE_LOG is Cocoa-specific, because
> it's only backed by os_log. So when you change debug LOG
> On Feb 27, 2019, at 4:05 PM, Keith Rollin wrote:
>
>> On Wed, Feb 27, 2019 at 2:36 PM Michael Catanzaro
>> wrote:
>> Hi,
>>
>> For the past several years, I've been regularly fixing -Wformat
>> warnings that look like this:
>>
>> ../../Source/WebKit/WebProcess/WebPage/WebPage.cpp:3148:46
On Wed, Feb 27, 2019 at 6:05 PM, Keith Rollin wrote:
The underlying Cocoa os_log facility
Yeah this is really interesting too. RELEASE_LOG is Cocoa-specific,
because it's only backed by os_log. So when you change debug LOGs to
RELEASE_LOG, you're removing the logging for other platforms. I w
> On Wed, Feb 27, 2019 at 2:36 PM Michael Catanzaro
> wrote:
> Hi,
>
> For the past several years, I've been regularly fixing -Wformat
> warnings that look like this:
>
> ../../Source/WebKit/WebProcess/WebPage/WebPage.cpp:3148:46: warning:
> format ‘%llu’ expects argument of type ‘long long u
Or use LOG_WITH_STREAM() where I presume << pageID() << does the right thing.
We’d need some new RELEASE_LOG_ macros for that.
Simon
> On Feb 27, 2019, at 2:47 PM, Ryosuke Niwa wrote:
>
> We should probably stop using these formatting strings in favor of makeString
> by making *LOG* functions
Hello,
On a related note...
On Wed, 27 Feb 2019 16:35:39 -0600, Michael Catanzaro
wrote:
> For the past several years, I've been regularly fixing -Wformat
> warnings that look like this:
>
> ../../Source/WebKit/WebProcess/WebPage/WebPage.cpp:3148:46: warning:
> format ‘%llu’ expects argume
We should probably stop using these formatting strings in favor of
makeString by making *LOG* functions to use makeString behind the scene.
See https://trac.webkit.org/changeset/242014 for example.
- R. Niwa
On Wed, Feb 27, 2019 at 2:36 PM Michael Catanzaro
wrote:
> Hi,
>
> For the past severa
8 matches
Mail list logo