Re: [webkit-dev] Subpixel layout - requesting help for big rebaseline

2012-08-24 Thread Dominik Röttsches
Hi Dirk, On 08/22/2012 10:49 PM, Dirk Pranke wrote: The Chromium canaries now exit after 5000 failures or 1000 crashes/timeouts. Can the failure limit be increased to 1 for example? Levi/Emil were saying the rebaseline touches about 8000 cases. Otherwise we'd have to go through a more

Re: [webkit-dev] Subpixel layout - requesting help for big rebaseline

2012-08-24 Thread Žan Doberšek
On Fri, Aug 24, 2012 at 4:35 AM, Dominik Röttsches dominik.rottsc...@intel.com wrote: Hi Dirk, On 08/22/2012 10:49 PM, Dirk Pranke wrote: The Chromium canaries now exit after 5000 failures or 1000 crashes/timeouts. Can the failure limit be increased to 1 for example? Levi/Emil were

Re: [webkit-dev] Subpixel layout - requesting help for big rebaseline

2012-08-24 Thread Osztrogonac Csaba
You can mark the failing tests as failing tests or skip them in TestExpectations/Skipped with the change. And then you can rebase and unskip them without disturbing the bot. Dominik Röttsches írta: Hi Dirk, On 08/22/2012 10:49 PM, Dirk Pranke wrote: The Chromium canaries now exit after 5000

Re: [webkit-dev] Subpixel layout - requesting help for big rebaseline

2012-08-24 Thread Ojan Vafai
On Fri, Aug 24, 2012 at 4:42 AM, Žan Doberšek zandober...@gmail.com wrote: On Fri, Aug 24, 2012 at 4:35 AM, Dominik Röttsches dominik.rottsc...@intel.com wrote: Hi Dirk, On 08/22/2012 10:49 PM, Dirk Pranke wrote: The Chromium canaries now exit after 5000 failures or 1000

Re: [webkit-dev] Subpixel layout - requesting help for big rebaseline

2012-08-22 Thread Žan Doberšek
Perhaps one option of doing such a huge rebaseline might be the following: 1. Get the bots for the affected port into a green state. 2. Add temporary expectations for every LayoutTests/ subdirectory and perhaps for subdirectories of LayoutTests/fast, LayoutTests/svg and LayoutTests/editing as

Re: [webkit-dev] Subpixel layout - requesting help for big rebaseline

2012-08-22 Thread Dominik Röttsches
Hi, As another alternative, could we gather all the Chromium bot admins and ask them to temporarily take the bot offline in non-peak hours, create rebaselines per bot with the patch applied, collect those as binary-compatible diffs in one place, and manually land those collected baselines,

Re: [webkit-dev] Subpixel layout - requesting help for big rebaseline

2012-08-22 Thread Ojan Vafai
IIRC, the chromium bots no longer exit early due to a large number of failures (right Dirk?), only due to a large number of crashes/timeouts. So, it should be possible to commit this, wait for the bots to cycle, do all the rebaselines at once and commit that. The only delay is that we'd have to

Re: [webkit-dev] Subpixel layout - requesting help for big rebaseline

2012-08-22 Thread Dirk Pranke
The Chromium canaries now exit after 5000 failures or 1000 crashes/timeouts. Ideally we'd hold off on this change until we can get some sort of a fix or workaround to https://bugs.webkit.org/show_bug.cgi?id=94665 though (and I'm working on this today), or life might be annoyingly painful for us.