On Jul 24, 2009, at 2:18 PM, Darin Adler wrote:
On Jul 24, 2009, at 11:05 AM, Adam Barth wrote:
Do you have specific areas you're concerned about that we can be on
the lookout for?
I tried to think this through, but only had a few minutes free:
A minor concern is that Frame has a
On Fri, Jul 24, 2009 at 11:52 PM, Maciej Stachowiakm...@apple.com wrote:
I think that long-term we need to have a class to represent all the state of
a Frame that changes whenever the document changes. Right now the closest we
have to that is DocumentLoader, but it doesn't really hold all of
On Fri, Jul 24, 2009 at 10:07 AM, Darin Adlerda...@apple.com wrote:
On Jul 23, 2009, at 5:56 PM, Eric Seidel wrote:
It sounds like you agree with me, that the Document should have a way to
get to the JSDOMGlobalObject w/o having to go through the Frame. Am I
understanding correctly?
Yes,
Ok. I've filed:
https://bugs.webkit.org/show_bug.cgi?id=27640 -- about DOMWindow::document()
https://bugs.webkit.org/show_bug.cgi?id=27662 -- about document-globalObject()
For now I will reference those bugs in the places where the binding
code needs those calls.
On Fri, Jul 24, 2009 at 10:07
On Jul 24, 2009, at 11:05 AM, Adam Barth wrote:
Do you have specific areas you're concerned about that we can be on
the lookout for?
I tried to think this through, but only had a few minutes free:
A minor concern is that Frame has a constellation of helper classes to
help keep it simple,
Thanks. This is very helpful.
On Fri, Jul 24, 2009 at 1:18 PM, Darin Adlerda...@apple.com wrote:
On Jul 24, 2009, at 11:05 AM, Adam Barth wrote:
Do you have specific areas you're concerned about that we can be on the
lookout for?
I tried to think this through, but only had a few minutes
Yes, sorry to be confusing. I was attempting to provide examples of
how we currently go through the frame() every time we need the
JSDOMGlobalObject.
It sounds like you agree with me, that the Document should have a way
to get to the JSDOMGlobalObject w/o having to go through the Frame.
Am I
On Jul 23, 2009, at 5:23 PM, Eric Seidel wrote:
It seems all lookups of the current globalObject go through the frame.
document()-frame()-script()-globalObject() is one example.
Another:
JSValue toJS(ExecState*, DOMWindow* domWindow)
{
if (!domWindow)
return jsNull();
Frame*
I'm trying to get a JSDOMGlobalObject from a Node*. A Node* should
always have one, but our current path through Frame* can sometimes
fail.
-eric
On Thu, Jul 23, 2009 at 5:33 PM, Maciej Stachowiakm...@apple.com wrote:
On Jul 23, 2009, at 5:23 PM, Eric Seidel wrote:
It seems all lookups of
9 matches
Mail list logo
