Gopal,
A couple of comments.
Please change the Webrev comments to have the 'exact' bug synopsis
against all the files.
You could do a 'wx pbchk' to find errors
postinstall-ruby:
You could use another file name instead of just 'temp'. May be use
rbconfig.$$ or similar.
Other changes look
Hi Siva,
Have made the changes. Please review it again.
http://cr.opensolaris.org/~gs193864/cr6644643/
Thanks,
Gopal.
Sivakumar Shanmugasundaram wrote:
Gopal,
A couple of comments.
Please change the Webrev comments to have the 'exact' bug synopsis
against all the files.
You could do a
Gopal,
Looks good to me. I assume you have done 'wx pbchk' on your wokspace and
do not get any errors from this command.
Oh, I do not see Jyri's comments addressed. Please fix them. Add the
appropriate '#ident' and do 'wx redelget'
Siva
Gopalakrishnan Sankaran wrote:
Hi Siva,
Have made
Hi Siva, Jyri,
I have made the changes reqd (including the appropriate #ident). I ran
wx pbchk which returned no errors.
Kindly review the code changes.
http://cr.opensolaris.org/~gs193864/cr6644643/
Thanks,
Gopal.
Sivakumar Shanmugasundaram wrote:
Gopal,
Looks good to me. I assume you
Hi Sunanda,
Kindly review this bug and let me know your comments by April 8th
EOD .
Thanks Sunanda
Please review the code changes for CR 6664712 : mysql_config
provides
incorrect link library configuration.
at http://cr.opensolaris.org/~sunandam/6664712/
Thanks
This looks fine
+1
- Sriram
Basant Kukreja wrote:
Hi,
I have submitted the patch for the apache bug 42580.
https://issues.apache.org/bugzilla/show_bug.cgi?id=42580
This patch has been commited in Apache trunk. This is a solaris specific
bug. This has been reviewed by apr developers.
Gopalakrishnan Sankaran wrote:
Hi Siva, Jyri,
I have made the changes reqd (including the appropriate #ident). I ran
wx pbchk which returned no errors.
Kindly review the code changes.
http://cr.opensolaris.org/~gs193864/cr6644643/
Not sure if you saw my comment from Apr.4 but the
