Hi Siva, Have made the changes. Please review it again. http://cr.opensolaris.org/~gs193864/cr6644643/
Thanks, Gopal. Sivakumar Shanmugasundaram wrote: > Gopal, > > A couple of comments. > > Please change the Webrev comments to have the 'exact' bug synopsis > against all the files. > > You could do a 'wx pbchk' to find errors > > postinstall-ruby: > > You could use another file name instead of just 'temp'. May be use > rbconfig.$$ or similar. > > Other changes look good to me (wx pbchk - please). > > Siva > > > Gopalakrishnan Sankaran wrote: > >> Hi, >> >> Here is the webrev after making the changes required (as suggested in >> the initial round of review) >> Kindly review the changes. >> >> http://cr.opensolaris.org/~gs193864/cr6644643/ >> >> > _______________________________________________ > > > webstack-discuss mailing list > webstack-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/webstack-discuss > -- Thanks, Gopal http://blogs.sun.com/gkrish
