RE: [Webware-devel] Bad cookies hang Webkit

2001-10-05 Thread Jeff Johnson
> At 11:44 AM 10/1/2001 -0400, Geoff Talvola wrote: > >So, I'm thinking we should put this fixed version of > Cookie.py directly > >into Webware and force it to use its own fixed private copy > for any Python > >version prior to 2.2. Does anyone disagree? > > > >I suppose before we do that, w

RE: [Webware-devel] Bad cookies hang Webkit

2001-10-01 Thread Chuck Esterbrook
At 11:44 AM 10/1/2001 -0400, Geoff Talvola wrote: >So, I'm thinking we should put this fixed version of Cookie.py directly >into Webware and force it to use its own fixed private copy for any Python >version prior to 2.2. Does anyone disagree? > >I suppose before we do that, we should make sure

RE: [Webware-devel] Bad cookies hang Webkit

2001-10-01 Thread Love, Jay
OK. Does this seem to work for your test case? Jay > -Original Message- > From: Jeff Johnson [mailto:[EMAIL PROTECTED]] > Sent: Monday, October 01, 2001 10:40 AM > To: [EMAIL PROTECTED] > Subject: RE: [Webware-devel] Bad cookies hang Webkit > > > I checked

RE: [Webware-devel] Bad cookies hang Webkit

2001-10-01 Thread Geoff Talvola
So, I'm thinking we should put this fixed version of Cookie.py directly into Webware and force it to use its own fixed private copy for any Python version prior to 2.2. Does anyone disagree? I suppose before we do that, we should make sure that the fixed version is still compatible with Pytho

RE: [Webware-devel] Bad cookies hang Webkit

2001-10-01 Thread Jeff Johnson
# Any word or empty string r")" # End of group 'val' r"\s*;?" # Probably ending in a semi-colon ) > -Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]]On Behalf Of Ian &g

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-21 Thread Ian Bicking
as well. > > Thanks for tracking this down. > > Jay > > > -Original Message- > > From: Jeff Johnson [mailto:[EMAIL PROTECTED]] > > Sent: Thursday, September 20, 2001 6:16 PM > > To: Geoff Talvola; Love, Jay; [EMAIL PROTECTED] > > Subject: RE: [We

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-21 Thread Love, Jay
20, 2001 6:16 PM > To: Geoff Talvola; Love, Jay; [EMAIL PROTECTED] > Subject: RE: [Webware-devel] Bad cookies hang Webkit > > > Since I'm going on vacation as soon as I fix this problem, I > decided I'd better try again. I didn't write the crappy > cookie w

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-20 Thread Jeff Johnson
ot;+ _LegalCharsPattValue +""# Any word r")" # End of group 'val' r"\s*;?" # Probably ending in a semi-colon ) > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROT

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-20 Thread Jeff Johnson
Well, I found the person with the bad cookies. The offending cookie is has two equal signs in it! Is that legal?? "WWWLYCOS=SATISFACTIONSURVEY=N;" Does anyone have a suggestion of how we can handle this exception gracefully or improve the parser? I printed out the offending cookie and the exc

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-13 Thread Geoff Talvola
At 11:10 AM 9/13/01 -0400, Jeff Johnson wrote: >Ok, here's the diffs. The only other change than the two exception >handlers is a print "." that somehow fixes the FreeBSD restart problem. I checked in your diffs to CVS with minor changes (comments and added "import sys" to one module). -- -

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-13 Thread Jeff Johnson
Ok, here's the diffs. The only other change than the two exception handlers is a print "." that somehow fixes the FreeBSD restart problem. Thanks, Jeff > At 10:04 AM 9/13/01 -0400, Jeff Johnson wrote: > >I had forgotten about this until last night when someone > with (I assume) > >corrupted

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-13 Thread Geoff Talvola
At 10:04 AM 9/13/01 -0400, Jeff Johnson wrote: >I had forgotten about this until last night when someone with (I assume) >corrupted cookies hung WebKit again by killing off all the threads. Can >we have two exception handlers? One to catch corrupted cookies and >another to prevent unexpected exc

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-13 Thread Jeff Johnson
vola'; Jeff Johnson; [EMAIL PROTECTED] > Subject: RE: [Webware-devel] Bad cookies hang Webkit > > > Yeah, a try: except: around handleRequest would catch a lot of this, I > THINK, but it makes me a little nervous to do a catch that > big. It just > seems a little cludgy. But

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-04 Thread Geoff Talvola
At 04:46 PM 9/4/01 -0500, Love, Jay wrote: >Yeah, a try: except: around handleRequest would catch a lot of this, I >THINK, but it makes me a little nervous to do a catch that big. It just >seems a little cludgy. But I guess as long as the except logs the error >somehow (just print to stdout), its

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-04 Thread Love, Jay
t any of this, but why was that particular exception hanging the thread? Jay > -Original Message- > From: Geoff Talvola [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, September 04, 2001 5:35 PM > To: Jeff Johnson; [EMAIL PROTECTED] > Subject: RE: [Webware-devel] Bad cookies ha

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-04 Thread Geoff Talvola
At 05:00 PM 9/4/01 -0400, Jeff Johnson wrote: >I guess there's a bug in Cookie.py but shouldn't AppServer be more >robust? A bug like this should cause an error page (which it does) but >it shouldn't be able to hang the entire WebKit server. If we put a >try/except around handleRequest would tha

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-04 Thread Jeff Johnson
I guess there's a bug in Cookie.py but shouldn't AppServer be more robust? A bug like this should cause an error page (which it does) but it shouldn't be able to hang the entire WebKit server. If we put a try/except around handleRequest would that make it harder for bad servlet code to hang the

Re: [Webware-devel] Bad cookies hang Webkit

2001-09-04 Thread Geoff Talvola
At 03:16 PM 9/4/01 -0400, Jeff Johnson wrote: >Someone hitting my site must have a bad cookie and when the Cookie >parser fails, the thread just hangs. Once all threads are hung the site >stops responding. I don't know the code well enought to know where to >put the try/except but I think there

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-04 Thread Jeff Johnson
except: pass thanks Jay :) > -Original Message- > From: Love, Jay [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, September 04, 2001 3:32 PM > To: Jeff Johnson; [EMAIL PROTECTED] > Subject: RE: [Webware-devel] Bad cookies hang Webkit &

RE: [Webware-devel] Bad cookies hang Webkit

2001-09-04 Thread Love, Jay
As just a quick fix, I'd wrap the call to Cookie.load in HTTPRequest. Jay > -Original Message- > From: Jeff Johnson [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, September 04, 2001 3:17 PM > To: [EMAIL PROTECTED] > Subject: [Webware-devel] Bad cookies hang Webkit >

[Webware-devel] Bad cookies hang Webkit

2001-09-04 Thread Jeff Johnson
Someone hitting my site must have a bad cookie and when the Cookie parser fails, the thread just hangs. Once all threads are hung the site stops responding. I don't know the code well enought to know where to put the try/except but I think there should be a general try/except around handleReques