Re: Unifying Windows Makefiles

2005-07-08 Thread Hrvoje Niksic
Gisle Vanem <[EMAIL PROTECTED]> writes: > "Hrvoje Niksic" wrote: > >> Wouldn't you need to have separate targets for linking as well? > > Sure. That target would simply depend on $(MSVC_OBJECTS) etc.: > > wget-msvc.exe: $(MSVC_OBJECTS) > link $(MSVC_LDFLAGS) -out:$@ $^ $(MSVC_EXT_LIBS) Person

Re: Unifying Windows Makefiles

2005-07-08 Thread Gisle Vanem
"Hrvoje Niksic" wrote: Wouldn't you need to have separate targets for linking as well? Sure. That target would simply depend on $(MSVC_OBJECTS) etc.: wget-msvc.exe: $(MSVC_OBJECTS) link $(MSVC_LDFLAGS) -out:$@ $^ $(MSVC_EXT_LIBS) Possibly with an extra "mv -f $@ $(INSTALL_DIR)/wget.exe".

Re: Unifying Windows Makefiles

2005-07-08 Thread Hrvoje Niksic
Gisle Vanem <[EMAIL PROTECTED]> writes: > If you adopt this style, I urge you to reconsider the "#undef > HAVE_OPENSSL" in config.h. You're right; I never thought through the effect of the #undef lines on symbols defined via Makefile! configure-generated config.h has the undefs commented out, pr

RE: Unifying Windows Makefiles

2005-07-08 Thread Herold Heiko
From: Hrvoje Niksic [mailto:[EMAIL PROTECTED] > > Herold Heiko <[EMAIL PROTECTED]> writes: > > > What about the doc directory and Makefile.doc ? > > I don't see much use for Info files on Windows. Furthermore, I don't > think many Windows builders have makeinfo lying around on their hard > disk

Re: Unifying Windows Makefiles

2005-07-08 Thread Gisle Vanem
MSVC_OBJECTS = $(addprefix MSVC_obj/, $(SOURCE)) MINGW_OBJECTS = $(addprefix MingW_obj/, $(SOURCE)) Should off course be: MSVC_OBJECTS = $(addprefix MSVC_obj/, $(SOURCE:.c=.obj)) MINGW_OBJECTS = $(addprefix MingW_obj/, $(SOURCE:.c=.o)) MingW_obj/%.obj: %.c gcc -c $(MINGW_CFLAGS) -o $@ $<

Re: Unifying Windows Makefiles

2005-07-08 Thread Gisle Vanem
"Hrvoje Niksic" wrote: 3. Add the redundant #ifdefs to all compilation-dependent C files to make sure that they are ignored when the libraries they require are missing. For example, openssl.c should be wrapped in #ifdef HAVE_OPENSSL. So should http-ntlm.c. But using GNU make it's prett

Re: Unifying Windows Makefiles

2005-07-08 Thread Hrvoje Niksic
Herold Heiko <[EMAIL PROTECTED]> writes: > What about the doc directory and Makefile.doc ? I don't see much use for Info files on Windows. Furthermore, I don't think many Windows builders have makeinfo lying around on their hard disk... Those who know about Info (or, for that matter, Texinfo) d

RE: Unifying Windows Makefiles

2005-07-08 Thread Herold Heiko
From: Hrvoje Niksic [mailto:[EMAIL PROTECTED] > 2. Get rid of top-level Windows Makefiles. The src directory is the >only one that really matters anyway, and configure.bat can easily >instruct the user to cd to "src" before typing `make'. The benefit >is that we'd get rid of the ugly