Re: [Wicket-user] wicket:id on body tag

2005-11-24 Thread Juergen Donnerstag
Thanks Scott. I'll have a look into it tonight (10 hours from now). Juergen On 11/24/05, Scott Sauyet [EMAIL PROTECTED] wrote: Juergen Donnerstag wrote: I don't know if my use-case is enough of a reason to clutter up the interface of WebPage. I also don't know if there is a reason to widen

Re: [Wicket-user] wicket:id on body tag

2005-11-23 Thread Scott Sauyet
== Scott Sauyet [EMAIL PROTECTED] == Juergen Donnerstag [EMAIL PROTECTED] Could someone point me to where in the source code this happens? I don't really know my way around Wicket internals yet, but I'd like to see this, and it's not in WebPage, which was my first guess.

Re: [Wicket-user] wicket:id on body tag

2005-11-23 Thread Scott Sauyet
== Juergen Donnerstag [EMAIL PROTECTED] == Scott Sauyet [EMAIL PROTECTED] RFE: allow wicket:id on body tag which currently is not possible due to wickets body onLoad handling. Okay. It's at http://tinyurl.com/7azmc [ ... ] I'll look to see if I can create a patch for this. Okay, a patch

Re: [Wicket-user] wicket:id on body tag

2005-11-23 Thread Juergen Donnerstag
Okay, a patch is attached that modifies WebPage and BodyOnloadContainer. It's a suggestion for something less than the wicket:id on the body tag. It simply adds public void addBodyAttributeModifier(AttributeModifier modifier) to WebPage, so that you can do, for instance,

Re: [Wicket-user] wicket:id on body tag

2005-11-23 Thread Scott Sauyet
I don't know if my use-case is enough of a reason to clutter up the interface of WebPage. I also don't know if there is a reason to widen this facility beyond adding AttributeModifiers. But for what it's worth, here is my simple suggestion. Honestly, I'm not in favour of cluttering the

Re: [Wicket-user] wicket:id on body tag

2005-11-23 Thread Scott Sauyet
Juergen Donnerstag wrote: I don't know if my use-case is enough of a reason to clutter up the interface of WebPage. I also don't know if there is a reason to widen this facility beyond adding AttributeModifiers. But for what it's worth, here is my simple suggestion. Honestly, I'm not in

[Wicket-user] wicket:id on body tag

2005-11-22 Thread Scott Sauyet
Why does the BODY allow an unused wicket:id attribute? I was trying to implement an enhancement to my markup-inheritance-based pages to add a class attribute to the body tag in order to make it a little easier to apply my CSS. I added 'wicket:id=body' to the body tag, and started adding a

Re: [Wicket-user] wicket:id on body tag

2005-11-22 Thread Juergen Donnerstag
It all has to do with wicket:head and panels being able to contribute body onLoad=xxx attributes to the page. In order to support that feature, a webmarkupcontainer is automatically created and associated with the body tag of the page (in case of an exception, on the exception page you can see a

Re: [Wicket-user] wicket:id on body tag

2005-11-22 Thread Scott Sauyet
== Scott Sauyet [EMAIL PROTECTED] == Juergen Donnerstag [EMAIL PROTECTED] Thanks for the info, Juergen. So my first question is why don't I get an exception when there is a wicket:id attribute on the BODY tag and no corresponding Component on the Page? It all has to do with wicket:head

Re: [Wicket-user] wicket:id on body tag

2005-11-22 Thread Juergen Donnerstag
On 11/22/05, Scott Sauyet [EMAIL PROTECTED] wrote: == Scott Sauyet [EMAIL PROTECTED] == Juergen Donnerstag [EMAIL PROTECTED] Thanks for the info, Juergen. So my first question is why don't I get an exception when there is a wicket:id attribute on the BODY tag and no corresponding