Most users, probably except the core developers and a few other users,
are using wicket.jar. Replying n/a if not using the jar is ok for
me. And as long as unit tests don't suffer, and I think they don't,
than
+1 for MANIFEST.MF
Juergen
On 4/13/06, Gwyn Evans [EMAIL PROTECTED] wrote:
Anyone
Other than the ApplicationSettingsTest.testFrameworkVersion test that does
assertFalse(n/a.equalsIgnoreCase(settings.getVersion()));
they seem unaffected.
/Gwyn
On 13/04/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:
Most users, probably except the core developers and a few other users,
are
Anyone for or against this?
Pro: Will provide the version from the MANIFEST.MF in the jar file.
Con: Only provides the correct value when Wicket is running from a JAR.
/Gwyn
On 31/03/06, Gwyn Evans [EMAIL PROTECTED] wrote:
I suspected that might be the case with the test - could investigate
This will not work in unit tests, as there is no META-INF/manifest available. That would mean removing the unit test altogether.Also, I just read on the dev list that class.forName() is frowned upon, because of classloader issues.
MartijnOn 3/31/06, Gwyn Evans [EMAIL PROTECTED] wrote:
Maven
I suspected that might be the case with the test - could investigate
running a subset of tests on the jar after it's built, but is it worth
it?
I didn't think that Class.forName would be an issue, as it was being
called from a Wicket class itself, but taking that further, as it's
running within a
Çäðàâñòâóéòå, Gwyn.
Âû ïèñàëè 31 ìàðòà 2006 ã., 3:57:26:
I thought we were going to be reading this from the MANIFEST.MF in the
wicket jar?
/Gwyn
A while back I provided an example how one can read version and other
information from jar file's manifest.
IMHO, the version information should
Çäðàâñòâóéòå, Gwyn.
Âû ïèñàëè 31 ìàðòà 2006 ã., 3:57:26:
I thought we were going to be reading this from the MANIFEST.MF in the
wicket jar?
/Gwyn
A while back I provided an example how one can read version and other
information from jar file's manifest.
IMHO, the version information should
Çäðàâñòâóéòå, Gwyn.
Âû ïèñàëè 31 ìàðòà 2006 ã., 3:57:26:
I thought we were going to be reading this from the MANIFEST.MF in the
wicket jar?
/Gwyn
A while back I provided an example how one can read version and other
information from jar file's manifest.
IMHO, the version information should
that we also goed do but who is generating that manifest.mf?And we are then depending on that a Package is made. And according to the spec a Package object doesn't have to be made.johan
On 3/31/06, shumbola [EMAIL PROTECTED] wrote:
Здравствуйте, Gwyn.Вы писали 31 марта 2006 г., 3:57:26: I thought