The proposal to merge lp:~widelands-dev/widelands/findpath_modification into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/findpath_modification/+merge/337103
--
Your team Widelands Develop
Review: Approve
Yes, that looks good. Thanks! :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/findpath_modification/+merge/337103
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/findpath_modification.
next try please :)
--
https://code.launchpad.net/~widelands-dev/widelands/findpath_modification/+merge/337103
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/findpath_modification.
___
Mailing list:
I replied in the diff.
Maybe you need a different tutorial, or to sit down with somebody to teach you.
That tutorial is maybe too abstract, and you need some exercises to go along
with it? Or maybe what's confusing you here is the combination of pointers and
object orientation?
Diff comments:
see comment in diff
I know the link with tutorial - very well. If it is about integers I somehow
understand it, but objects or std containers are too confusing to me. I know, I
should try harder ;)
Diff comments:
>
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc
Continuous integration builds have changed state:
Travis build 3176. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/340855844.
Appveyor build 2990. State: success. Details:
> Also see comment in the code...
Comment looks good, can you please add it to the code?
Regarding pointers and references, they are an important feature of C++, so if
you can find the time to read up on them, it will be time well spent. Here's a
tutorial:
Appveyor is not able to parallel build x64 Debug due to memory constraints on
Appveyor (see build times for every job: x86 release/debug + x64 release builds
are taking ~30 minutes, x64 debug takes ~90 minutes.)
But now in this branch we also hit the time limit of 120 minutes with the x64
I am not sure what appveyor problem exactly is...
--
https://code.launchpad.net/~widelands-dev/widelands/findpath_modification/+merge/337103
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/findpath_modification.
___
Continuous integration builds have changed state:
Travis build 3176. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/340855844.
Appveyor build 2983. State: failed. Details:
I am hopelessly lost in regard to pointers and references and I am afraid it
will never get better.
Also see comment in the code...
Diff comments:
>
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc 2018-02-12 11:43:28 +
> +++ src/ai/defaultai.cc 2018-02-13
The constructor failed because you were initializing with a reference in the
other constructor. I have changed that to a pointer, since the object has a
pointer internally anyway.
For the loop, it's not clear to me how the loop above the end condition
actually ensures that eventually there's
Gun,
your suggestion about NearFlag constructor is failing with:
no matching function for call to ‘Widelands::NearFlag::NearFlag(std::nullptr_t,
int)’
Also in regard to (;;) I changed a comment few lines bellow it to be obvious
where the looping ends:
"OK, so no NearFlag left to be checked -
Various small code style nits. There is 1 loop that I'm worried about - can you
please revisit the code there and add an explicit break condition, and/or a
comment?
Diff comments:
> === modified file 'src/ai/ai_help_structs.cc'
> --- src/ai/ai_help_structs.cc 2017-11-24 09:19:52 +
> +++
Review: Resubmit
OK, ready for testing
--
https://code.launchpad.net/~widelands-dev/widelands/findpath_modification/+merge/337103
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/findpath_modification.
___
Mailing
/_widelands_dev_widelands_findpath_modification-2965.
--
https://code.launchpad.net/~widelands-dev/widelands/findpath_modification/+merge/337103
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/findpath_modification into lp:widelands
/_widelands_dev_widelands_findpath_modification-2951.
--
https://code.launchpad.net/~widelands-dev/widelands/findpath_modification/+merge/337103
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/findpath_modification into lp:widelands
/_widelands_dev_widelands_findpath_modification-2949.
--
https://code.launchpad.net/~widelands-dev/widelands/findpath_modification/+merge/337103
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/findpath_modification into lp:widelands
wait a bit, I am doing further modification to the code..
--
https://code.launchpad.net/~widelands-dev/widelands/findpath_modification/+merge/337103
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/findpath_modification into lp:widelands
/_widelands_dev_widelands_findpath_modification-2943.
--
https://code.launchpad.net/~widelands-dev/widelands/findpath_modification/+merge/337103
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/findpath_modification into lp:widelands
/_widelands_dev_widelands_findpath_modification-2939.
--
https://code.launchpad.net/~widelands-dev/widelands/findpath_modification/+merge/337103
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/findpath_modification into lp:widelands
/_widelands_dev_widelands_findpath_modification-2937.
--
https://code.launchpad.net/~widelands-dev/widelands/findpath_modification/+merge/337103
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/findpath_modification into lp:widelands
is requested to review the proposed merge of
lp:~widelands-dev/widelands/findpath_modification into lp:widelands.
=== modified file 'src/ai/ai_help_structs.cc'
--- src/ai/ai_help_structs.cc 2017-11-24 09:19:52 +
+++ src/ai/ai_help_structs.cc 2018-02-02 22:36:27 +
@@ -191,8 +191,15 @@
return false
23 matches
Mail list logo
