@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/savegame-menu.
___
Mailing list:
The proposal to merge lp:~widelands-dev/widelands/savegame-menu into
lp:widelands has been updated.
Commit Message changed to:
Refactored load- and savegame screens. Cleaned up file system constants. Save
options immediately.
- New common class GameDetails to show information about savegames
Error merging this proposal:
Output:
stdout:
stderr:
bzr: ERROR: Parameter 'Merged
lp:~widelands-dev/widelands/savegame-menu:\nRefactored load- and savegame
screens. Cleaned up file system constants. Save options immediately.\n\n- New
common class GameDetails to show information about
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/savegame-menu.
___
Mailing list:
Continuous integration builds have changed state:
Travis build 2772. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/297912877.
Appveyor build 2584. State: success. Details:
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 2772. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/297912877.
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/savegame-menu.
___
Mailing list: https://launchpad.net/~widelands-dev
Thanks for pointing that out - fixed by adding a dummy file.
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/savegame-menu.
___
If I interpret the Travis output right, it is complaining about the cmake
library liblogic_constants. Wasn't there something that header-only libraries
do not work? Might be the problem here, it only contains widelands.h.
--
Continuous integration builds have changed state:
Travis build 2770. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/297682919.
Appveyor build 2582. State: success. Details:
Review: Approve commit diff and short test
Code looks good and compiling & starting games works. As far as I am concerned,
this branch can be merged.
I guess filesystem_constants is a good enough name for the file. After all,
that is what it contains.
--
OK, everything should be addressed now.
I renamed logic/constants.h to logic/filesystem_constants.h, because I couldn't
think of a better place to put them. I moved the statistics sample time
constant out into game.h.
--
We're trying to keep the base directory as free as possible. How about putting
them in src/io, since it's all filesystem stuff? Not entirely happy with that
though, since it's all widelands-specific, and io is widelands-agnostic.
kStatisticsSampleTime could be moved to logic/game.h, since it's
Review: Needs Fixing
I only looked at the commit-diffs, but the changes are mostly fine with me,
thanks.
However, there are two problems:
- Codecheck complains about wrong include order in logic/game.cc
- For me, it does not compile. Strangely, Travis seems to be happy with the
code. The
Continuous integration builds have changed state:
Travis build 2758. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/297334121.
Appveyor build 2570. State: failed. Details:
The proposal to merge lp:~widelands-dev/widelands/savegame-menu into
lp:widelands has been updated.
Commit Message changed to:
Refactored load- and savegame screens. Cleaned up file system constants. Save
options immediately.
- New common class GameDetails to show information about savegames
Review: Resubmit
This is now ready again, the crash is gone.
I added the things I couldn't solve right now as TODO comments to the code -
those are wider issues with the UI toolbox that are already in trunk.
I also cleaned up the file system constants, because it was really annoying me.
The proposal to merge lp:~widelands-dev/widelands/savegame-menu into
lp:widelands has been updated.
Commit Message changed to:
Refactored load- and savegame screens. Cleaned up file system constants.
- New common class GameDetails to show information about savegames,
analogous to MapDetails
Answered the diff comments, I'm still waiting for the compiler for the fixes.
Will have a look at the bugs after that.
Diff comments:
> === modified file 'src/game_io/game_preload_packet.cc'
> --- src/game_io/game_preload_packet.cc2017-08-17 15:34:45 +
> +++
I have been testing the branch and today got it crash.
This is how it crashes:
Single Player
New Game
Click Crater and then OK
Start game
Main Menu
Save Game
Write some Filename and then OK
Main Menu
Exit Game
OK
Watch Replay
Choose the saved game and then OK
Wait until the end of replay and
Thanks for the detailed review :)
This will need some TLC from a real machine, so I'll take care of this one when
I'm back home.
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is subscribed to branch
Review: Needs Fixing
I did a round of code diff review and a bit of testing. The code looks good to
me, just some small remarks. I haven't retraced the whole refactoring process,
but it seems to be okay.
However, there are some issues with the removal of save games:
- Just a suggestion: After
Continuous integration builds have changed state:
Travis build 2393. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/247862613.
Appveyor build 2221. State: success. Details:
Review: Approve testing
Opened all menus and all looks good to me :-)
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/savegame-menu.
Had a quick look and it LGTM :-)
Don't know if this related to your changes:
- Fullscreen toggling does not work for the save game menu, as well for Editor
Load/Save map menu. But for me this is ok.
- I have some incompatible maps showing an Error message. Hovering with the
mouse over the
Continuous integration builds have changed state:
Travis build 2219. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/234259921.
Appveyor build 2054. State: success. Details:
Continuous integration builds have changed state:
Travis build 2217. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/234039655.
Appveyor build 2052. State: success. Details:
Review: Resubmit
I have implemented all your suggestions except for the colors, and it looks
much better now :)
The color scheme is as follows:
Fullscreen menu text: Yellow, bold headers/variable names. Grey, bold
paragraph-level texts. Due to the background images, all texts have to be bold
the table. I liked
that...
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/savegame-menu into lp:widelands.
___
Ma
shorter that would be
visually pleasing - ideas?
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/savegame-menu into lp:widelands
elopers is requested to review the proposed merge of
lp:~widelands-dev/widelands/savegame-menu into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~wid
/_widelands_dev_widelands_savegame_menu-1937.
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/savegame-menu into lp:widelands.
___
Mailing list
/322924
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/savegame-menu into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
/_widelands_dev_widelands_savegame_menu-1934.
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/savegame-menu into lp:widelands.
___
Mailing list
see:
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Complete overhaul of Load Game, Watch Replay and Save Game screens
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/savegame-menu into lp:widelands.
=== modified
35 matches
Mail list logo
