You're welcome :)
I wanted it for Widelands, so why not have it for the website as well. You made
me aware of pyformat in the first place!
--
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Your team Widelands Developers is subscribed to branch
Merged with trunk, ran the script, merged into trunk, deployed.
Thanks for the tool :-)
--
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Your team Widelands Developers is subscribed to branch lp:widelands-website.
The proposal to merge lp:~widelands-dev/widelands-website/pyformat_util into
lp:widelands-website has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
--
Your team Widela
Thanks for the nit - fixed :)
--
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Review: Approve
same nit as kaputtnik had, otherwise lgtm.
Diff comments:
> === added file '_ops/fix_formatting.py'
> --- _ops/fix_formatting.py1970-01-01 00:00:00 +
> +++ _ops/fix_formatting.py2016-12-07 11:00:51 +
> @@ -0,0 +1,48 @@
> +#!/usr/bin/env python
> +# -*- coding:
Review: Approve
Runs with python3 and python2 now. :-)
I don't know why the PYTHON3=... is still in there? Maybe i miss something here?
--
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Your team Widelands Developers is subscribed to branch
OK, moved :)
--
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands-website/pyformat_util into lp:widelands-website
to review the proposed merge of
lp:~widelands-dev/widelands-website/pyformat_util into lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands
)
> +
Thanks, will fix.
> +print 'Formatting finished.'
> +return 0
> +
> +if __name__ == '__main__':
> +sys.exit(main())
--
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Your team Widelands Developers is requested to review the
Ah, forgotton: Wouldn't it be better to have this script in the _ops directory?
--
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands-website/pyformat_util
wing print through an error when running with python3... missing
parentheses.
> +print 'Formatting finished.'
> +return 0
> +
> +if __name__ == '__main__':
> +sys.exit(main())
--
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Your team
to run pyformat over the code base.
In the future, when merging branches into trunk, this could be run before the
bzr commit.
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands-website/pyformat_util into lp:widelands-website.
=== added
12 matches
Mail list logo
