Yes, I'd liker to hear your suggestions :)
Thanks for testing again!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/add_custom_building/+merge/334062
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/add_custom_building.
Review: Approve
Did a complete test of the empire 4 scenario ans some other test regarding the
trainingsites_max_percent value. Also had a look to the code. The branch now
handles the value in a way that it will not crash anymore. The scenario ran
through without any observations. So I would
@Gun,I somehow believed that this is part of AI hints - that way there would be
no problem with same building across multiple tribes...
I just want to emphasize that any sum > 100% is fine, no big harm would be
done. Only if sum < 100% can cause problem.
--
ok I'll change my branch after this one has gone into trunk then. What zip file
(which content)do you want me to upload?
--
https://code.launchpad.net/~widelands-dev/widelands/add_custom_building/+merge/334062
Your team Widelands Developers is subscribed to branch
@hessenfarmer: Let's keep your scenario separate, because it hasn't been
reviewed yet and the strings would land on Transifex, causing extra work for
the translators. It would be great if you could upload a zip to a bug though,
then I could use it to help add a test to out test suite.
I hope it's fixed now, could you please test again with the values that caused
the exception?
--
https://code.launchpad.net/~widelands-dev/widelands/add_custom_building/+merge/334062
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/add_custom_building.
If you allow less then 100%, the result will be that AI will build one
trainingsite of each type and never more.. this is mathematics...
Further trainingsits are built only if current ratio of this type vs all
trainingsites is < this percentage
--
Review: Needs Fixing
Ok tested it,
found a bug in postload_calculate_trainingsites_proportions():
in the data only the value for an empire_arena is defined with 20%. With my
additional custom trainingcamp there were 3 remaining sites (colosseum,
Trainincamp and custom trainingcamp). They got
Ok I'd like to propose the following:
1. will download the branch
2. will download the related appveyor build
3. will integrate the last verion of emp04 scenario.
4. test it and report back
5. if succesful we just need to merge this branch to have everything ready.
would this be ok
--
9 matches
Mail list logo
