Fixed in trunk.
--
https://code.launchpad.net/~widelands-dev/widelands/animation_scaling/+merge/310718
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/animation_scaling.
___
Mailing list:
It seems like this broke Travis. Gun, are you looking into this?
--
https://code.launchpad.net/~widelands-dev/widelands/animation_scaling/+merge/310718
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/animation_scaling.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/animation_scaling/+merge/310718
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/animation_scaling.
___
Mailing list:
Review: Approve
height(): ack.
the other answered inline.
Diff comments:
>
> === modified file 'src/graphic/animation.h'
> --- src/graphic/animation.h 2016-10-25 08:14:28 +
> +++ src/graphic/animation.h 2016-11-18 17:52:33 +
> @@ -57,8 +58,17 @@
> }
>
> /// The
Yep, I'm not really happy with it either, but I don't have a better idea.
I added 2 replies to your comment, please have a look.
Diff comments:
>
> === modified file 'src/graphic/animation.h'
> --- src/graphic/animation.h 2016-10-25 08:14:28 +
> +++ src/graphic/animation.h 2016-11-18
Review: Approve
some minor nits in the code.
This is way better encapsulated than before, but it still does not make me all
warm and fuzzy inside - it feels weird that the animation passes out its
calculated source rect, just to get it back in the blitting call. I do not have
any more
Review: Resubmit
Refactoring done, please have another look.
- Moved all the sizing and positioning calculations into the animation class.
- get_width() and hotspot() are gone.
- get_height() is still used by the soldiers to position their health bar etc.
- We now have source_rectangle and
> I'd like to finish the spritemaps first though.
agreed.
> I also think it will only be worth our effort once we have the bigger
> textures exported from Blender.
No, I think the benefits will be immediately visible once you use downscaled
textures. It just looks better.
>
Review: Resubmit
Good idea about the mipmaps - I'd like to finish the spritemaps first though. I
also think it will only be worth our effort once we have the bigger textures
exported from Blender.
The representative_image in Lua is indeed needed for the font renderers. I
really don't want to
This feels a bit messy. The scale of an animation must now be publicly knowable
on the outside for doing math on it, though it feels like it should be a purely
internal information. Can this not be internalized somehow by changing the
animations interface?
Also, if you want bigger images to
This looks very promising!
--
https://code.launchpad.net/~widelands-dev/widelands/animation_scaling/+merge/310718
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/animation_scaling into lp:widelands.
11 matches
Mail list logo
