Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/AI-fixes into lp:widelands

2019-05-17 Thread hessenfarmer
@ GunChleoc: I forgot to mention that I am pretty sure no matter what precautions we might take a new tribe would lead us to have some changes in Ai as well, as me and my crystal bowl can't foresee every issue that might arise. ;-) In fact I was led to the current improvements only by the need

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start into lp:widelands

2019-05-17 Thread GunChleoc
How abut calling the "Back" button "Leave Lobby" rather than "Log Out"? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start/+merge/367320 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands

2019-05-17 Thread GunChleoc
Yep, translating the empty string is a bad idea. Dropdowns, table and listselect entries have 2 data elements - one is the actual data (Entry value), the other one is a translatable label (const std::string& name). You need to compare the actual data, not the translatable label. void

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/AI-fixes into lp:widelands

2019-05-17 Thread GunChleoc
Of course, there will always be things that we haven't thought of. And having too many hard-coded things already does not count as an argument in favor of adding even more of them. The additional code needed wouldn't be that much, it's just a matter of adding 1 more property to the worker

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/constructionsite_options into lp:widelands

2019-05-17 Thread bunnybot
Continuous integration builds have changed state: Travis build 5003. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/533470509. Appveyor build 4784. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start into lp:widelands

2019-05-17 Thread GunChleoc
Buttons use Title Case, so: Online Game Online Game Settings -- https://code.launchpad.net/~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start/+merge/367320 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1825932-open-games-clean-start.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/AI-fixes into lp:widelands

2019-05-17 Thread hessenfarmer
For my understanding it is not only that but we should discuss this in the bug report. -- https://code.launchpad.net/~widelands-dev/widelands/AI-fixes/+merge/367309 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/AI-fixes.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/overlapping_workareas into lp:widelands

2019-05-17 Thread Benedikt Straub
A transient travis failure @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/overlapping_workareas/+merge/366623 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/overlapping_workareas. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/overlapping_workareas into lp:widelands

2019-05-17 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/overlapping_workareas into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/overlapping_workareas/+merge/366623 -- Your team Widelands Developers is

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/AI-fixes into lp:widelands

2019-05-17 Thread hessenfarmer
@GunChleoc: I will do so, however the 2 buildings (barracks, second carrier) are so special, we would need a lot of code to come to the same results (1 barracks, 2 carrier). We also have a lot of other hardcoded stuff regarding these two. But basically the AI just needs to ensure it builds a

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/choose-attack-soldiers into lp:widelands

2019-05-17 Thread GunChleoc
The vertical size not being fixed is a problem - the attack box can start jumping up and down. -- https://code.launchpad.net/~widelands-dev/widelands/choose-attack-soldiers/+merge/367471 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/choose-attack-soldiers.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start into lp:widelands

2019-05-17 Thread Toni Förster
The proposal to merge lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start into lp:widelands has been updated. Commit message changed to: redesigned login box - renamed to Online game Settings - limit the possible characters for usernames - draw a red box around the input

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/AI-fixes into lp:widelands

2019-05-17 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/AI-fixes into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/AI-fixes/+merge/367309 -- Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start into lp:widelands

2019-05-17 Thread kaputtnik
Review: Needs Fixing Hm, there is some inconsistency and an assertion: 1. Start widelands 2. Set a wrong password -> No hint about wrong password -> Login dialog closes 3. Trying to get into the lobby shows now a warning -> Loginbox appear 4. Set a wrong password again -> now the warning appears

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/gaming_password into lp:widelands-website

2019-05-17 Thread noreply
The proposal to merge lp:~widelands-dev/widelands-website/gaming_password into lp:widelands-website has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands-website/gaming_password/+merge/367448 -- Your team Widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/gaming_password into lp:widelands-website

2019-05-17 Thread kaputtnik
Thanks, merged and deployed. -- https://code.launchpad.net/~widelands-dev/widelands-website/gaming_password/+merge/367448 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1818013-new-logo into lp:widelands

2019-05-17 Thread bunnybot
Continuous integration builds have changed state: Travis build 5008. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/533694061. Appveyor build 4789. State: success. Details: