Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786597-test-suite into lp:widelands

2018-08-12 Thread GunChleoc
I tried to add https://bugs.launchpad.net/widelands/+bug/1535115/comments/33 into the compatibility code but it broke the test suite again, so I used the branch to update the mapobjectpacket in the problematic test scenario and removed the savegame compatibility. --

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786163 into lp:widelands

2018-08-12 Thread TiborB
TiborB has proposed merging lp:~widelands-dev/widelands/bug-1786163 into lp:widelands. Commit message: When AI finds a second ship in expedition - it cancels the expedition. AI is written to control only one expedition at once. Requested reviews: Widelands Developers (widelands-dev) For

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app into lp:widelands

2018-08-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 3778. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/415248260. Appveyor build 3577. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app into lp:widelands

2018-08-12 Thread Toni Förster
Toni Förster has proposed merging lp:~widelands-dev/widelands/macos_build_app into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/macos_build_app/+merge/352945 -- Your team Widelands Developers

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands

2018-08-12 Thread Toni Förster
Review: Approve Works for me. Tested on macOS 10.13. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1785404-chat-scrolling/+merge/352941 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1785404-chat-scrolling.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1783878_editor_random_map_tribe into lp:widelands

2018-08-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 3777. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/415165379. Appveyor build 3576. State: failed. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/minimize_time_for_return_skipped into lp:~widelands-dev/widelands/mines-worldsavior

2018-08-12 Thread Toni Förster
The proposal to merge lp:~widelands-dev/widelands/minimize_time_for_return_skipped into lp:~widelands-dev/widelands/mines-worldsavior has been updated. Status: Needs review => Rejected For more details, see:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/minimize_time_for_return_skipped into lp:~widelands-dev/widelands/mines-worldsavior

2018-08-12 Thread hessenfarmer
I think we need to test this really good, as widelands is designed to run on great variety of platforms with low performance as well. Therefore I would like it to have the branch splitted from trunk and the merge request against trunk as well. Cause the mines-worldsavior branch is ready to

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands

2018-08-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 3776. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/415148977. Appveyor build 3575. State: failed. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1783878_editor_random_map_tribe into lp:widelands

2018-08-12 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1783878_editor_random_map_tribe into lp:widelands. Commit message: Random Map Generator now assigns a random tribe to all players. Fix crash when loading a map in the editor where there is a player with no tribe assigned.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lenient_allowed_buildings into lp:widelands

2018-08-12 Thread Notabilis
Review: Approve code I haven't tested it, but the code looks okay. One could consider displaying an in-game message instead/additionally to the console output. The console is probably overlooked by players, but a change in the building definitions could lead to broken scenario save games.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands

2018-08-12 Thread Notabilis
Notabilis has proposed merging lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands. Commit message: Fixing broken auto-scrolling of multi-line text areas. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1785404 in widelands: "Chat does not

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1784490-show-version-in-mac-finder into lp:widelands

2018-08-12 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1784490-show-version-in-mac-finder into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1784490-show-version-in-mac-finder/+merge/352874 --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1784490-show-version-in-mac-finder into lp:widelands

2018-08-12 Thread Toni Förster
@bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/bug-1784490-show-version-in-mac-finder/+merge/352874 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1784490-show-version-in-mac-finder into lp:widelands.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2018-08-12 Thread bunnybot
Continuous integration builds have changed state: Travis build 3772. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/415039555. Appveyor build 3571. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition into lp:widelands

2018-08-12 Thread Klaus Halfmann
Mhh, travis had no sucess with any instalaltions, but did not actually compile anything on linux. Gun: can this go in anyway or shall we resubmit this? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594 Your team Widelands Developers is

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/minimize_time_for_return_skipped into lp:~widelands-dev/widelands/mines-worldsavior

2018-08-12 Thread Toni Förster
Toni Förster has proposed merging lp:~widelands-dev/widelands/minimize_time_for_return_skipped into lp:~widelands-dev/widelands/mines-worldsavior. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1786613 in widelands: "production times are 10s longer when

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/minimize_time_for_return_skipped into lp:~widelands-dev/widelands/mines-worldsavior

2018-08-12 Thread Toni Förster
The proposal to merge lp:~widelands-dev/widelands/minimize_time_for_return_skipped into lp:~widelands-dev/widelands/mines-worldsavior has been updated. Status: Needs review => Superseded For more details, see:

[Widelands-dev] [Merge] lp:~stonerl/widelands/big_inn_missing_animation_fixed into lp:~widelands-dev/widelands/mines-worldsavior

2018-08-12 Thread noreply
The proposal to merge lp:~stonerl/widelands/big_inn_missing_animation_fixed into lp:~widelands-dev/widelands/mines-worldsavior has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~stonerl/widelands/big_inn_missing_animation_fixed/+merge/352887

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/odd_locale_fix into lp:widelands

2018-08-12 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/odd_locale_fix into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/odd_locale_fix/+merge/352934 -- Your team Widelands Developers is subscribed to