Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe into lp:widelands

2018-10-26 Thread Notabilis
Review: Approve Code is looking good and last player has no longer the "random" tribe. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1797531-playermenu-tribe/+merge/356695 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands

2018-10-26 Thread Notabilis
Thanks for adding the test. The code is looking good, but for me the test fails: Error in Lua Coroutine [../src/scripting/lua_errors.cc:22] [string "test/maps/plain.wmf/scripting/test_inputqueue..."]:9: expected '8' but was '7'! I think the problem is that the barracks starts working

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands

2018-10-26 Thread bunnybot
Continuous integration builds have changed state: Travis build 4168. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/446543206. Appveyor build 3966. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1798812-replay-savegame-type into lp:widelands

2018-10-26 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1798812-replay-savegame-type into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1798812-replay-savegame-type/+merge/357588 -- Your team