Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe into lp:widelands
Review: Approve Code is looking good and last player has no longer the "random" tribe. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1797531-playermenu-tribe/+merge/356695 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1797531-playermenu-tribe. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands
Thanks for adding the test. The code is looking good, but for me the test fails: Error in Lua Coroutine [../src/scripting/lua_errors.cc:22] [string "test/maps/plain.wmf/scripting/test_inputqueue..."]:9: expected '8' but was '7'! I think the problem is that the barracks starts working immediately, consuming one carrier while doing so. Possible fixes would be either to stop the barracks (is that even possible by script?) or connecting it to the headquarter (should stop the barracks since there already are enough soldiers on store). -- https://code.launchpad.net/~widelands-dev/widelands/bug-1795871-lua-set_workers/+merge/357716 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1795871-lua-set_workers. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1795871-lua-set_workers into lp:widelands
Continuous integration builds have changed state: Travis build 4168. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/446543206. Appveyor build 3966. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1795871_lua_set_workers-3966. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1795871-lua-set_workers/+merge/357716 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1795871-lua-set_workers. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1798812-replay-savegame-type into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1798812-replay-savegame-type into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1798812-replay-savegame-type/+merge/357588 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1798812-replay-savegame-type. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
