GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1463829 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1463829 in widelands: "Building statistics: Last line needs more space"
https://bugs.launchpad.net/widelands/+b
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1485332 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1485332 in widelands: ""Standard is not a field in this table." when
accessing Options"
https://bugs.lau
Review: Needs Fixing
I just found that this breaks the regression tests. The problem is with
test/maps/lua_testsuite.wmf/scripting/test_lua_in_game.lua. The failing test is
function militarysite_tests:test_no_space().
--
https://code.launchpad.net/~widelands-dev/widelands/find_attack_soldiers/+
GunChleoc has proposed merging lp:~widelands-dev/widelands/string-fixes into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1421942 in widelands: "Unified term for "Black" and "Wasteland""
https://bugs.launchpad.ne
Review: Approve
I have added 2 small tweaks - if you like them, this is ready to go.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1489974/+merge/270240
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1489974.
_
Yes it is :(
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1489974/+merge/270240
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1489974.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to
Here's the documentation that I use for BZR.
Getting started:
https://wl.widelands.org/wiki/BzrPrimer/
Other beginner's docs:
http://doc.bazaar.canonical.com/latest/en/mini-tutorial/
http://doc.bazaar.canonical.com/bzr.2.6/en/_static/en/bzr-en-quick-reference.pdf
When you have messed up a b
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1401479 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1401479 in widelands: "Minimaps button images are scaled down instead of
cropped."
https://bugs.launchpad.net/wide
I just tested it, and the oak is still getting up. Maybe we do need a switch in
the animation after all to make sure that this is always clean (loop =
true/false). I think we will need a second version of NumberGlob in
graphics/animation.cc for this.
--
https://code.launchpad.net/~widelands-dev
Give us a shout when this is ready for review :)
You can also set the status for this merge request to "Work in progress" and
then back to "Needs review" when you're done.
--
https://code.launchpad.net/~meitis/widelands/bug1375915/+merge/270456
Your team Widelands Developers is requested to revi
GunChleoc has proposed merging lp:~widelands-dev/widelands/string-fixes into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1421942 in widelands: "Unified term for "Black" and "Wasteland""
https://bugs.launchpad.ne
I think smaller merges are easier to review. So, unless you need any of the
code changes done here as a prerequisite for fixing the other bug, a separate
branch should be easier to handle.
--
https://code.launchpad.net/~meitis/widelands/bug1375915/+merge/270456
Your team Widelands Developers is
The change you commented is straight quote -> curly quote. So, no addicental
whitespace added - may editor will strip any trailing whitespaces anyway.
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/270856
Your team Widelands Developers is subscribed to branch
lp:~wide
I just found something else that we might want to lose in instances.h:
/// This is just a fail-safe guard for the time until we fully
transition
/// to the new MapObject saving system
virtual bool has_new_save_support() {return false;}
Does anybody remember what that is a
I haven't found the time to try to resolve my local website deployment
problems. Code LGTM though.
Maybe you could create a screenshot to post on the forums for people to give
feedback?
--
https://code.launchpad.net/~franku/widelands-website/css_changes/+merge/271388
Your team Widelands Develop
GunChleoc has proposed merging lp:~widelands-dev/widelands/string-fixes into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1421942 in widelands: "Unified term for "Black" and "Wasteland""
https://bugs.launchpad.ne
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1492114 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1492114 in widelands: "Making the message window smaller"
https://bugs.launchpad.net/widelands/+bug/1492114
For mo
GunChleoc has proposed merging lp:~widelands-dev/widelands/japanese into
lp:~widelands-dev/widelands/arabic.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1311698 in widelands: "Non-spacing sentences could not be break
automatically"
https://bugs.lau
GunChleoc has proposed merging lp:~widelands-dev/widelands/s2_map into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/s2_map/+merge/272877
Changed string data types in S2MapDescrHeader to fixed
Tested and LGTM. Sorry it took me so long.
Just one code convention thing: could you please rename planAtLeastOne to
plan_at_least_one?
In light if w-zocker's comment, I think you can also remove the TODO comment. I
have also noticed another case of behaviour that's not wanted, but that
probl
The trees are still getting up for me :(
--
https://code.launchpad.net/~widelands-dev/widelands/bug1480928/+merge/270540
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1480928.
___
Mailing list: https://launchpad.
Review: Resubmit
The table sorting bug should be fixed now.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1390793/+merge/254558
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1390793.
___
Mailing li
I have removed the NOCOM, thanks.
I don't know what you mean by set starting position - I tried both map origin
and players, and I don't have to click twice.
The map origin tool is a bit confusing, because there is no marker on the map
to indicate that it actually has been set. It would be nice
This is only for loading old Settlers 2 maps. When you save them, they will be
saved as Widelands maps. So no, it won't break savefile compatibility, because
there is no saving involved ;)
--
https://code.launchpad.net/~widelands-dev/widelands/s2_map/+merge/272877
Your team Widelands Developers
Thanks for the review :)
--
https://code.launchpad.net/~widelands-dev/widelands/s2_map/+merge/272877
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/s2_map.
___
Mailing list: https://launchpad.net/~widelands-dev
Post
Yep, it's a lot of code. Thanks for the review :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1390793/+merge/254558
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1390793.
___
Mailing list: https:/
Review: Approve
I have tested it and LTGM :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug580923/+merge/273274
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug580923.
___
Mailing list: https://launchp
Review: Resubmit
We still have files like map_building_packet and map_buildingdata_packet, so I
think part of the files are still using the old system. I'll leave the function
in for this branch.
I also fixed the crash that Tibor found - some code didn't get updated properly
during one of the
The ICU dependency was already tested some time ago by SirVer for Mac and by
Toni for Windows, so I think we're fine there. One of our localizers helped me
with the Arabic script, so I hope we didn't miss anything with the glyphs.
--
https://code.launchpad.net/~widelands-dev/widelands/arabic/+me
Thanks :)
--
https://code.launchpad.net/~widelands-dev/widelands/arabic/+merge/272520
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/arabic.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widela
GunChleoc has proposed merging lp:~widelands-dev/widelands/japanese into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1311698 in widelands: "Non-spacing sentences could not be break
automatically"
https://bugs.launchpad.net/wide
Review: Approve
LGTM :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug1502458/+merge/273345
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1502458.
___
Mailing list: https://launchpad.net/~widelands-d
Actually, the fonts come with Widelands, so you can switch anytime if you
remember where which button is - I don't read Japanese either *lol
I don't know if your Japanese localizers can compile, so I will merge this and
ask them for testing later.
--
https://code.launchpad.net/~widelands-dev/wi
I have added 2 replays to https://bugs.launchpad.net/widelands/+bug/1499678 -
seems like this still needs some tweaking.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_persistent_data/+merge/271853
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_p
I didn't know that there was a basic binary file to add in addition to the dir,
which I have now accidentally deleted. So, I'll have to recreate them. I player
Long, Long Way with the first 3 AIs set to Atlanteans and the rest to
Barbarians and Empire.
--
https://code.launchpad.net/~widelands-d
GunChleoc has proposed merging lp:~widelands-dev/widelands/rtl_wordwrap into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/rtl_wordwrap/+merge/273968
Wordwrap now uses the new font renderer
GunChleoc has proposed merging lp:~widelands-dev/widelands/textareas_and_labels
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/textareas_and_labels/+merge/274054
Textareas now use the new
The proposal to merge lp:~widelands-dev/widelands/textareas_and_labels into
lp:widelands has been updated.
Description changed to:
Textareas now use the new font handler. Added automatic resizing for labels.
- Table headers change their height automatically according to font size.
- Spinboxes
Review: Approve
The assert(nr_players <= 99) isn't a loop boundary, it is there to ensure that
a condition is met. In debug mode, if the condition isn't met, Widelands will
terminate with a message. The reason for assertions is to define certain wanted
behaviour and thus help guard against regr
GunChleoc has proposed merging lp:~widelands-dev/widelands/buttons into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/buttons/+merge/274064
Buttons now use the new font renderer and have
Review: Approve
Yes, the _ macro is perfectly fine.
We only need the fancy stuff if the string contains a number placeholder, or if
we have a string that comes up multiple times, but we want to translate it
separately ("None", "Unknown", "Yes", "No" and "Other" are prime candidates for
those).
GunChleoc has proposed merging lp:~widelands-dev/widelands/multiplayer_help
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/multiplayer_help/+merge/274271
The Multiplayer help window now
GunChleoc has proposed merging lp:~widelands-dev/widelands/s2_map into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/s2_map/+merge/274627
Made Settlers II maps reappear in map selection windows
I can't say anything about how good the heuristics are, but I have added some
code style comments / ideas.
Diff comments:
> === modified file 'src/ai/ai_help_structs.h'
> --- src/ai/ai_help_structs.h 2015-08-19 19:29:56 +
> +++ src/ai/ai_help_structs.h 2015-10-05 17:29:41 +
> @@ -303,7
Added comments to your comments :)
Diff comments:
>
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc 2015-08-28 19:09:59 +
> +++ src/ai/defaultai.cc 2015-10-05 17:29:41 +
> @@ -690,8 +733,98 @@
> taskDue[ScheduleTasks::kUnbuildableFCheck] = 1000;
>
Dito :)
I just noticed that you didn't increase the version number for the savegame
packet where you made the changes. This is needed so that Widelands will show
an error message instead of crashing when a user tries to load an older game.
Diff comments:
>
> === modified file 'src/ai/default
Seems like Tibor hasn't had time to check back here, but I'm going to merge
this now anyway - I need this branch to finish up one_tribe, which will then be
ready for testing :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1291904/+merge/237128
Your team Widelands Developers is subs
Review: Approve
I had a look at the impact of None vs. Failed - it is for the statistics only.
Since it doesn't matter to have the productivity go down if there is no use for
ships anyway, LGTM :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug1504948/+merge/274076
Your team Wideland
Thanks for checking again. I think we're fine now :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1291904/+merge/237128
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1291904.
___
Mailing list: http
GunChleoc has proposed merging
lp:~widelands-dev/widelands/map_building_packet_version into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/map_building_packet_version/+merge/274941
We need some
Increase it to 17 please.
Diff comments:
>
> === modified file 'src/game_io/game_player_info_packet.cc'
> --- src/game_io/game_player_info_packet.cc2014-10-12 07:35:42 +
> +++ src/game_io/game_player_info_packet.cc2015-10-19 20:06:10 +
> @@ -30,7 +30,12 @@
>
> namespace Widela
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1508117 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1508117 in widelands: "New game menu can trigger assert"
https://bugs.launchpad.net/widelands/+bug/1508117
For mo
Thanks for the 2 reviews :)
--
https://code.launchpad.net/~widelands-dev/widelands/map_building_packet_version/+merge/274941
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_building_packet_version.
___
Mailing lis
GunChleoc has proposed merging lp:~widelands-dev/widelands/tables_empty_check
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/tables_empty_check/+merge/275312
Added new "empty() functi
You need to switch your interface language to something other then English in
order for it to appear. The function does not make sense if the player looks at
the English map names anyway.
--
https://code.launchpad.net/~widelands-dev/widelands/textareas_and_labels/+merge/274054
Your team Wideland
Thanks for the review :)
--
https://code.launchpad.net/~widelands-dev/widelands/textareas_and_labels/+merge/274054
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/textareas_and_labels.
___
Mailing list: https://launch
I am getting this error on trunk as well.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_persistent_data/+merge/271853
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_persistent_data.
___
Mailing list: h
GunChleoc has proposed merging lp:~widelands-dev/widelands/block_dummy_scenario
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/block_dummy_scenario/+merge/275563
Disable OK button while the
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1171231 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1171231 in widelands: "Size of minimap in the editor not changed when
new map is loaded"
https://bugs.lau
Review: Approve
My guess is that it does - but not caused by this branch. So, this can go in
now :)
--
https://code.launchpad.net/~widelands-dev/widelands/ai_persistent_data/+merge/271853
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_persistent_data.
___
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1509301 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1509301 in widelands: "Loading older multiplayer savegame doesn't work"
https://bugs.launchpad.net/widelan
GunChleoc has proposed merging
lp:~widelands-dev/widelands/unhandled_version_error into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/unhandled_version_error/+merge/275630
Added packet names to
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1509452 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1509452 in widelands: "Scenario maps aren't loaded as scenarios"
https://bugs.launchpad.net/widelands/+bug/15
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1480928 into
lp:widelands with lp:~widelands-dev/widelands/one_tribe as a prerequisite.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1480928 in widelands: "Lumberjack animation glitches&quo
Excellent :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1509301/+merge/275624
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1509301.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to
Review: Approve
LGTM :)
I don't know how to force the check.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_return_added/+merge/275638
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_return_added.
___
Here's the answer:
http://stackoverflow.com/questions/1610030/why-can-you-return-from-a-non-void-function-without-returning-a-value-without-pr
-Werror=return-type will treat just that warning as an error.
Full manual:
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
--
https://code.laun
So I guess we better shift the return statement a few lines up into the else
block.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_return_added/+merge/275638
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_return_added.
__
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-986611-asserts
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #986611 in widelands: "Issues reported by cppcheck"
https://bugs.launchpad.net/widelands/+bug/986611
For mo
The proposal to merge lp:~widelands-dev/widelands/ai_return_added into
lp:widelands has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ai_return_added/+merge/275638
--
Your team Widelands Developers is subscribed to
GunChleoc has proposed merging lp:~widelands-dev/widelands/ai_null_enemy into
lp:widelands.
Requested reviews:
TiborB (tiborb95)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ai_null_enemy/+merge/275673
Fixed a crash in AI when enemy slots are empty.
To
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1507923 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1507923/+merge/275676
This fixes the sefaring bug - Jens found the
I don't know that we would gain anything by this - it would add extra continue
statements where we already have continue statements that do the job. There
isn't just one major loop where we can put this on top - these are all separate
places in the code.
Maybe you can reorder things so that we
How about:
Player other = game().get_player(j);
TeamNumber const tm = other ? other->team_number() : 0;
etc.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_null_enemy/+merge/275673
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_null_enem
Oops, I mean Player* other...
--
https://code.launchpad.net/~widelands-dev/widelands/ai_null_enemy/+merge/275673
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_null_enemy.
___
Mailing list: https://launchpad.net/~
Done :)
--
https://code.launchpad.net/~widelands-dev/widelands/ai_null_enemy/+merge/275673
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_null_enemy.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to
Added a question.
Diff comments:
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc 2015-10-25 12:26:20 +
> +++ src/ai/defaultai.cc 2015-10-26 12:01:30 +
> @@ -5075,8 +5076,12 @@
> }
> // adding power of team (minus my power) divided by 2
> /
I think we're done now. I also found an instance where the team number was
fetched twice.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_null_enemy/+merge/275673
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_null_enemy.
I think the comment wasn't saved - I don't see it.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_null_enemy/+merge/275673
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_null_enemy.
___
Mailing list: ht
Yep, got it and fixed it. I don't think that we need an assert here, so unless
you find something else to improve on, we're done :)
--
https://code.launchpad.net/~widelands-dev/widelands/ai_null_enemy/+merge/275673
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wideland
Thanks for helping me fix this up :)
--
https://code.launchpad.net/~widelands-dev/widelands/ai_null_enemy/+merge/275673
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_null_enemy.
___
Mailing list: https://launchpa
I just grabbed a fresh copy of this branch from Launchpad and I can't reproduce
the problem. Maybe try giving your local copy a different name?
If you don't want to deal with this right now, you can give this review low
priority, because one_tribe needs to go in first anyway.
--
https://code.la
GunChleoc has proposed merging lp:~widelands-dev/widelands/map_compatibility
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/276088
There is a problem with loading
Review: Approve
LGTM :)
I couldn't get the AI to mount a successful expedition though, due to lack of
gold. The AI did conquer the required mountain, but didn't send out any
geologists. Maybe as a next step, the AI could give the search for gold higher
priority once there is a port or training
Thanks for all the reviews :)
Well, I could have my ! wrong :P
--
https://code.launchpad.net/~widelands-dev/widelands/bug-986611-asserts/+merge/275642
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-986611-asserts.
_
The mountain is conquered, but no geologists sent out.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_persdata_fix/+merge/276056
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_persdata_fix.
___
Mailing
I had a look at the map in the editor, the gold isn't where I thought is was.
So, forget that I said anything - the AI is probably fine :)
--
https://code.launchpad.net/~widelands-dev/widelands/ai_persdata_fix/+merge/276056
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev
Some comments to the code review - posting them here rather than in the code in
order not change the branch, in case you're still working on it:
Regarding
http://bazaar.launchpad.net/~widelands-dev/widelands/one_tribe/revision/7452#tribes/init.lua
We do need the number glob for parsing the anim
Regarding
http://bazaar.launchpad.net/~widelands-dev/widelands/one_tribe/revision/7452#tribes/buildings/militarysites/atlanteans/guardhouse/init.lua
Renaming "outputs" to "occupants" won't work, because this is a feature of
production sites in general and not just militarysites.
--
https://code
Thanks for the review!
Regarding the lookup tables
http://bazaar.launchpad.net/~widelands-dev/widelands/one_tribe/revision/7464
We do need the compatibility, because map loading has a building packet etc. I
only included those entities in it that can't be avoided for map loading. I
decided to r
Yes, I would like to have this. I don't know how to fix the Python stuff for
the test suite, which is why this branch is still waiting.
I think other things are highter priority though - I'd be happy to target this
for Build 20.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1397500
I have a question regarding this comment:
// NOCOM(#codereview): no need to be static?
std::vector Tribes::get_all_tribeinfos()
This function is used in the GameSettingsProvider classes before an egbase is
created. Is there a better design than using static for this?
--
https://code.launchpad.
Review: Approve
Tested and LGTM. +1 for the renaming :)
--
https://code.launchpad.net/~widelands-dev/widelands/fleet_update/+merge/276457
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fleet_update.
___
Mailing list
Review: Approve
I haven't tested this, but code LTGM :)
--
https://code.launchpad.net/~franku/widelands-website/little_navi_changes/+merge/276625
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://lau
I like learning good coe design though, so I'll put it on the todo-list :)
--
https://code.launchpad.net/~widelands-dev/widelands/one_tribe/+merge/274832
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/one_tribe.
___
Review: Approve
LGTM :)
--
https://code.launchpad.net/~widelands-dev/widelands/ai_seafaring_tweaks/+merge/276589
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_seafaring_tweaks.
___
Mailing list: https://launchpa
GunChleoc has proposed merging lp:~widelands-dev/widelands/purpose_helptexts
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/purpose_helptexts/+merge/276931
All buildings now have a purpose
This should not happen - could you open a bug report please and fix up the
files in this branch manually?
We then still need to review the Lua code, and somebody needs to have a look at
my C++ changes in r7571. Since the diff is truncated, it is this commit:
https://bazaar.launchpad.net/~widela
Actually it is good that you forgot to check - because this gave us info about
bugs that need fixing in trunk :)
--
https://code.launchpad.net/~widelands-dev/widelands/artifacts/+merge/276527
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/artifacts.
_
GunChleoc has proposed merging lp:~widelands-dev/widelands/warehouse_worker
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/warehouse_worker/+merge/277221
Fixed bug in warehouse where check
601 - 700 of 4401 matches
Mail list logo
