Indeed, spectators are working. Guess I mixed something up.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1623375-multiplayer-starting-view/+merge/343287
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1623375-multiplayer-starting-view.
The proposal to merge
lp:~widelands-dev/widelands/bug-1623375-multiplayer-starting-view into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1623375-multiplayer-starting-view/+merge/343287
--
Y
Spectators already work for new games. I have added your fix.
Thanks for the review :)
@bunnybot merge
Diff comments:
>
> === modified file 'src/wui/interactive_gamebase.cc'
> --- src/wui/interactive_gamebase.cc 2018-04-07 16:59:00 +
> +++ src/wui/interactive_gamebase.cc 2018-04-16
Review: Approve
Testing worked fine, one comment in the diff.
As a suggestion: What about moving spectators to the first player position on
new games, too?
Diff comments:
>
> === modified file 'src/wui/interactive_gamebase.cc'
> --- src/wui/interactive_gamebase.cc 2018-04-07 16:59:00 +
/_widelands_dev_widelands_bug_1623375_multiplayer_starting_view-3188.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1623375-multiplayer-starting-view/+merge/343287
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1623375-multiplayer-starting-view
ultiplayer games with the map view at position
0,0, which is often unexplored.
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1623375-multiplayer-starting-view into
lp:widelands.
=== modified file 'src/logic/game.cc'
--- src/logic/ga
6 matches
Mail list logo
