The UnorderedObjectListWarning can be fixed by giving the models a default
ordering. Not really complicated :-)
--
https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065
Your team Widelands Developers is subscribed to branch lp:widelands-website.
Agreed, let's have a follow-up branch.
As to the UnorderedObjectListWarning, the sorting probably isn't stable when
adding pagination. Is there an OrderedObjectList or something like that that we
can use instead? Should make the warning go away in theory.
--
The proposal to merge lp:~widelands-dev/widelands-website/django1_11 into
lp:widelands-website has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065
--
Your team Widelands Develop
Oh, there are some warnings about unordered lists:
UnorderedObjectListWarning: Pagination may yield inconsistent results with an
unordered object_list: QuerySet.
UnorderedObjectListWarning: Pagination may yield inconsistent results with an
unordered object_list: QuerySet.
The update is made on the productive website. I've encountered some problems in
the database:
When applying the migrations i got some foreign constraints error:
django.db.utils.IntegrityError: (1452, 'Cannot add or update a child row: a
foreign key constraint fails
alpha is shut down again.
--
https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Post
Shit happens. Let me know if/when you want me to do some schedule testing.
--
https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing
> The scheduler is producing an error.
I got the errors... My fault :-(. When switching the database i had forgotten
to run the migrate command.
Will try to give you moderator permissions this weekend.
--
https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065
Your
Yes, all emails look fine. I also tested image uploading.
The scheduler is producing an error.
I think it would be good for me to have access to moderator functions on the
forums. Otherwise, you'll be the only one who can o it, since SirVer doesn't
have the time any more.
--
As far as i can see the Email subjects are solved.
I will announce the website downtime and schedule the update for the next week.
@GunChleoc: Regarding your permissions: On alpha you are set as superuser,
whereas on wl.widelands you are not a superuser. Thats the difference regarding
the
Review: Needs Fixing
Regarding the screenshots: They old ones aren't physical there. I have tested
it by adding two categories and uploaded two images to each categorie.
The online_users_middleware does not work as i expected... Hitting 'log out'
does not remove the user name from the list.
The proposal to merge lp:~widelands-dev/widelands-website/django1_11 into
lp:widelands-website has been updated.
Description changed to:
Major update of the website code to Django 1.11.12. I have gone through all
release notes form Django 1.8 until Django 1.11.
- Added migrations
Got the callback function to work. Will apply the latest change to the alpha
site, so this can also be tested in production. Have to shut down and restart
the alpha site again...
--
https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065
Your team Widelands
> Can you give an example for real world name containing an apostrophe?
John O'Neill, Iain Mac a' Ghobhainn
+1 for Unicode names, that would be really cool :)
I don't think that we need to resolve the username issue in this branch though.
I'll try to get some testing in this week.
--
Allowing ' needs implementing an own username validator. Can you give an
example for real world name containing an apostrophe?
What we should consider is to allow unicode characters in usernames, so french,
or polish names can be used.See
Review: Approve
*waves to SirVer*
Can we disallow usernames with "." or "@" in them? Allowing ' would be good,
since that character is used in real-world names.
I had a look at the diff as far as Launchpad will display it. Just 1 potential
nit.
Since the alpha site is already switched off, I
The proposal to merge lp:~widelands-dev/widelands-website/django1_11 into
lp:widelands-website has been updated.
Description changed to:
Major update of the website code to Django 1.11.12. I have gone through all
release notes form Django 1.8 until Django 1.11.
- Added migrations
Thanks, SirVer. Nice to hear from you :-)
I assume you logged in on the alpha site, and this worked so far?
I will shut down alpha tomorrow, in the morning.
--
https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065
Your team Widelands Developers is subscribed to
Review: Approve
Thanks for this massive update and keeping our homepage alive and kicking!
Drive by comment, only refering to the questions you've asked. I did not review
the rest of the change - it seems massive.
> Providing usernames for JS when writing PMs: This is maybe a security risk
>
the proposed merge of
lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More
Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscri
21 matches
Mail list logo
