Continuous integration builds have changed state:
Travis build 2742. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/296463258.
Appveyor build 2554. State: failed. Details:
OK, so dequeue is fine then - I just wanted to make sure.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/ai_variables_rework/+merge/333041
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_variables_rework into
Continuous integration builds have changed state:
Travis build 2743. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/296669731.
Appveyor build 2555. State: failed. Details:
No, it doesn't work :(
Whereas the version of pocount used by me has an option '--no-color', it is
maybe better to use another pocount output format like --csv in combination
with python csv module?
https://docs.python.org/2/library/csv.html?highlight=csv#module-csv
I guess the csv format
The proposal to merge lp:~widelands-dev/widelands/ai_variables_rework into
lp:widelands has been updated.
Commit Message changed to:
Internal AI variables changed where suitable to a) std::deques, b) to static in
order to reduce number of memory de/allocations
For more details, see:
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/ai_variables_rework/+merge/333041
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_variables_rework into lp:widelands.
___
The proposal to merge lp:~widelands-dev/widelands/bug-1728006 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1728006/+merge/333094
--
Your team Widelands Developers is subscribed to branch
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 2742. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/296463258.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_small_requests/+merge/332519
Your team
Review: Resubmit
This should be ready now.
I added the remaining comments as NOCOM to the code for easier review and
addressed all the rest. I have answered in the code.
For full testing, take the datadir from
https://code.launchpad.net/~widelands-dev/widelands/dynamic_tribe_loading_datadir
Now tested and confirmed as working :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/ai_small_requests/+merge/332519
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_small_requests.
___
Much better! No idea why I didn't use the csv format in the first place.
--
https://code.launchpad.net/~widelands-dev/widelands/translation_stats/+merge/332029
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/translation_stats.
Can you set a commit message above, then merge?
--
https://code.launchpad.net/~widelands-dev/widelands/ai_variables_rework/+merge/333041
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_variables_rework into lp:widelands.
Review: Approve
I have done some testing now.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1728006/+merge/333094
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1728006.
___
Thanks for the review! And for the grammar errors... ehem.
After some testing I am no longer so sure about the trimming of chat messages.
Currently it is possible to send space-only messages to everyone or as a
whisper message to a single player. So we should probably remove trailing (and
Answered the diff comments, I'm still waiting for the compiler for the fixes.
Will have a look at the bugs after that.
Diff comments:
> === modified file 'src/game_io/game_preload_packet.cc'
> --- src/game_io/game_preload_packet.cc2017-08-17 15:34:45 +
> +++
I am now testing for non-Word characters rather than tabs or spaces. Does that
work for you?
--
https://code.launchpad.net/~widelands-dev/widelands/translation_stats/+merge/332029
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/translation_stats.
I just run game with seafaring map and AI was building ports as expected. But I
had not tested opposite scenario...
--
https://code.launchpad.net/~widelands-dev/widelands/ai_small_requests/+merge/332519
Your team Widelands Developers is subscribed to branch
The proposal to merge lp:~widelands-dev/widelands/ai_variables_rework into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ai_variables_rework/+merge/333041
--
Your team Widelands Developers is
Continuous integration builds have changed state:
Travis build 2745. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/296920388.
Appveyor build 2557. State: success. Details:
Continuous integration builds have changed state:
Travis build 2741. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/296462614.
Appveyor build 2553. State: failed. Details:
Continuous integration builds have changed state:
Travis build 2746. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/296921592.
Appveyor build 2558. State: success. Details:
I actually removed that https on purpose, it adds visual clutter and makes the
string too long to fir.
--
https://code.launchpad.net/~widelands-dev/widelands/translation_stats/+merge/332029
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/translation_stats.
It redirects me to https://wl.widelands.org/
--
https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list:
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1716166-ai-strength-assert into lp:widelands.
Commit message:
Fixed hard-coded values in DefaultAI::calculate_strength
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1716166 in widelands:
Ah, i had this also... try to clean the browsers cache or
http://alpha.widelands.org
--
https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605
Your team Widelands Developers is subscribed to branch lp:widelands-website.
Now its working :-)
Could you please add 'https://' to the underlined link for "...please visit
widelands.org/wiki/TranslatinWidelands"
--
https://code.launchpad.net/~widelands-dev/widelands/translation_stats/+merge/332029
Your team Widelands Developers is subscribed to branch
Continuous integration builds have changed state:
Travis build 2747. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/296944647.
Appveyor build 2559. State: failed. Details:
That was more of a question for Kaputtnik - you are fixing 2 things here. He
commented that 1724073 is fixed, but not on the other bug. I don't want to
spend time testing whether the other bug is indeed fixed if he has already done
so.
--
> Does this still need testing for the seafaring buildings?
Yes. Bug 1722376 needs testing (if Tibor didn't test it already), but bug
1724073 is fixed with this branch.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_small_requests/+merge/332519
Your team Widelands Developers is
29 matches
Mail list logo
