Review: Resubmit
OK, ready for testing
--
https://code.launchpad.net/~widelands-dev/widelands/findpath_modification/+merge/337103
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/findpath_modification.
___
Mailing
Continuous integration builds have changed state:
Travis build 3160. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/339824814.
Appveyor build 2967. State: success. Details:
Continuous integration builds have changed state:
Travis build 3163. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/339870358.
Appveyor build 2970. State: success. Details:
Continuous integration builds have changed state:
Travis build 3161. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/339825678.
Appveyor build 2968. State: success. Details:
kaputtnik has proposed merging
lp:~widelands-dev/widelands/bug-1744583_fix_building_help into lp:widelands.
Commit message:
Fixing buildinghelp by adding a method to enclose strings in rt tags
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1744583 in widelands:
"I thought there was an AI hint that allows the AI to realize a building needs
a helper" - it works this way, but the hint must be put in helper's hints via
'supports_production_of'
--
https://code.launchpad.net/~widelands-dev/widelands/frisians/+merge/336910
Your team Widelands Developers is
There was no real problem, but wrong documentation. Nevertheless this change
will make it possible to work with the returned building, e.g. using
building.flag for creating roads or query building.descr.
--
kaputtnik whats the problem then?
Is it worth, me taking a look?
--
https://code.launchpad.net/~widelands-dev/widelands/fix_infrastructure_return_values/+merge/337364
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_infrastructure_return_values.
Klaus, this code is only used in scenarios or campaigns.
I grep'd through the data directory and currently all campaigns which use
prefilled_buildings() or place_building_in_region() didn't use any return
values. I would have been surprised if they do :-D
The branch linked in bug 1639514 uses
Continuous integration builds have changed state:
Travis build 3158. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/339813465.
Appveyor build 2965. State: success. Details:
kaputtnik has proposed merging
lp:~widelands-dev/widelands/bug-1639514_fix_yellow_player into lp:widelands
with lp:~widelands-dev/widelands/fix_infrastructure_return_values as a
prerequisite.
Commit message:
Use ai="empty" for second barbarian campaign
Requested reviews:
Widelands
Review: Needs Fixing
The view of Players available needs fixing:
http://preview.ibb.co/iewcqn/scheduling_show_dates.png
The position of the PM clock is messed up. Currently the available dates/hours
for one user is shown in a column and the next column shows the available times
for the next
I started all the campaign and tutorial scenarios without problems, so it's OK.
Thanks for fixing :)
BTW we forgot to set a commit message ;)
--
https://code.launchpad.net/~widelands-dev/widelands/fix_infrastructure_return_values/+merge/337364
Your team Widelands Developers is subscribed to
You probably need 2 lists, one with the buildings to build, and one with the
buildings built. The buildings built list can then be checked whether they're
occupied and if so, be removed from the second list.
Or you can expand the first list with number of buildings built and only build
new
Yes, single list will not do. And I have to pay attention to the game saving
aspect as well.
I spent a lot of time with another branch - findpath_modification, and if this
will be OK now, I can come back to this...
--
Review: Needs Fixing
Three console errors on startup.
ERROR: Unused key "requires_helper" in LuaTable. Please report as a bug.
Generated by beekeepers hut, aqua farm and collector
--
https://code.launchpad.net/~widelands-dev/widelands/frisians/+merge/336910
Your team Widelands Developers is
Review: Approve
Code LGTM, not tested.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_infrastructure_return_values/+merge/337364
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_infrastructure_return_values.
GunChleoc has proposed merging lp:~widelands-dev/widelands/fh1-maps-plateau
into lp:widelands.
Commit message:
Converted "The Green Plateau" single player scenario to new font renderer
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
I thought there was an AI hint that allows the AI to realize a building needs a
helper, but apparently I was wrong, couldn´t find one in the documentation … I
removed the requires_helper.
The empire warehouse is now a custom building of the scenario. I am confident I
didn´t break saveloading
GunChleoc has proposed merging lp:~widelands-dev/widelands/fh1-maps-multiplayer
into lp:widelands.
Commit message:
Converted MP scenarios to new font renderer
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
> SirVer: we need a command "fail" in the debugconsole,
to trigger an assert that will kind of kill such a game.
Can you open a bug report and give more details on what we need? Once a merge
request is merged, chances are small that SirVer will look at the comments a
all ;)
--
The proposal to merge
lp:~widelands-dev/widelands/fix_infrastructure_return_values into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix_infrastructure_return_values/+merge/337364
--
Your team
Review: Approve
SO actually you next branch will use and then test it.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/fix_infrastructure_return_values/+merge/337364
Your team Widelands Developers is subscribed to branch
23 matches
Mail list logo
